)]}'
{"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c4edce66c70f02ff3cca17428e0322c9e957cf45","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        for i in range(6):"},{"line_number":146,"context_line":"            (container_fmt, disk_fmt) \u003d random.choice(all_pairs)"},{"line_number":147,"context_line":"            cls._create_standard_image(container_fmt, disk_fmt)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @classmethod"},{"line_number":150,"context_line":"    def _create_standard_image(cls, container_format, disk_format):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_c20d8f3f","line":147,"updated":"2015-08-18 16:46:47.000000000","message":"Add a logging.debug() line before here. Because if _create_standard_image() fails it would be good to know easily for which combination of container_fmt, disk_fmt it failed.","commit_id":"6bfaaea91c7867f6ef6378dca3fdd78558517da9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"405053216312e5f72fbdaaa8b0107d3a2f1f7427","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        for i in range(6):"},{"line_number":146,"context_line":"            (container_fmt, disk_fmt) \u003d random.choice(all_pairs)"},{"line_number":147,"context_line":"            cls._create_standard_image(container_fmt, disk_fmt)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @classmethod"},{"line_number":150,"context_line":"    def _create_standard_image(cls, container_format, disk_format):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_0d76733e","line":147,"in_reply_to":"fa1b9901_c20d8f3f","updated":"2015-08-24 06:28:17.000000000","message":"Done","commit_id":"6bfaaea91c7867f6ef6378dca3fdd78558517da9"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a500295b0cc20c15dcbacf4c2314e8fcae4e43d8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                     for disk_fmt in disk_fmts]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        for i in range(6):"},{"line_number":148,"context_line":"            (container_fmt, disk_fmt) \u003d random.choice(all_pairs)"},{"line_number":149,"context_line":"            LOG.debug(\"Creating a image\""},{"line_number":150,"context_line":"                      \"(Container format: %s, Disk format: %s).\","},{"line_number":151,"context_line":"                      container_fmt, disk_fmt)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_cb548323","line":148,"updated":"2015-09-11 10:20:22.000000000","message":"hmm, I think a test case should be stable for stable testing. So \u0027random.choice\u0027 doesn\u0027t sound nice.\n\nHow about choosing first 6 combinations if you don\u0027t want to run all cases?","commit_id":"c6a3b4f39a02c9f923d4bfa662ff337890a48150"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"05182ec3dc1e7f3263155a225551272cf3735b77","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        if len(all_pairs) \u003c 6:"},{"line_number":148,"context_line":"            skip_msg \u003d \"The number of combinations of disk format \""},{"line_number":149,"context_line":"            \"and container format is not enough.\""},{"line_number":150,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        for i in range(6):"},{"line_number":153,"context_line":"            (container_fmt, disk_fmt) \u003d all_pairs.pop(0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_b2ea94d9","line":150,"updated":"2015-09-18 06:33:55.000000000","message":"hmm, I think if len(all_pairs) \u003c 6, we can test all test cases not skip.\nSo how about like this?\n\n test_len \u003d 6\n if len(all_pairs) \u003c 6:\n   test_len \u003d len(all_pairs)\n\n for i in range(test_len):\n  :","commit_id":"f4aa291bde764184514d80f6d39b1bcdb122e55f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85cd849e8ae30ad344eb776380e41c0ae36e22e1","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        test_len \u003d len(all_pairs) if len(all_pairs) \u003c 6 else 6"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        for i in range(test_len):"},{"line_number":150,"context_line":"            (container_fmt, disk_fmt) \u003d all_pairs.pop(0)"},{"line_number":151,"context_line":"            LOG.debug(\"Creating a image\""},{"line_number":152,"context_line":"                      \"(Container format: %s, Disk format: %s).\","}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_7614e9e7","line":149,"updated":"2015-09-18 10:46:05.000000000","message":"I am sorry I know I am becoming a pain but this should be:\n\n  for (container_fmt, disk_fmt) in all_pairs[:6]:","commit_id":"c8a98be6409c570cf87aec7b8d6f8d4c36a25062"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2ae5309a07e3b4735d8377b0e0a7fae19f883ea0","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        test_len \u003d len(all_pairs) if len(all_pairs) \u003c 6 else 6"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        for i in range(test_len):"},{"line_number":150,"context_line":"            (container_fmt, disk_fmt) \u003d all_pairs.pop(0)"},{"line_number":151,"context_line":"            LOG.debug(\"Creating a image\""},{"line_number":152,"context_line":"                      \"(Container format: %s, Disk format: %s).\","}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_a994668a","line":149,"in_reply_to":"ba15a1d1_7614e9e7","updated":"2015-09-18 11:14:44.000000000","message":"Nice  suggestion:)","commit_id":"c8a98be6409c570cf87aec7b8d6f8d4c36a25062"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7666b6c45888577d4c7cf724b428936a2bc6be5c","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    @test.idempotent_id(\u0027cf1b9a48-8340-480e-af7b-fe7e17690876\u0027)"},{"line_number":217,"context_line":"    def test_list_images_param_size(self):"},{"line_number":218,"context_line":"        # Test to get all images by size"},{"line_number":219,"context_line":"        image_id \u003d self.created_images[0]"},{"line_number":220,"context_line":"        # Get image metadata"},{"line_number":221,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_33a5b1b4","line":219,"updated":"2015-10-07 08:42:18.000000000","message":"I didn\"t catch that during my reviews, but may I ask why you change that part of the test ?","commit_id":"12a4851d792a332059531e98483a66676b5ac703"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"940bb2b9acd8911bfcc5590f51030e71fcaca9f2","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    @test.idempotent_id(\u0027cf1b9a48-8340-480e-af7b-fe7e17690876\u0027)"},{"line_number":217,"context_line":"    def test_list_images_param_size(self):"},{"line_number":218,"context_line":"        # Test to get all images by size"},{"line_number":219,"context_line":"        image_id \u003d self.created_images[0]"},{"line_number":220,"context_line":"        # Get image metadata"},{"line_number":221,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_33cb7120","line":219,"in_reply_to":"7a2fa921_33a5b1b4","updated":"2015-10-07 08:47:58.000000000","message":"If CONF.image.container_formats has only one element and CONF.image.disk_formats has only one element, only one image is created.\nThis change was made for the case of only one image.","commit_id":"12a4851d792a332059531e98483a66676b5ac703"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7666b6c45888577d4c7cf724b428936a2bc6be5c","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @test.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"},{"line_number":227,"context_line":"    def test_list_images_param_min_max_size(self):"},{"line_number":228,"context_line":"        # Test to get all images with size between 2000 to 3000"},{"line_number":229,"context_line":"        image_id \u003d self.created_images[0]"},{"line_number":230,"context_line":"        # Get image metadata"},{"line_number":231,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_b391c154","line":229,"updated":"2015-10-07 08:42:18.000000000","message":"Same","commit_id":"12a4851d792a332059531e98483a66676b5ac703"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"940bb2b9acd8911bfcc5590f51030e71fcaca9f2","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    @test.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"},{"line_number":227,"context_line":"    def test_list_images_param_min_max_size(self):"},{"line_number":228,"context_line":"        # Test to get all images with size between 2000 to 3000"},{"line_number":229,"context_line":"        image_id \u003d self.created_images[0]"},{"line_number":230,"context_line":"        # Get image metadata"},{"line_number":231,"context_line":"        image \u003d self.client.show_image(image_id)"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_53e62db5","line":229,"in_reply_to":"7a2fa921_b391c154","updated":"2015-10-07 08:47:58.000000000","message":"Same as above.","commit_id":"12a4851d792a332059531e98483a66676b5ac703"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7666b6c45888577d4c7cf724b428936a2bc6be5c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @test.idempotent_id(\u0027e914a891-3cc8-4b40-ad32-e0a39ffbddbb\u0027)"},{"line_number":250,"context_line":"    def test_list_images_param_limit(self):"},{"line_number":251,"context_line":"        # Test to get images by limit"},{"line_number":252,"context_line":"        params \u003d {\"limit\": 1}"},{"line_number":253,"context_line":"        images_list \u003d self.client.list_images(params\u003dparams)[\u0027images\u0027]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        self.assertEqual(len(images_list), params[\u0027limit\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_13899526","line":252,"updated":"2015-10-07 08:42:18.000000000","message":"And here.","commit_id":"12a4851d792a332059531e98483a66676b5ac703"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"940bb2b9acd8911bfcc5590f51030e71fcaca9f2","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @test.idempotent_id(\u0027e914a891-3cc8-4b40-ad32-e0a39ffbddbb\u0027)"},{"line_number":250,"context_line":"    def test_list_images_param_limit(self):"},{"line_number":251,"context_line":"        # Test to get images by limit"},{"line_number":252,"context_line":"        params \u003d {\"limit\": 1}"},{"line_number":253,"context_line":"        images_list \u003d self.client.list_images(params\u003dparams)[\u0027images\u0027]"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        self.assertEqual(len(images_list), params[\u0027limit\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_13ef5588","line":252,"in_reply_to":"7a2fa921_13899526","updated":"2015-10-07 08:47:58.000000000","message":"Same as above","commit_id":"12a4851d792a332059531e98483a66676b5ac703"}]}