)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"87947177a2591df1ea44ec0f0211673f17ce6b75","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def addCleanup_with_wait(self, waiter_callable, thing_id, thing_id_param,"},{"line_number":98,"context_line":"                             cleanup_callable, cleanup_args\u003dNone,"},{"line_number":99,"context_line":"                             cleanup_kwargs\u003dNone, waiter_client\u003dNone):"},{"line_number":100,"context_line":"        \"\"\"Adds wait for async resource deletion at the end of cleanups"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        @param waiter_callable: callable to wait for the resource to delete"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_08a69dc0","line":99,"updated":"2015-08-13 13:01:27.000000000","message":"It looks like we always have to specify some waiter_client to use this method. So will not it be better to make the waiter_client parameter positional?\n\n  def addCleanup_with_wait(self, waiter_callable, waiter_client, thing_id, thing_id_param, ...)","commit_id":"e91a0c66103444355067d72c214d9cedc718363a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5f393b2653a1e68ecaaaeffe1e7dd1aa0341fd97","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def addCleanup_with_wait(self, waiter_callable, thing_id, thing_id_param,"},{"line_number":98,"context_line":"                             cleanup_callable, cleanup_args\u003dNone,"},{"line_number":99,"context_line":"                             cleanup_kwargs\u003dNone, waiter_client\u003dNone):"},{"line_number":100,"context_line":"        \"\"\"Adds wait for async resource deletion at the end of cleanups"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        @param waiter_callable: callable to wait for the resource to delete"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_b67c87b6","line":99,"in_reply_to":"1a4dcd0f_08a69dc0","updated":"2015-08-14 02:24:42.000000000","message":"Yeah, a nice point.\nbut this method is used also for self.volumes_client.wait_for_resource_deletion, and waiter_client is not necessary in that case.\nThat is a reason why I defined this parameter as the optional.","commit_id":"e91a0c66103444355067d72c214d9cedc718363a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5f393b2653a1e68ecaaaeffe1e7dd1aa0341fd97","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                            volume[\u0027id\u0027])"},{"line_number":209,"context_line":"            self.addCleanup(self.delete_wrapper,"},{"line_number":210,"context_line":"                            self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            self.addCleanup_with_wait("},{"line_number":213,"context_line":"                waiter_callable\u003dself.volumes_client.wait_for_resource_deletion,"},{"line_number":214,"context_line":"                thing_id\u003dvolume[\u0027id\u0027], thing_id_param\u003d\u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7666ff2a","line":211,"updated":"2015-08-14 02:24:42.000000000","message":"here","commit_id":"e91a0c66103444355067d72c214d9cedc718363a"}]}