)]}'
{"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85dc0ae20693947749842539bcf4cc2d7a983994","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # there is no way to delete it from Cinder, so we delete it from Glance"},{"line_number":117,"context_line":"        # using the Glance image_client and from Cinder via tearDownClass."},{"line_number":118,"context_line":"        image_name \u003d data_utils.rand_name(\u0027Image\u0027)"},{"line_number":119,"context_line":"        body \u003d self.client.upload_volume("},{"line_number":120,"context_line":"            self.volume[\u0027id\u0027], image_name,"},{"line_number":121,"context_line":"            CONF.volume.disk_format)[\u0027os-volume_upload_image\u0027]"},{"line_number":122,"context_line":"        image_id \u003d body[\"image_id\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_7c71acdf","line":119,"updated":"2015-08-28 10:03:57.000000000","message":"i like this formatting (better than the previous vertical alignment)","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"}],"tempest/services/volume/json/volumes_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"120ed12b3758b5e1b76317efc17e73a679b95ab0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def get_attachment_from_volume(self, volume):"},{"line_number":39,"context_line":"        \"\"\"Return the element \u0027attachment\u0027 from input volumes.\"\"\""},{"line_number":40,"context_line":"        return volume[\u0027attachments\u0027][0]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _ext_get(self, url, key\u003dNone, status\u003d200):"},{"line_number":43,"context_line":"        \"\"\"Extended get method."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_38445cb5","line":41,"updated":"2015-08-31 02:28:49.000000000","message":"we should not have such extended method now, service client should return complete response.","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"a0de7d8e2c7e55a5aac156db53b5929bad925a83","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def get_attachment_from_volume(self, volume):"},{"line_number":39,"context_line":"        \"\"\"Return the element \u0027attachment\u0027 from input volumes.\"\"\""},{"line_number":40,"context_line":"        return volume[\u0027attachments\u0027][0]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _ext_get(self, url, key\u003dNone, status\u003d200):"},{"line_number":43,"context_line":"        \"\"\"Extended get method."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_fabec5ac","line":41,"in_reply_to":"da20952f_38445cb5","updated":"2015-08-31 13:33:36.000000000","message":"Done","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"120ed12b3758b5e1b76317efc17e73a679b95ab0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        If return_body is True then we will return the whole response body in"},{"line_number":81,"context_line":"        a ResponseBody class, it it\u0027s False or has not been specified we will"},{"line_number":82,"context_line":"        return only the list of volumes in a ResponseBodyList (inherits from"},{"line_number":83,"context_line":"        list)."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        url \u003d \u0027volumes\u0027"},{"line_number":86,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_f8e344d7","line":83,"updated":"2015-08-31 02:28:49.000000000","message":"Need to remove L80 to L83","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"a0de7d8e2c7e55a5aac156db53b5929bad925a83","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        If return_body is True then we will return the whole response body in"},{"line_number":81,"context_line":"        a ResponseBody class, it it\u0027s False or has not been specified we will"},{"line_number":82,"context_line":"        return only the list of volumes in a ResponseBodyList (inherits from"},{"line_number":83,"context_line":"        list)."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        url \u003d \u0027volumes\u0027"},{"line_number":86,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_3ac99d59","line":83,"in_reply_to":"da20952f_f8e344d7","updated":"2015-08-31 13:33:36.000000000","message":"Done","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"120ed12b3758b5e1b76317efc17e73a679b95ab0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        if params:"},{"line_number":89,"context_line":"            url +\u003d \u0027?%s\u0027 % self._prepare_params(params)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._ext_get(url, None)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def show_volume(self, volume_id):"},{"line_number":94,"context_line":"        \"\"\"Returns the details of a single volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_f831045b","line":91,"updated":"2015-08-31 02:28:49.000000000","message":"we do not need _ext_get method now. This was added to make get methods to return response with key or not which was needed for pagination tests.\n\njust below can be done directly - \n\nresp, body \u003d self.get(url)\n\nbody \u003d json.loads(body)\n\nself.expected_success(status, resp.status)\n\nreturn service_client.ResponseBody(resp, body)","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"a0de7d8e2c7e55a5aac156db53b5929bad925a83","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        if params:"},{"line_number":89,"context_line":"            url +\u003d \u0027?%s\u0027 % self._prepare_params(params)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._ext_get(url, None)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def show_volume(self, volume_id):"},{"line_number":94,"context_line":"        \"\"\"Returns the details of a single volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_7ab2b5e6","line":91,"in_reply_to":"da20952f_f831045b","updated":"2015-08-31 13:33:36.000000000","message":"Done","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"85dc0ae20693947749842539bcf4cc2d7a983994","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.show_volume(id)[\u0027volume\u0027]"},{"line_number":205,"context_line":"        except lib_exc.NotFound:"},{"line_number":206,"context_line":"            return True"},{"line_number":207,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_1c56705c","line":204,"updated":"2015-08-28 10:03:57.000000000","message":"If you send another PS: this is not needed because this method returns a bool","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"120ed12b3758b5e1b76317efc17e73a679b95ab0","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.show_volume(id)[\u0027volume\u0027]"},{"line_number":205,"context_line":"        except lib_exc.NotFound:"},{"line_number":206,"context_line":"            return True"},{"line_number":207,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_586fd02a","line":204,"in_reply_to":"da20952f_1c56705c","updated":"2015-08-31 02:28:49.000000000","message":"Yes, here we do not need.","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"a0de7d8e2c7e55a5aac156db53b5929bad925a83","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.show_volume(id)[\u0027volume\u0027]"},{"line_number":205,"context_line":"        except lib_exc.NotFound:"},{"line_number":206,"context_line":"            return True"},{"line_number":207,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_1aa7f9aa","line":204,"in_reply_to":"da20952f_586fd02a","updated":"2015-08-31 13:33:36.000000000","message":"Done","commit_id":"0f6ea540703a9bcfc95ffc59e7e497edb9527673"}]}