)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"882a7d2bf2c1d7239bb6baebdbd9dfb5e08780ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds 2 Unit Test Cases for BaremetalNodesClient."},{"line_number":10,"context_line":"Patch Set-6"},{"line_number":11,"context_line":"Modifications made as per comments given on Gerrit."},{"line_number":12,"context_line":"Change-Id: I909492cc7ffcc201baad1b57cdf86d83a427174f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da20952f_e61bf07e","line":11,"updated":"2015-09-03 07:59:08.000000000","message":"You do not need to add those line in commit msg.\n\u003ePatch Set-6\n\u003eModifications made as per comments given on Gerrit.","commit_id":"816e02427c077d123c5fdad6cc83a25ad631876a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02f6eaed3ea256911a058e491eed9da30f7d33cc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds 2 Unit Test Cases for BaremetalNodesClient."},{"line_number":10,"context_line":"Patch Set-6"},{"line_number":11,"context_line":"Modifications made as per comments given on Gerrit."},{"line_number":12,"context_line":"Change-Id: I909492cc7ffcc201baad1b57cdf86d83a427174f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da20952f_77e30c06","line":11,"in_reply_to":"da20952f_e61bf07e","updated":"2015-09-03 09:05:17.000000000","message":"Done","commit_id":"816e02427c077d123c5fdad6cc83a25ad631876a"}],"tempest/tests/services/compute/test_baremetal_nodes_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"91654d2b45b3121980e6c509887a62d277178671","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslotest import mockpatch"},{"line_number":17,"context_line":"from tempest.services.compute.json import baremetal_nodes_client"},{"line_number":18,"context_line":"from tempest.tests import base"},{"line_number":19,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestBareMetalNodesClient(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_355c3c7c","line":19,"updated":"2015-08-21 01:16:49.000000000","message":"Also please make import in order as per guidelines - http://docs.openstack.org/developer/hacking/#imports","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176096180944acdc390150c2f2dc7e2319f045b5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslotest import mockpatch"},{"line_number":17,"context_line":"from tempest.services.compute.json import baremetal_nodes_client"},{"line_number":18,"context_line":"from tempest.tests import base"},{"line_number":19,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestBareMetalNodesClient(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a7a7bfbb","line":19,"in_reply_to":"fa1b9901_355c3c7c","updated":"2015-08-21 02:49:36.000000000","message":"Done","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16cc2de1f4f084620b614d0c82a091c52cd46edd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":26,"context_line":"        self.bareMetalNodeClient \u003d baremetal_nodes_client.\\"},{"line_number":27,"context_line":"            BaremetalNodesClient(fake_auth, \u0027compute\u0027,"},{"line_number":28,"context_line":"                                 \u0027regionOne\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_75a154f7","line":28,"updated":"2015-08-21 01:12:19.000000000","message":"Use parentheses instead of backslash.\n\"It is preferred to wrap long lines in parentheses and not a backslash for line continuation.\"","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a155b2388b5ac9575b663198db4416c7d0e40026","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":26,"context_line":"        self.bareMetalNodeClient \u003d baremetal_nodes_client.\\"},{"line_number":27,"context_line":"            BaremetalNodesClient(fake_auth, \u0027compute\u0027,"},{"line_number":28,"context_line":"                                 \u0027regionOne\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_2ef4d858","line":28,"in_reply_to":"fa1b9901_75a154f7","updated":"2015-08-21 09:54:21.000000000","message":"Done","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16cc2de1f4f084620b614d0c82a091c52cd46edd","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."},{"line_number":32,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":33,"context_line":"        expected \u003d []"},{"line_number":34,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":35,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_55d3f05f","line":32,"updated":"2015-08-21 01:12:19.000000000","message":"this is not valida show node resp. make it like below-\n{\n    \"node\": {\n        \"cpus\": 8,\n        \"id\": 1,\n        \"instance_uuid\": null,\n        \"interfaces\": [\n            {\n                \"address\": \"aa:aa:aa:aa:aa:aa\",\n                \"datapath_id\": null,\n                \"id\": 1,\n                \"port_no\": null\n            }\n        ],\n        \"local_gb\": 128,\n        \"memory_mb\": 8192,\n        \"pm_address\": \"10.1.2.3\",\n        \"pm_user\": \"pm_user\",\n        \"pxe_config_path\": null,\n        \"service_host\": \"host\",\n        \"task_state\": null,\n        \"terminal_port\": 8000,\n        \"updated_at\": null,\n        \"uuid\": \"c862b836-c7c1-4f7f-8081-6766fa9cf38b\"\n    }\n}","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176096180944acdc390150c2f2dc7e2319f045b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."},{"line_number":32,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":33,"context_line":"        expected \u003d []"},{"line_number":34,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":35,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b5712c0e","line":32,"in_reply_to":"fa1b9901_55d3f05f","updated":"2015-08-21 02:49:36.000000000","message":"This is what I am working on.\nCan you let me know where can I get this information?(i.e. the complete dictionary ?)","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a155b2388b5ac9575b663198db4416c7d0e40026","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."},{"line_number":32,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":33,"context_line":"        expected \u003d []"},{"line_number":34,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":35,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_2e9b7819","line":32,"in_reply_to":"fa1b9901_b116164a","updated":"2015-08-21 09:54:21.000000000","message":"Done","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20258b613eaf2107ebe81c6bfcf40986db531c90","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_show_bareMetal_node_oneNode(self):"},{"line_number":31,"context_line":"        # In the Unit tests, params information is not required."},{"line_number":32,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":33,"context_line":"        expected \u003d []"},{"line_number":34,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 200}), body)"},{"line_number":35,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b116164a","line":32,"in_reply_to":"fa1b9901_b5712c0e","updated":"2015-08-21 06:22:19.000000000","message":"We have all API ref doc - http://developer.openstack.org/api-ref.html\n\nBut that not needed to be up to date.","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"16cc2de1f4f084620b614d0c82a091c52cd46edd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(expected,"},{"line_number":50,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def tearDown(self):"},{"line_number":53,"context_line":"        # fake_auth \u003d None"},{"line_number":54,"context_line":"        # self.bareMetalNodeClient \u003d None"},{"line_number":55,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_55853057","line":52,"updated":"2015-08-21 01:12:19.000000000","message":"This is not needed as it call only call base class one which will be called without overriding it here.","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a155b2388b5ac9575b663198db4416c7d0e40026","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(expected,"},{"line_number":50,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def tearDown(self):"},{"line_number":53,"context_line":"        # fake_auth \u003d None"},{"line_number":54,"context_line":"        # self.bareMetalNodeClient \u003d None"},{"line_number":55,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_11a7c20b","line":52,"in_reply_to":"fa1b9901_5153fa16","updated":"2015-08-21 09:54:21.000000000","message":"Done","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176096180944acdc390150c2f2dc7e2319f045b5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(expected,"},{"line_number":50,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def tearDown(self):"},{"line_number":53,"context_line":"        # fake_auth \u003d None"},{"line_number":54,"context_line":"        # self.bareMetalNodeClient \u003d None"},{"line_number":55,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_759b9418","line":52,"in_reply_to":"fa1b9901_55853057","updated":"2015-08-21 02:49:36.000000000","message":"In my observation, its a good practise to call the Teardown.\nIf there are anything which one has created in the program for Unit Tests, then those changes can be reverted in teardown.","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20258b613eaf2107ebe81c6bfcf40986db531c90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.assertEqual(expected,"},{"line_number":50,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def tearDown(self):"},{"line_number":53,"context_line":"        # fake_auth \u003d None"},{"line_number":54,"context_line":"        # self.bareMetalNodeClient \u003d None"},{"line_number":55,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5153fa16","line":52,"in_reply_to":"fa1b9901_759b9418","updated":"2015-08-21 06:22:19.000000000","message":"That will be called automatically. In overridden method you are not doing anything so no need to implement that. If concrete class add some logic to delete resources there then it needed.","commit_id":"9aade7fc46a39a861624c94f1bb096ee43abbee4"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"ead969a8c58945abff89e8fd61dd53ca6335d820","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":32,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":35,"context_line":"        nodeInfo \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":36,"context_line":"                    \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":37,"context_line":"                    \u0027host\u0027: \u002710.0.2.15\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_11d025f5","line":34,"updated":"2015-08-21 05:22:43.000000000","message":"If you want to use this method indirectly, you write as follows:\n\n     def _test_show_bareMetal_node(self, bodyBytes\u003dFalse):","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5074bac6cc5d84c2ede2d2248677e6e625a27708","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":32,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":35,"context_line":"        nodeInfo \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":36,"context_line":"                    \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":37,"context_line":"                    \u0027host\u0027: \u002710.0.2.15\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b16b76b6","line":34,"in_reply_to":"fa1b9901_11d025f5","updated":"2015-08-21 06:24:46.000000000","message":"Yea private function can be with _","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b42992f0efb0293663d2d89274a2a445413feef6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":32,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":35,"context_line":"        nodeInfo \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":36,"context_line":"                    \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":37,"context_line":"                    \u0027host\u0027: \u002710.0.2.15\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_ee3ca0e2","line":34,"in_reply_to":"fa1b9901_b16b76b6","updated":"2015-08-21 09:56:05.000000000","message":"Done","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"ead969a8c58945abff89e8fd61dd53ca6335d820","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                         self.bareMetalNodeClient."},{"line_number":59,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":62,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":63,"context_line":"        expected \u003d []"},{"line_number":64,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_717c01ec","line":61,"updated":"2015-08-21 05:22:43.000000000","message":"Same here.","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b42992f0efb0293663d2d89274a2a445413feef6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                         self.bareMetalNodeClient."},{"line_number":59,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":62,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":63,"context_line":"        expected \u003d []"},{"line_number":64,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_ae2308bc","line":61,"in_reply_to":"fa1b9901_717c01ec","updated":"2015-08-21 09:56:05.000000000","message":"Done","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"ead969a8c58945abff89e8fd61dd53ca6335d820","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_list_bareMetal_nodes_string(self):"},{"line_number":74,"context_line":"        self.test_list_bareMetal_nodes()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_list_bareMetal_nodes_bytes(self):"},{"line_number":77,"context_line":"        self.test_list_bareMetal_nodes(True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_3198c969","line":74,"updated":"2015-08-21 05:22:43.000000000","message":"Same here.\n\n self._test_list_bareMetal_nodes()","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b42992f0efb0293663d2d89274a2a445413feef6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         self.bareMetalNodeClient.list_baremetal_nodes())"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_list_bareMetal_nodes_string(self):"},{"line_number":74,"context_line":"        self.test_list_bareMetal_nodes()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_list_bareMetal_nodes_bytes(self):"},{"line_number":77,"context_line":"        self.test_list_bareMetal_nodes(True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_6e29709a","line":74,"in_reply_to":"fa1b9901_3198c969","updated":"2015-08-21 09:56:05.000000000","message":"Done","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"ead969a8c58945abff89e8fd61dd53ca6335d820","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_show_bareMetal_node_string(self):"},{"line_number":80,"context_line":"        self.test_show_bareMetal_node()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_list_bareMetal_node_bytes(self):"},{"line_number":83,"context_line":"        self.test_show_bareMetal_node(True)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b1e61942","line":82,"updated":"2015-08-21 05:22:43.000000000","message":"I think this \"list\" is just typo.","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b42992f0efb0293663d2d89274a2a445413feef6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_show_bareMetal_node_string(self):"},{"line_number":80,"context_line":"        self.test_show_bareMetal_node()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_list_bareMetal_node_bytes(self):"},{"line_number":83,"context_line":"        self.test_show_bareMetal_node(True)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_892e3e8a","line":82,"in_reply_to":"fa1b9901_b1e61942","updated":"2015-08-21 09:56:05.000000000","message":"Done","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5074bac6cc5d84c2ede2d2248677e6e625a27708","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def test_list_bareMetal_node_bytes(self):"},{"line_number":83,"context_line":"        self.test_show_bareMetal_node(True)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def tearDown(self):"},{"line_number":86,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_517a1a89","line":85,"updated":"2015-08-21 06:24:46.000000000","message":"from previous comment","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b42992f0efb0293663d2d89274a2a445413feef6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def test_list_bareMetal_node_bytes(self):"},{"line_number":83,"context_line":"        self.test_show_bareMetal_node(True)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def tearDown(self):"},{"line_number":86,"context_line":"        super(TestBareMetalNodesClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_49534617","line":85,"in_reply_to":"fa1b9901_517a1a89","updated":"2015-08-21 09:56:05.000000000","message":"Done","commit_id":"3ace7ad6e866828bfefbe6906b4d3c62c47df896"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"e93ee6cdfe2111d1ed9d51df879cfcdaa5608ebf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":32,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":35,"context_line":"        nodeInfo \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":36,"context_line":"                    \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":37,"context_line":"                    \u0027host\u0027: \u002710.0.2.15\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_ec946845","line":34,"updated":"2015-08-24 01:14:02.000000000","message":"It is better to use a single underscore .\nA name prefixed with an underscore should be treated as a non-public part of the API.\n\nPlease refer to:\n https://docs.python.org/3.4/tutorial/classes.html#private-variables","commit_id":"62238a608b359bab1c3389444d1fa5275d8f4049"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b0300f64158413a0e16aa7bf1c8a6946e7b15a24","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":32,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":35,"context_line":"        nodeInfo \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":36,"context_line":"                    \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":37,"context_line":"                    \u0027host\u0027: \u002710.0.2.15\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_2298276a","line":34,"in_reply_to":"fa1b9901_ec946845","updated":"2015-08-24 02:48:06.000000000","message":"Dear Yasui San,\nOne underscore is useful for non-public part of API\nTwo underscores are useful for private members.\n\nHowever, in both the cases there is no difference in the implementation.\nBoth the non-public and the private members do no allow direct access from the class object, and result in the same results.","commit_id":"62238a608b359bab1c3389444d1fa5275d8f4049"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd3761334636d23f4e232df999fed09dad67dd58","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":55,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":56,"context_line":"            return_value\u003dresponse))"},{"line_number":57,"context_line":"        self.assertEqual(nodeInfo,"},{"line_number":58,"context_line":"                         self.bareMetalNodeClient."},{"line_number":59,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027)[\u0027node\u0027])"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_50780dc4","line":57,"updated":"2015-08-26 07:24:07.000000000","message":"As https://review.openstack.org/#/c/208839/ is merged. not client will start returning the full response.\n\nnodeInfo -\u003e {\"node\": nodeInfo}","commit_id":"376e56e933c954c53c2a0c5a882ff48e7c48b67e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd3761334636d23f4e232df999fed09dad67dd58","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027)[\u0027node\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":62,"context_line":"        body \u003d \u0027{\"nodes\":[]}\u0027"},{"line_number":63,"context_line":"        expected \u003d []"},{"line_number":64,"context_line":"        if bodyBytes:"},{"line_number":65,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_50f9ed7e","line":62,"updated":"2015-08-26 07:24:07.000000000","message":"test with some list response.\n\nbody \u003d \u0027{\"nodes\":[]}\u0027  -\u003e  body \u003d json.dumps({\"nodes\":[nodeInfo]})","commit_id":"376e56e933c954c53c2a0c5a882ff48e7c48b67e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd3761334636d23f4e232df999fed09dad67dd58","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":68,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":69,"context_line":"            return_value\u003dresponse))"},{"line_number":70,"context_line":"        self.assertEqual(expected,"},{"line_number":71,"context_line":"                         self.bareMetalNodeClient."},{"line_number":72,"context_line":"                         list_baremetal_nodes()[\u0027nodes\u0027])"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_9040e560","line":70,"updated":"2015-08-26 07:24:07.000000000","message":"expected -\u003e {\"nodes\":[nodeInfo]}","commit_id":"376e56e933c954c53c2a0c5a882ff48e7c48b67e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f3db2cc1e27a2335513c2ce739854e4d80933125","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":68,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":69,"context_line":"            return_value\u003dresponse))"},{"line_number":70,"context_line":"        self.assertEqual(expected,"},{"line_number":71,"context_line":"                         self.bareMetalNodeClient."},{"line_number":72,"context_line":"                         list_baremetal_nodes()[\u0027nodes\u0027])"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_dcb676db","line":70,"in_reply_to":"fa1b9901_9040e560","updated":"2015-08-27 01:54:11.000000000","message":"The first and the third comment are based on the change made in #208839\nI will perform these changes and commit the same.","commit_id":"376e56e933c954c53c2a0c5a882ff48e7c48b67e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2943277e8ae8c3d7677b81fa5596c8272b33774b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":65,"context_line":"        nodeInfo \u003d (self.NODEINFO.copy())"},{"line_number":66,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":67,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":68,"context_line":"        body \u003d json.dumps(expected)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_84e7d53f","line":65,"updated":"2015-08-27 03:10:04.000000000","message":"this does shallow copy, please do copy.deepcopy() and import copy","commit_id":"307119cb697e9ec844fa28345d3758740bf08dab"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2b24d3b137f9874f1ffcd15d8933cb8d2490e022","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":65,"context_line":"        nodeInfo \u003d (self.NODEINFO.copy())"},{"line_number":66,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":67,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":68,"context_line":"        body \u003d json.dumps(expected)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_84f115d0","line":65,"in_reply_to":"da20952f_84e7d53f","updated":"2015-08-27 03:27:09.000000000","message":"Done","commit_id":"307119cb697e9ec844fa28345d3758740bf08dab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec86d86a5511e05b43656670ac289d6415b6f42a","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":65,"context_line":"        nodeInfo \u003d (self.NODEINFO.copy())"},{"line_number":66,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":67,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":68,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":69,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_a91af26c","line":66,"updated":"2015-08-27 02:32:33.000000000","message":"why to delete instance_uuid that can be present in list response. You can remove L65,66 and use expected \u003d {\"nodes\": [self.NODEINFO]}","commit_id":"307119cb697e9ec844fa28345d3758740bf08dab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2943277e8ae8c3d7677b81fa5596c8272b33774b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":65,"context_line":"        nodeInfo \u003d (self.NODEINFO.copy())"},{"line_number":66,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":67,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":68,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":69,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_44e9bd19","line":66,"in_reply_to":"da20952f_297262e6","updated":"2015-08-27 03:10:04.000000000","message":"Yes, you are right. as per schema list should not have that.","commit_id":"307119cb697e9ec844fa28345d3758740bf08dab"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8ebfc1269e65a8022de73bc99b18d9becb2d2042","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":65,"context_line":"        nodeInfo \u003d (self.NODEINFO.copy())"},{"line_number":66,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":67,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":68,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":69,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_297262e6","line":66,"in_reply_to":"da20952f_a91af26c","updated":"2015-08-27 03:00:34.000000000","message":"When I executed the Unit test cases, I found that instance_uuid is not required in listing of data, but it is required when showing the data.\nIs it a bug (???)","commit_id":"307119cb697e9ec844fa28345d3758740bf08dab"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fcd331c3a8a7bcf08b702d6e4814a4fe70806990","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":50,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":53,"context_line":"        nodeInfo \u003d {\"node\": self.NODEINFO}"},{"line_number":54,"context_line":"        body \u003d json.dumps(nodeInfo)"},{"line_number":55,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_1fdd02e0","line":52,"updated":"2015-08-28 10:20:21.000000000","message":"This should be named \u0027bytes_body\u0027. In the future we might want to change this, and it\u0027s better for search-and-replace purpose that the code is consistent.","commit_id":"5edb52f14295f35074ef3589c4d338a22b4503a6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"43d3fd98425a65401d70adca7cf090803061f27c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":50,"context_line":"                                     \u0027regionOne\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _test_show_bareMetal_node(self, bodyBytes\u003dFalse):"},{"line_number":53,"context_line":"        nodeInfo \u003d {\"node\": self.NODEINFO}"},{"line_number":54,"context_line":"        body \u003d json.dumps(nodeInfo)"},{"line_number":55,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_bd705ea5","line":52,"in_reply_to":"da20952f_1fdd02e0","updated":"2015-08-31 00:37:33.000000000","message":"Done","commit_id":"5edb52f14295f35074ef3589c4d338a22b4503a6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fcd331c3a8a7bcf08b702d6e4814a4fe70806990","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         self.bareMetalNodeClient."},{"line_number":63,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":66,"context_line":"        nodeInfo \u003d copy.deepcopy(self.NODEINFO)"},{"line_number":67,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":68,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_ffe12e9b","line":65,"updated":"2015-08-28 10:20:21.000000000","message":"same","commit_id":"5edb52f14295f35074ef3589c4d338a22b4503a6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"43d3fd98425a65401d70adca7cf090803061f27c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                         self.bareMetalNodeClient."},{"line_number":63,"context_line":"                         show_baremetal_node(\u0027Identifier\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _test_list_bareMetal_nodes(self, bodyBytes\u003dFalse):"},{"line_number":66,"context_line":"        nodeInfo \u003d copy.deepcopy(self.NODEINFO)"},{"line_number":67,"context_line":"        del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":68,"context_line":"        expected \u003d {\"nodes\": [nodeInfo]}"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_5d6a62b4","line":65,"in_reply_to":"da20952f_ffe12e9b","updated":"2015-08-31 00:37:33.000000000","message":"Done","commit_id":"5edb52f14295f35074ef3589c4d338a22b4503a6"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"8f3b096d68cdf5045368d6af65e9d5a25b9a4906","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestBareMetalNodesClient(base.BaseComputeServiceTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    NODEINFO \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":25,"context_line":"                \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":26,"context_line":"                \u0027host\u0027: \u002710.0.2.15\u0027,"},{"line_number":27,"context_line":"                \u0027id\u0027: \u0027Identifier\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_8774dbce","line":24,"updated":"2015-09-08 05:51:14.000000000","message":"FAKE_NODE_INFO would be better?  I\u0027m ok with both though","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02f26903e343d7edb8ddf158e9b80e0959a350cf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestBareMetalNodesClient(base.BaseComputeServiceTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    NODEINFO \u003d {\u0027cpus\u0027: \u00278\u0027,"},{"line_number":25,"context_line":"                \u0027disk_gb\u0027: \u002764\u0027,"},{"line_number":26,"context_line":"                \u0027host\u0027: \u002710.0.2.15\u0027,"},{"line_number":27,"context_line":"                \u0027id\u0027: \u0027Identifier\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_da386aa2","line":24,"in_reply_to":"da20952f_8774dbce","updated":"2015-09-08 06:11:51.000000000","message":"Done","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"8f3b096d68cdf5045368d6af65e9d5a25b9a4906","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(TestBareMetalNodesClient, self).setUp()"},{"line_number":42,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":43,"context_line":"        self.bareMetalNodeClient \u003d (baremetal_nodes_client."},{"line_number":44,"context_line":"                                    BaremetalNodesClient"},{"line_number":45,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":46,"context_line":"                                     \u0027regionOne\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_e732770f","line":43,"updated":"2015-09-08 05:51:14.000000000","message":"_ would be better for variable names for consistency. see below","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02f26903e343d7edb8ddf158e9b80e0959a350cf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(TestBareMetalNodesClient, self).setUp()"},{"line_number":42,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":43,"context_line":"        self.bareMetalNodeClient \u003d (baremetal_nodes_client."},{"line_number":44,"context_line":"                                    BaremetalNodesClient"},{"line_number":45,"context_line":"                                    (fake_auth, \u0027compute\u0027,"},{"line_number":46,"context_line":"                                     \u0027regionOne\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_fa3bee99","line":43,"in_reply_to":"da20952f_e732770f","updated":"2015-09-08 06:11:51.000000000","message":"Done, though it is not necessary as per my understanding.","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"8f3b096d68cdf5045368d6af65e9d5a25b9a4906","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            expected \u003d {\"node\": self.NODEINFO}"},{"line_number":51,"context_line":"            function \u003d self.bareMetalNodeClient.show_baremetal_node"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            nodeInfo \u003d copy.deepcopy(self.NODEINFO)"},{"line_number":54,"context_line":"            del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":55,"context_line":"            expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":56,"context_line":"            function \u003d self.bareMetalNodeClient.list_baremetal_nodes"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_e7bd9768","line":53,"updated":"2015-09-08 05:51:14.000000000","message":":nit: as per convention we are following _ for variable names https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02f26903e343d7edb8ddf158e9b80e0959a350cf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            expected \u003d {\"node\": self.NODEINFO}"},{"line_number":51,"context_line":"            function \u003d self.bareMetalNodeClient.show_baremetal_node"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            nodeInfo \u003d copy.deepcopy(self.NODEINFO)"},{"line_number":54,"context_line":"            del nodeInfo[\u0027instance_uuid\u0027]"},{"line_number":55,"context_line":"            expected \u003d {\"nodes\": [nodeInfo]}"},{"line_number":56,"context_line":"            function \u003d self.bareMetalNodeClient.list_baremetal_nodes"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_9a3e7289","line":53,"in_reply_to":"da20952f_e7bd9768","updated":"2015-09-08 06:11:51.000000000","message":"Done","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"8f3b096d68cdf5045368d6af65e9d5a25b9a4906","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.check_service_client_function("},{"line_number":59,"context_line":"            function,"},{"line_number":60,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":61,"context_line":"            expected, bytes_body, status\u003d200,"},{"line_number":62,"context_line":"            baremetal_node_id\u003d\u0027Identifier\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_list_bareMetal_nodes_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_87229bb7","line":61,"updated":"2015-09-08 05:51:14.000000000","message":":nit: status\u003d200 is by default value, no need to mention here","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02f26903e343d7edb8ddf158e9b80e0959a350cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.check_service_client_function("},{"line_number":59,"context_line":"            function,"},{"line_number":60,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":61,"context_line":"            expected, bytes_body, status\u003d200,"},{"line_number":62,"context_line":"            baremetal_node_id\u003d\u0027Identifier\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_list_bareMetal_nodes_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_bab496f0","line":61,"in_reply_to":"da20952f_87229bb7","updated":"2015-09-08 06:11:51.000000000","message":"Done","commit_id":"46848e2c36e97647dbdd95afc47ead97aa68ddd5"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"83cd5a2364fafefb3324efd932df26253abc6adb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self._test_bareMetal_nodes()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_list_bareMetal_nodes_with_bytes_body(self):"},{"line_number":68,"context_line":"        self._test_bareMetal_nodes(True)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_show_bareMetal_node_with_str_body(self):"},{"line_number":71,"context_line":"        self._test_bareMetal_nodes(\u0027show\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_78f5a680","line":68,"updated":"2015-09-08 07:29:13.000000000","message":"You need to specify the arg type like: \"bytes_body\u003dTrue\" here. Otherwise \"operation\" is set to True.","commit_id":"ced29ea213a39f5bdd07a29204d5dc63e33210f6"}]}