)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c868500c92648593674476c4f360f6ac6b506e6b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        servers \u003d \\"},{"line_number":97,"context_line":"            [s for s in body_servers[\u0027servers\u0027] if s[\u0027name\u0027].startswith(name)]"},{"line_number":98,"context_line":"    else:"},{"line_number":99,"context_line":"        body \u003d service_client.ResponseBody(body.response, body[\u0027server\u0027])"},{"line_number":100,"context_line":"        servers \u003d [body]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # The name of the method to associate a floating IP to as server is too"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_8b2c4b4b","line":99,"updated":"2015-09-11 10:05:34.000000000","message":"This patch looks good to me, but could you please explain the purpose of this line?\nIt looks like\n\n    servers \u003d [body[\u0027server\u0027]]\n\nwould work. Or maybe I am missing something?","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"b18fafdbe98e05deffcb79a9f8199746b0126946","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        servers \u003d \\"},{"line_number":97,"context_line":"            [s for s in body_servers[\u0027servers\u0027] if s[\u0027name\u0027].startswith(name)]"},{"line_number":98,"context_line":"    else:"},{"line_number":99,"context_line":"        body \u003d service_client.ResponseBody(body.response, body[\u0027server\u0027])"},{"line_number":100,"context_line":"        servers \u003d [body]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # The name of the method to associate a floating IP to as server is too"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_30316e0c","line":99,"in_reply_to":"ba15a1d1_0d49b78b","updated":"2015-09-14 06:41:34.000000000","message":"Ghanshyam, thanks for clarification :)","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"06b6fa49a7eda838bd27961d9e5453607323c527","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        servers \u003d \\"},{"line_number":97,"context_line":"            [s for s in body_servers[\u0027servers\u0027] if s[\u0027name\u0027].startswith(name)]"},{"line_number":98,"context_line":"    else:"},{"line_number":99,"context_line":"        body \u003d service_client.ResponseBody(body.response, body[\u0027server\u0027])"},{"line_number":100,"context_line":"        servers \u003d [body]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # The name of the method to associate a floating IP to as server is too"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_0d49b78b","line":99,"in_reply_to":"da20952f_8b2c4b4b","updated":"2015-09-14 05:38:11.000000000","message":"Actually just [body[\u0027server\u0027]] would not work. Some of its consumer needs response also to fetch header.\nexample - https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_instance_actions.py#L32","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"220fee2e12577c91bac6d774ccc8302577a81ba3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.validate_response(schema.list_addresses_by_network, resp, body)"},{"line_number":177,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def action(self, server_id, action_name,"},{"line_number":180,"context_line":"               schema\u003dschema.server_actions_common_schema,"},{"line_number":181,"context_line":"               **kwargs):"},{"line_number":182,"context_line":"        post_body \u003d json.dumps({action_name: kwargs})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3c10144e","line":179,"updated":"2015-08-28 09:46:17.000000000","message":"Could explain the change here ?\nWe used to validate_response only when a \u0027response_key\u0027 was set, and now we always validate_response, am I right ?","commit_id":"dd4cf5aa92114960921dd7f7bfd26ad346c5fc81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1139acc01134be2fc228f44912a958a9b8903331","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.validate_response(schema.list_addresses_by_network, resp, body)"},{"line_number":177,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def action(self, server_id, action_name,"},{"line_number":180,"context_line":"               schema\u003dschema.server_actions_common_schema,"},{"line_number":181,"context_line":"               **kwargs):"},{"line_number":182,"context_line":"        post_body \u003d json.dumps({action_name: kwargs})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9c32800f","line":179,"in_reply_to":"da20952f_3c10144e","updated":"2015-08-28 10:03:59.000000000","message":"Actually previously also we used to do validation for both case (L187, L190 on left side). So there is no change in validation behavior. \n\nWe need validation for all case irrespective of response key or body(at least for success status code).\nFor example -\ncreate backup response-\n{\n    \"createBackup\": {\n        \"name\": \"Backup 1\",\n        \"backup_type\": \"daily\",\n        \"rotation\": 1\n    }\n}","commit_id":"dd4cf5aa92114960921dd7f7bfd26ad346c5fc81"}]}