)]}'
{"tempest/tests/services/compute/test_volumes_extensions_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    FAKE_VOLUMES \u003d {\"volumes\": [FAKE_VOLUME]}"},{"line_number":45,"context_line":"    volume_id \u003d \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def setUp(self):"},{"line_number":48,"context_line":"        super(TestVolumesExtensionsClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_44c37989","line":45,"updated":"2015-08-26 01:36:00.000000000","message":"you can get this with FAKE_VOLUME[\u0027id\u0027]","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    FAKE_VOLUMES \u003d {\"volumes\": [FAKE_VOLUME]}"},{"line_number":45,"context_line":"    volume_id \u003d \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def setUp(self):"},{"line_number":48,"context_line":"        super(TestVolumesExtensionsClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_70cf5156","line":45,"in_reply_to":"fa1b9901_44c37989","updated":"2015-08-26 07:13:07.000000000","message":"Done","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.client \u003d volumes_extensions_client.VolumesExtensionsClient("},{"line_number":51,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _test_list_volumes(self, detail\u003dFalse, bytes_body\u003dFalse):"},{"line_number":54,"context_line":"        serialized_body \u003d json.dumps(self.FAKE_VOLUMES)"},{"line_number":55,"context_line":"        if bytes_body:"},{"line_number":56,"context_line":"            serialized_body \u003d serialized_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_24220553","line":53,"updated":"2015-08-26 01:36:00.000000000","message":"we can remove detail from here.","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.client \u003d volumes_extensions_client.VolumesExtensionsClient("},{"line_number":51,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _test_list_volumes(self, detail\u003dFalse, bytes_body\u003dFalse):"},{"line_number":54,"context_line":"        serialized_body \u003d json.dumps(self.FAKE_VOLUMES)"},{"line_number":55,"context_line":"        if bytes_body:"},{"line_number":56,"context_line":"            serialized_body \u003d serialized_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_50d24d01","line":53,"in_reply_to":"fa1b9901_24220553","updated":"2015-08-26 07:13:07.000000000","message":"Done","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":60,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":61,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":62,"context_line":"        resp \u003d self.client.list_volumes(detail\u003dTrue)"},{"line_number":63,"context_line":"        self.assertEqual(self.FAKE_VOLUMES, resp)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_volumes_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e4ee4dec","line":62,"updated":"2015-08-26 01:36:00.000000000","message":"ditto, lets go with default one","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":60,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":61,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":62,"context_line":"        resp \u003d self.client.list_volumes(detail\u003dTrue)"},{"line_number":63,"context_line":"        self.assertEqual(self.FAKE_VOLUMES, resp)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_volumes_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_90e305d8","line":62,"in_reply_to":"fa1b9901_e4ee4dec","updated":"2015-08-26 07:13:07.000000000","message":"Done","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self._test_list_volumes(bytes_body\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_list_volumes_detail(self):"},{"line_number":72,"context_line":"        self._test_list_volumes(detail\u003dTrue)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _test_show_volume(self, bytes_body\u003dFalse):"},{"line_number":75,"context_line":"        serialized_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_64231d59","line":72,"updated":"2015-08-26 01:36:00.000000000","message":"here response is same for both with or without detail, so we can remove this tests","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self._test_list_volumes(bytes_body\u003dTrue)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_list_volumes_detail(self):"},{"line_number":72,"context_line":"        self._test_list_volumes(detail\u003dTrue)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _test_show_volume(self, bytes_body\u003dFalse):"},{"line_number":75,"context_line":"        serialized_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f0e281d4","line":72,"in_reply_to":"fa1b9901_64231d59","updated":"2015-08-26 07:13:07.000000000","message":"Done","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self._test_show_volume(bytes_body\u003dTrue)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _test_create_volume(self, bytes_body\u003dFalse):"},{"line_number":93,"context_line":"        post_body \u003d self.FAKE_VOLUME.copy()"},{"line_number":94,"context_line":"        del post_body[\u0027id\u0027]"},{"line_number":95,"context_line":"        del post_body[\u0027createdAt\u0027]"},{"line_number":96,"context_line":"        resp_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c4a789bb","line":93,"updated":"2015-08-26 01:36:00.000000000","message":"dict.copy is shallow copy which do not copy values just ref. make deepcopy of that with post_body \u003d copy.deepcopy(self.FAKE_VOLUME) - import copy module","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self._test_show_volume(bytes_body\u003dTrue)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _test_create_volume(self, bytes_body\u003dFalse):"},{"line_number":93,"context_line":"        post_body \u003d self.FAKE_VOLUME.copy()"},{"line_number":94,"context_line":"        del post_body[\u0027id\u0027]"},{"line_number":95,"context_line":"        del post_body[\u0027createdAt\u0027]"},{"line_number":96,"context_line":"        resp_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_10c1352f","line":93,"in_reply_to":"fa1b9901_c4a789bb","updated":"2015-08-26 07:13:07.000000000","message":"Done","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        post_body \u003d self.FAKE_VOLUME.copy()"},{"line_number":94,"context_line":"        del post_body[\u0027id\u0027]"},{"line_number":95,"context_line":"        del post_body[\u0027createdAt\u0027]"},{"line_number":96,"context_line":"        resp_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"},{"line_number":97,"context_line":"        if bytes_body:"},{"line_number":98,"context_line":"            resp_body \u003d resp_body.encode(\u0027utf-8\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e49c0d6c","line":96,"updated":"2015-08-26 01:36:00.000000000","message":"self.FAKE_VOLUME - \u003e post_body","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bd6560061ae2e874055da6284d34f08a3ed489c3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        post_body \u003d self.FAKE_VOLUME.copy()"},{"line_number":94,"context_line":"        del post_body[\u0027id\u0027]"},{"line_number":95,"context_line":"        del post_body[\u0027createdAt\u0027]"},{"line_number":96,"context_line":"        resp_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"},{"line_number":97,"context_line":"        if bytes_body:"},{"line_number":98,"context_line":"            resp_body \u003d resp_body.encode(\u0027utf-8\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c110cd02","line":96,"in_reply_to":"fa1b9901_d0b65ddb","updated":"2015-08-26 08:24:21.000000000","message":"I see, actually as long as we mock the POST method it does not actually makes difference but m ok with that.","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        post_body \u003d self.FAKE_VOLUME.copy()"},{"line_number":94,"context_line":"        del post_body[\u0027id\u0027]"},{"line_number":95,"context_line":"        del post_body[\u0027createdAt\u0027]"},{"line_number":96,"context_line":"        resp_body \u003d json.dumps({\"volume\": self.FAKE_VOLUME})"},{"line_number":97,"context_line":"        if bytes_body:"},{"line_number":98,"context_line":"            resp_body \u003d resp_body.encode(\u0027utf-8\u0027)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d0b65ddb","line":96,"in_reply_to":"fa1b9901_e49c0d6c","updated":"2015-08-26 07:13:07.000000000","message":"post_body, I used to pass to the request on L104. Resp will be returned with id, so used FAKE_VOLUME as resp","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83a0ac397c80c245b739dc992d20a22c0b31012b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":103,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":104,"context_line":"        resp \u003d self.client.create_volume(post_body)"},{"line_number":105,"context_line":"        self.assertEqual({\u0027volume\u0027: self.FAKE_VOLUME}, resp)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create_volume_with_str_body(self):"},{"line_number":108,"context_line":"        self._test_create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c48ea92d","line":105,"updated":"2015-08-26 01:36:00.000000000","message":"ditto","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3bf53ce9adb1675c006e2bb457411b62f464032f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":103,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":104,"context_line":"        resp \u003d self.client.create_volume(post_body)"},{"line_number":105,"context_line":"        self.assertEqual({\u0027volume\u0027: self.FAKE_VOLUME}, resp)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create_volume_with_str_body(self):"},{"line_number":108,"context_line":"        self._test_create_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b0b169e2","line":105,"in_reply_to":"fa1b9901_c48ea92d","updated":"2015-08-26 07:13:07.000000000","message":"ditto","commit_id":"271051aeae60aa88df79c24b7835d8cfe7d0e9e2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a5e5e39f7b10c8c4a6327a8622f47e5147d7d2aa","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    FAKE_VOLUME \u003d {"},{"line_number":30,"context_line":"        \"id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\","},{"line_number":31,"context_line":"        \"displayName\": \"vol-001\","},{"line_number":32,"context_line":"        \"displayDescription\": \"Another volume.\","},{"line_number":33,"context_line":"        \"size\": 30,"},{"line_number":34,"context_line":"        \"status\": \"Active\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_8c7e4e17","line":31,"updated":"2015-09-07 14:53:57.000000000","message":"Could you add some unicode char in there ?:\n  \"displayName\": u\"v\\u12345ol-001\",","commit_id":"34984cc24c22cd4a35189f25c09ef0aaa7d458e9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a5e5e39f7b10c8c4a6327a8622f47e5147d7d2aa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    FAKE_VOLUME \u003d {"},{"line_number":30,"context_line":"        \"id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\","},{"line_number":31,"context_line":"        \"displayName\": \"vol-001\","},{"line_number":32,"context_line":"        \"displayDescription\": \"Another volume.\","},{"line_number":33,"context_line":"        \"size\": 30,"},{"line_number":34,"context_line":"        \"status\": \"Active\","},{"line_number":35,"context_line":"        \"volumeType\": \"289da7f8-6440-407c-9fb4-7db01ec49164\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_6c6f3a60","line":32,"updated":"2015-09-07 14:53:57.000000000","message":"same","commit_id":"34984cc24c22cd4a35189f25c09ef0aaa7d458e9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4fb2230e426ebc304ea0e3e03168d6104dc44cb8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":115,"context_line":"        resp \u003d self.client.delete_volume(self.FAKE_VOLUME[\u0027id\u0027])"},{"line_number":116,"context_line":"        self.assertEqual({}, resp)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_is_resource_deleted(self):"},{"line_number":119,"context_line":"        module \u003d (\u0027tempest.services.compute.json.volumes_extensions_client.\u0027"},{"line_number":120,"context_line":"                  \u0027VolumesExtensionsClient.show_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_276aaf81","line":117,"updated":"2015-09-08 05:16:20.000000000","message":"Dear Anusha San,\nCan you also check https://review.openstack.org/#/c/220152/ ?\nMarc Koderer has done some nice work in removing the duplicated information.\nMaybe it can help you as well?","commit_id":"34984cc24c22cd4a35189f25c09ef0aaa7d458e9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6642acef27dc6df94e69ae90dac9abfedc077e36","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \"snapshotId\": None,"},{"line_number":39,"context_line":"        \"attachments\": [],"},{"line_number":40,"context_line":"        \"createdAt\": \"2012-02-14T20:53:07Z\""},{"line_number":41,"context_line":"        }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    FAKE_VOLUMES \u003d {\"volumes\": [FAKE_VOLUME]}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_17dce6e2","line":41,"updated":"2015-09-11 08:35:08.000000000","message":"Strange.. this seems wrong indent but pep8 check cannot detect it.\n\nHere should be\n\n  FAKE_VOLUME \u003d {\n      [..]\n -    }\n +}","commit_id":"2a54284b087618d7643581635f14da55f0b128ea"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"60b26f23ff4e316f0245943376d5ea5ce61752e4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_list_volumes_with_str_body(self):"},{"line_number":58,"context_line":"        self._test_list_volumes()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_list_volumes_with_byte_body(self):"},{"line_number":61,"context_line":"        self._test_list_volumes(bytes_body\u003dTrue)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_list_volumes_with_params(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_f492f156","line":60,"updated":"2015-09-14 16:37:23.000000000","message":"it should have been \"test_list_volumes_with_bytes_body\"","commit_id":"825a5bfeaf914bdca6c00925caf45bb05dd34b00"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"60b26f23ff4e316f0245943376d5ea5ce61752e4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            self.client.create_volume,"},{"line_number":86,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":87,"context_line":"            {\"volume\": self.FAKE_VOLUME},"},{"line_number":88,"context_line":"            to_utf\u003dbytes_body, status\u003d200, **post_body)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_create_volume_with_str_body(self):"},{"line_number":91,"context_line":"        self._test_create_volume()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_94c85576","line":88,"updated":"2015-09-14 16:37:23.000000000","message":"status\u003d200 was not needed, it\u0027s the default value.","commit_id":"825a5bfeaf914bdca6c00925caf45bb05dd34b00"}]}