)]}'
{"tempest/api/volume/admin/test_volumes_list.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f85de7a1aa2d5d63a96e729d665b832dce7cf98","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # Create volume for a non-admin tenant"},{"line_number":27,"context_line":"        volume \u003d self.volumes_client.create_volume()"},{"line_number":28,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":29,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Create volume for admin tenant"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_588f0023","line":28,"updated":"2015-08-25 13:34:39.000000000","message":"You don\u0027t need to wait here. You don\u0027t actually use the volume later on.","commit_id":"3ffe40889f12bdb475c45380c7fc15e0fbe295a0"},{"author":{"_account_id":10300,"name":"Pranali Deore","email":"pranalideore@gmail.com","username":"PranaliDeore"},"change_message_id":"7f56cf9da577557c25cdedecec82902dfa2516a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # Create volume for a non-admin tenant"},{"line_number":27,"context_line":"        volume \u003d self.volumes_client.create_volume()"},{"line_number":28,"context_line":"        self.volumes_client.wait_for_volume_status(volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":29,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Create volume for admin tenant"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cac86b77","line":28,"in_reply_to":"fa1b9901_588f0023","updated":"2015-08-27 08:44:11.000000000","message":"IMO, wait is necessary here because during cleanup volume status should be \u0027available\u0027 otherwise it gives below error,\n\ntempest_lib.exceptions.BadRequest: Bad request Details: {u\u0027message\u0027: u\u0027Invalid volume: Volume status must be available or error, but current status is: creating.\u0027, u\u0027code\u0027: 400}","commit_id":"3ffe40889f12bdb475c45380c7fc15e0fbe295a0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f85de7a1aa2d5d63a96e729d665b832dce7cf98","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Create volume for admin tenant"},{"line_number":32,"context_line":"        admin_volume \u003d self.admin_volume_client.create_volume()"},{"line_number":33,"context_line":"        self.admin_volume_client.wait_for_volume_status(admin_volume[\u0027id\u0027],"},{"line_number":34,"context_line":"                                                        \u0027available\u0027)"},{"line_number":35,"context_line":"        self.addCleanup(self.admin_volume_client.delete_volume,"},{"line_number":36,"context_line":"                        admin_volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_1899886e","line":33,"updated":"2015-08-25 13:34:39.000000000","message":"Same","commit_id":"3ffe40889f12bdb475c45380c7fc15e0fbe295a0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f85de7a1aa2d5d63a96e729d665b832dce7cf98","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Fetch all volumes based on \u0027all_tenants\u0027 search filter"},{"line_number":39,"context_line":"        param \u003d {\u0027all_tenants\u0027: \u0027true\u0027}"},{"line_number":40,"context_line":"        fetched_vol_list \u003d self.admin_volume_client.list_volumes(params\u003dparam)"},{"line_number":41,"context_line":"        vol_list \u003d map(lambda vol: vol[\u0027id\u0027], fetched_vol_list)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Now check if all created volumes are present in fetched list"},{"line_number":44,"context_line":"        self.assertIn(admin_volume[\u0027id\u0027], vol_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b8a89c78","line":41,"range":{"start_line":40,"start_character":16,"end_line":41,"end_character":28},"updated":"2015-08-25 13:34:39.000000000","message":"Use a list comprehension.","commit_id":"3ffe40889f12bdb475c45380c7fc15e0fbe295a0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"148610effba9d5261b7f2efa05565ace5f94cb93","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class VolumesV2ListTest(base.BaseVolumeAdminTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.idempotent_id(\u002745945237-a865-4808-b284-7fbdd31a53d9\u0027)"},{"line_number":23,"context_line":"    def test_list_volumes_with_all_tenants_filter(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_55635bdd","line":20,"updated":"2015-09-10 13:34:32.000000000","message":"You should add some \"skip\" check here because we can have the case when Cinder is not available. Something like this\n\n    @classmethod\n    def skip_checks(cls):\n        super(VolumesV2ListTest, cls).skip_checks()\n        if not CONF.service_available.cinder:\n            skip_msg \u003d (\"%s skipped as Cinder is not available\" % cls.__name__)\n            raise cls.skipException(skip_msg)","commit_id":"4067dc9c6b7ed08b14b3f14d7500104e419d2fd4"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"05fa175bcdb467c60cbdc0631813da5c8cc981b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class VolumesV2ListTest(base.BaseVolumeAdminTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @test.idempotent_id(\u002745945237-a865-4808-b284-7fbdd31a53d9\u0027)"},{"line_number":23,"context_line":"    def test_list_volumes_with_all_tenants_filter(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_75af7f7d","line":20,"in_reply_to":"da20952f_55635bdd","updated":"2015-09-10 13:39:32.000000000","message":"Sorry, this check is present in the base class :)","commit_id":"4067dc9c6b7ed08b14b3f14d7500104e419d2fd4"}]}