)]}'
{"tempest/tests/services/compute/test_hosts_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cb86debdd84490fcecd5cc4e014d44a86f24191d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestHostsClient(base.TestCase):"},{"line_number":26,"context_line":"    FAKE_HOST_DATA \u003d {\"host\": {"},{"line_number":27,"context_line":"        \"resource\": {"},{"line_number":28,"context_line":"            \"cpu\": 1,"},{"line_number":29,"context_line":"            \"disk_gb\": 1028,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_21a58d03","line":26,"updated":"2015-08-27 09:39:06.000000000","message":"These 2 dict are badly indented. I suggest:\n\nFAKE_HOST_DATA \u003d {\n    \"host\": {\n        \"resource\": {\n            \"cpu\": 1,\n            \"disk_gb\": 1028,\n            \"host\": \"c1a7de0ac9d94e4baceae031d05caae3\",\n            \"memory_mb\": 8192,\n            \"project\": \"(total)\"\n        }\n    },\n    \"hosts\": {\n        \"host_name\": \"c1a7de0ac9d94e4baceae031d05caae3\",\n        \"service\": \"conductor\",\n        \"zone\": \"internal\"\n    },\n    \"enable_hosts\": {\n        \"host\": \"65c5d5b7e3bd44308e67fc50f362aee6\",\n        \"maintenance_mode\": \"off_maintenance\",\n        \"status\": \"enabled\"\n    }\n}\n\nFAKE_CONTROL_DATA \u003d {\n    \"shutdown\": {\n        \"host\": \"c1a7de0ac9d94e4baceae031d05caae3\",\n        \"power_action\": \"shutdown\"\n    },\n    \"startup\": {\n        \"host\": \"c1a7de0ac9d94e4baceae031d05caae3\",\n        \"power_action\": \"startup\"\n    },\n    \"reboot\": {\n        \"host\": \"c1a7de0ac9d94e4baceae031d05caae3\",\n        \"power_action\": \"reboot\"\n    }\n}","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5182f3bcb6d47917bc63ee26f06674a373623dd9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestHostsClient(base.TestCase):"},{"line_number":26,"context_line":"    FAKE_HOST_DATA \u003d {\"host\": {"},{"line_number":27,"context_line":"        \"resource\": {"},{"line_number":28,"context_line":"            \"cpu\": 1,"},{"line_number":29,"context_line":"            \"disk_gb\": 1028,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3b86ec65","line":26,"in_reply_to":"da20952f_21a58d03","updated":"2015-08-28 01:48:46.000000000","message":"This is a formatting comment. I will look into it .. \nThanks for the comment though","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"944a9195bd4eb327c6a5c9cc4af94e3d5eec10e0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestHostsClient(base.TestCase):"},{"line_number":26,"context_line":"    FAKE_HOST_DATA \u003d {\"host\": {"},{"line_number":27,"context_line":"        \"resource\": {"},{"line_number":28,"context_line":"            \"cpu\": 1,"},{"line_number":29,"context_line":"            \"disk_gb\": 1028,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d67ff914","line":26,"in_reply_to":"da20952f_3b86ec65","updated":"2015-09-07 14:03:06.000000000","message":"Yes this is formatting comment. But at the moment we can\"t see that we deal with nested dictionaries. Your dict looks \"flat\" but it isn\"t.","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"200c1fbe3800c38681daf955c9d6d54a4e7510a5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestHostsClient(base.TestCase):"},{"line_number":26,"context_line":"    FAKE_HOST_DATA \u003d {\"host\": {"},{"line_number":27,"context_line":"        \"resource\": {"},{"line_number":28,"context_line":"            \"cpu\": 1,"},{"line_number":29,"context_line":"            \"disk_gb\": 1028,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d39cd5c1","line":26,"in_reply_to":"da20952f_d67ff914","updated":"2015-09-08 07:48:03.000000000","message":"Done","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cb86debdd84490fcecd5cc4e014d44a86f24191d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            client_body \u003d json.dumps(self.HOSTS_DATA)"},{"line_number":81,"context_line":"            expected_resp \u003d self.HOSTS_DATA"},{"line_number":82,"context_line":"            function_call \u003d self.client.list_hosts"},{"line_number":83,"context_line":"            params \u003d {\u0027host_name\u0027: self.HOST_ID}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if bytes_body:"},{"line_number":86,"context_line":"            client_body \u003d client_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_613705b1","line":83,"updated":"2015-08-27 09:39:06.000000000","message":"You confirm it\u0027s host_name here with an underscore ?","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5182f3bcb6d47917bc63ee26f06674a373623dd9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            client_body \u003d json.dumps(self.HOSTS_DATA)"},{"line_number":81,"context_line":"            expected_resp \u003d self.HOSTS_DATA"},{"line_number":82,"context_line":"            function_call \u003d self.client.list_hosts"},{"line_number":83,"context_line":"            params \u003d {\u0027host_name\u0027: self.HOST_ID}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if bytes_body:"},{"line_number":86,"context_line":"            client_body \u003d client_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_dbf33009","line":83,"in_reply_to":"da20952f_613705b1","updated":"2015-08-28 01:48:46.000000000","message":"hosts\": [\n        {\n            \"host_name\": \"b6e4adbc193d428ea923899d07fb001e\",\n            \"service\": \"conductor\",\n            \"zone\": \"internal\"\n        }]\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html#listallhosts","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"200c1fbe3800c38681daf955c9d6d54a4e7510a5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            client_body \u003d json.dumps(self.HOSTS_DATA)"},{"line_number":81,"context_line":"            expected_resp \u003d self.HOSTS_DATA"},{"line_number":82,"context_line":"            function_call \u003d self.client.list_hosts"},{"line_number":83,"context_line":"            params \u003d {\u0027host_name\u0027: self.HOST_ID}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if bytes_body:"},{"line_number":86,"context_line":"            client_body \u003d client_body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_38eaced8","line":83,"in_reply_to":"da20952f_dbf33009","updated":"2015-09-08 07:48:03.000000000","message":"Done","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"dae7a302f828d17ccd0214f4d90d9ed845e7acb6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":91,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":92,"context_line":"        self.assertEqual(expected_resp,"},{"line_number":93,"context_line":"                         function_call(**params))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _test_update_hosts(self, bytes_body\u003dFalse):"},{"line_number":96,"context_line":"        client_body \u003d json.dumps(self.ENABLE_HOST_DATA)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_faa52eb4","line":93,"updated":"2015-09-08 06:09:43.000000000","message":"please refactor the code here based on https://review.openstack.org/#/c/220152/","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"200c1fbe3800c38681daf955c9d6d54a4e7510a5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":91,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":92,"context_line":"        self.assertEqual(expected_resp,"},{"line_number":93,"context_line":"                         function_call(**params))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _test_update_hosts(self, bytes_body\u003dFalse):"},{"line_number":96,"context_line":"        client_body \u003d json.dumps(self.ENABLE_HOST_DATA)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d8bb92e3","line":93,"in_reply_to":"da20952f_faa52eb4","updated":"2015-09-08 07:48:03.000000000","message":"Done","commit_id":"3866358d87c6c14371a5700446aa002421da60e7"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8fdf7e66d56e5390f90c1c9c976b871c7e7e7847","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self._test_host_data()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_list_host_with_bytes_body(self):"},{"line_number":123,"context_line":"        self._test_host_data(True)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_start_host_with_str_body(self):"},{"line_number":126,"context_line":"        self._test_control_host(\u0027start\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_f330f99f","line":123,"updated":"2015-09-08 07:55:42.000000000","message":"You need to set the arg type like \"bytes_body\u003dTrue\"","commit_id":"2c72faf877306ac4ed07609611539c08bb322de7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ad0b4df4ac4e8278fbd0b5703173720683bcb7e3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self._test_host_data()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_list_host_with_bytes_body(self):"},{"line_number":123,"context_line":"        self._test_host_data(True)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_start_host_with_str_body(self):"},{"line_number":126,"context_line":"        self._test_control_host(\u0027start\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_139d6d65","line":123,"in_reply_to":"da20952f_f330f99f","updated":"2015-09-08 08:00:24.000000000","message":"Done","commit_id":"2c72faf877306ac4ed07609611539c08bb322de7"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8fdf7e66d56e5390f90c1c9c976b871c7e7e7847","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._test_update_hosts()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_update_host_with_bytes_body(self):"},{"line_number":147,"context_line":"        self._test_update_hosts(True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9323bd57","line":147,"updated":"2015-09-08 07:55:42.000000000","message":"Same here","commit_id":"2c72faf877306ac4ed07609611539c08bb322de7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ad0b4df4ac4e8278fbd0b5703173720683bcb7e3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._test_update_hosts()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_update_host_with_bytes_body(self):"},{"line_number":147,"context_line":"        self._test_update_hosts(True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_7392a958","line":147,"in_reply_to":"da20952f_9323bd57","updated":"2015-09-08 08:00:24.000000000","message":"Not required, because test_update_hosts has 2 arguments, self and bytes_body","commit_id":"2c72faf877306ac4ed07609611539c08bb322de7"}]}