)]}'
{"tempest/tests/services/compute/test_migrations_client.py":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"5a2924c4aa6afa74f52ad19eede64772f44b19ec","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":54,"context_line":"            return_value\u003dresponse))"},{"line_number":55,"context_line":"        res \u003d self.migrationsClient.list_migrations()"},{"line_number":56,"context_line":"        self.assertEqual(self.MIGRATION_INFO, res)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list_migration_with_str_body(self):"},{"line_number":59,"context_line":"        self._test_list_migrations()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5b2bd730","line":56,"updated":"2015-08-27 06:44:11.000000000","message":"This behavior is dependent on https://review.openstack.org/#/c/216124/ , so its better to make it as a dependant patch on the 216124 review and update the code accordingly to avoid more rework","commit_id":"7c1b46df59bc302ab788a0449a2ef44231643ba6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7160bcb97e3b200af7223178ce8c930bf0075b47","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":54,"context_line":"            return_value\u003dresponse))"},{"line_number":55,"context_line":"        res \u003d self.migrationsClient.list_migrations()"},{"line_number":56,"context_line":"        self.assertEqual(self.MIGRATION_INFO, res[\"migrations\"])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list_migration_with_str_body(self):"},{"line_number":59,"context_line":"        self._test_list_migrations()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_5de4ef0b","line":56,"updated":"2015-08-28 05:54:14.000000000","message":"we should check complete resp here.\n\nexpected \u003d {\"migrations\": self.MIGRATION_INFO}\nL48 - body \u003d json.dumps(expected)\nL56 - self.assertEqual(expected , res)","commit_id":"97c2e475e3aad0023409c08150b5588b535a3a5a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6332f59bf37a8f140528b43b0967e4060000ce0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(TestMigrationsClient, self).setUp()"},{"line_number":43,"context_line":"        fake_auth \u003d fake_auth_provider.FakeAuthProvider()"},{"line_number":44,"context_line":"        self.migrationsClient \u003d migrations_client.MigrationsClient("},{"line_number":45,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _test_list_migrations(self, bodyBytes\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_7caf6c94","line":44,"updated":"2015-08-28 09:54:22.000000000","message":"I am sorry to nitpick, but we use underscore for instance variables as per pep8: https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables","commit_id":"683a1af1eb04c617b3420d21a46864e444e186fa"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6332f59bf37a8f140528b43b0967e4060000ce0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.migrationsClient \u003d migrations_client.MigrationsClient("},{"line_number":45,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _test_list_migrations(self, bodyBytes\u003dFalse):"},{"line_number":48,"context_line":"        expected \u003d {\"migrations\": self.MIGRATION_INFO}"},{"line_number":49,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":50,"context_line":"        if bodyBytes:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_9cb7e0d7","line":47,"updated":"2015-08-28 09:54:22.000000000","message":"Same here, rename to bytes_body (with an underscore)","commit_id":"683a1af1eb04c617b3420d21a46864e444e186fa"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e39fd88e36b791c53e535c70200c47f60c77abde","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"dest_host\": \"1.2.3.4\","},{"line_number":30,"context_line":"                       \"dest_node\": \"node2\","},{"line_number":31,"context_line":"                       \"id\": 1234,"},{"line_number":32,"context_line":"                       \"instance_uuid\": \"instance_id_123\","},{"line_number":33,"context_line":"                       \"new_instance_type_id\": 2,"},{"line_number":34,"context_line":"                       \"old_instance_type_id\": 1,"},{"line_number":35,"context_line":"                       \"source_compute\": \"compute1\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c23d2fde","line":32,"updated":"2015-08-31 00:18:13.000000000","message":"here should be UUID format string like\n\n \"instance_uuid\": \"e9e4fdd7-f956-44ff-bfeb-d654a96ab3a2\",\n\nThe commit message of a7a14f127ff6bab1cebf58d1cc74e62ee79d1e4c is useful for this API sample.","commit_id":"e9692b8211ced2f28b375c8fff654aad40951ccd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e39fd88e36b791c53e535c70200c47f60c77abde","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                       \"old_instance_type_id\": 1,"},{"line_number":35,"context_line":"                       \"source_compute\": \"compute1\","},{"line_number":36,"context_line":"                       \"source_node\": \"node1\","},{"line_number":37,"context_line":"                       \"status\": \"Done\","},{"line_number":38,"context_line":"                       \"updated_at\":"},{"line_number":39,"context_line":"                       \"2012-10-29T13:42:02\"}]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_422a7f91","line":37,"updated":"2015-08-31 00:18:13.000000000","message":"Here should be\n\n \"status\": \"finished\",\n\nfor fitting actual response.","commit_id":"e9692b8211ced2f28b375c8fff654aad40951ccd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e39fd88e36b791c53e535c70200c47f60c77abde","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \"source_compute\": \"compute1\","},{"line_number":36,"context_line":"                       \"source_node\": \"node1\","},{"line_number":37,"context_line":"                       \"status\": \"Done\","},{"line_number":38,"context_line":"                       \"updated_at\":"},{"line_number":39,"context_line":"                       \"2012-10-29T13:42:02\"}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e2195389","line":38,"updated":"2015-08-31 00:18:13.000000000","message":"it is not necessary a new line at the end of \"updated_at\":","commit_id":"e9692b8211ced2f28b375c8fff654aad40951ccd"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"cb54662a3014fe4dd149cf3b249b02211c27af87","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":55,"context_line":"            return_value\u003dresponse))"},{"line_number":56,"context_line":"        real \u003d self.mg_client_obj.list_migrations()"},{"line_number":57,"context_line":"        self.assertEqual(expected, real)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_list_migration_with_str_body(self):"},{"line_number":60,"context_line":"        self._test_list_migrations()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_48335462","line":57,"updated":"2015-09-07 06:47:35.000000000","message":"duplicate code with the other unit tests","commit_id":"65fd075ba9fe0ec3414d786fab25bbba31095f32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3aa7c5c1e52e65849acf76b6323e19ae026a64e9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _test_list_migrations(self, bytes_body\u003dFalse):"},{"line_number":42,"context_line":"        expected \u003d {\"migrations\": self.MIGRATION_INFO}"},{"line_number":43,"context_line":"        self.check_service_client_function("},{"line_number":44,"context_line":"            self.mg_client_obj.list_migrations,"},{"line_number":45,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_07bf6bd0","line":42,"updated":"2015-09-08 05:23:36.000000000","message":"Just 2 small comments.\nYou are not using MIGRATION_INFO dictionary anywhere , except here.\nSo , do you need to create a new \u0027expected\u0027 object?\nIf the MIGRATION_INFO dictionary is not going to be used anywhere else, then maybe you can create MIGRATION_INFO as:\nMIGRATION_INFO\u003d{\"migrations\":[{\t21\n\t\t\t        \"created_at\": \"2012-10-29T13:42:02\",\t22\n\t\t\t        \"dest_compute\": \"compute2\",\t23\n\t\t\t        \"dest_host\": \"1.2.3.4\",\t24\n\t\t\t        \"dest_node\": \"node2\",\t25\n\t\t\t        \"id\": 1234,\t26\n\t\t\t        \"instance_uuid\": \"e9e4fdd7-f956-44ff-bfeb-d654a96ab3a2\",\t27\n\t\t\t        \"new_instance_type_id\": 2,\t28\n\t\t\t        \"old_instance_type_id\": 1,\t29\n\t\t\t        \"source_compute\": \"compute1\",\t30\n\t\t\t        \"source_node\": \"node1\",\t31\n\t\t\t        \"status\": \"finished\",\t32\n\t\t\t        \"updated_at\": \"2012-10-29T13:42:02\"}]}\nThis would reduce an extra line of code\n\nAlso,  maybe you can rename it to FAKE_MIGRATION_INFO, to keep in line with other unit test nomenclatures?","commit_id":"f7eca5a8577951cab525aac07f1411b13176bf51"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"2e3e7cc7f7041a09f8b09a22db215b95381468ca","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self.mg_client_obj.list_migrations,"},{"line_number":44,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":45,"context_line":"            self.FAKE_MIGRATION_INFO,"},{"line_number":46,"context_line":"            bytes_body)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_list_migration_with_str_body(self):"},{"line_number":49,"context_line":"        self._test_list_migrations()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_1d533ce3","line":46,"updated":"2015-09-08 06:36:07.000000000","message":":nit: better to mention to_utf\u003dbytes_body","commit_id":"daca419af5f75443a09c6897e968c4af158412c1"}]}