)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ef52f8f88b831fc19e0d8a1fe43f6cf6cf602ce","unresolved":false,"context_lines":[{"line_number":18,"context_line":"To break this cyclic dependency we need to temporary disable backup"},{"line_number":19,"context_line":"import/export test in Tempest in order to merge the fix in Cinder and"},{"line_number":20,"context_line":"then we can merge the Tempest fix that reenables the test."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Id7ab6e174c1fe85772477f03059c4f457c5c8b17"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_1e3b08ed","line":21,"updated":"2015-08-27 09:23:26.000000000","message":"need to include\n\n Related-Bug: #1455043\n\nand the commit-id of the corresponding cinder side for checking the status of the patch.\n\nQA team needs to check the status of the corresponding project patch as the policy.\nTempest HACKING.rst contains like:\n\n 2. Bug fix on core project needing Tempest changes\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n When trying to land a bug fix which changes a tested API you\u0027ll have to use the\n following procedure::\n\n    - Propose change to the project, get a +2 on the change even with failing\n    - Propose skip on Tempest which will only be approved after the\n      corresponding change in the project has a +2 on change\n    - Land project change in master and all open stable branches (if required)\n    - Land changed test in Tempest\n\n Otherwise the bug fix won\u0027t be able to land in the project.","commit_id":"820d732450214c7f12eb290008722f9e6790c264"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b0180e9d7ff9a8bd76669b135f32b6c164145ad0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"To break this cyclic dependency we need to temporary disable backup"},{"line_number":19,"context_line":"import/export test in Tempest in order to merge the fix in Cinder and"},{"line_number":20,"context_line":"then we can merge the Tempest fix that reenables the test."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Id7ab6e174c1fe85772477f03059c4f457c5c8b17"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_b4731d4d","line":21,"in_reply_to":"da20952f_1e3b08ed","updated":"2015-08-27 09:49:07.000000000","message":"I\u0027ll include related bugs in the commit message, but in another Tempest patch I was told not to include bugs from other projects in the footer (that\u0027s why it\u0027s only mentioned in the body part).\n\nI\u0027ll include the corresponding project patch in the body (because if I include it in the footer I\u0027ll get a cyclic dependency and Zuul will go nuts).\n\nI am aware of backward compatible API changes, and explanation has been provided in Cinder Patch and LP bugs.  In this case it\u0027s simple, this API is broken and doesn\u0027t work as it should, basically imported backups are missing half the data so some drivers and incremental backups won\u0027t work, which according to API changes guideline allows changing API behavior.\n\nI\u0027m following that procedure, but bullet 1 is unrealistic, no core member will +2 a patch that\u0027s not passing Jenkins (I won\u0027t at least), but with this patch I\u0027ve gotten Cinder patch to pass Jenkins and now I can, hopefully, get +2s.\n\nMy understanding was that just because it cannot be merged doesn\u0027t mean it can\u0027t get reviewed and mistakes pointed out (like you just did) and hopefully get +2s, it just means that it will not get +1 to the Workflow until conditions are met, right?\n\nBy the way I already have patch with changed test submitted to Tempest that will fix the test for desired behavior.","commit_id":"820d732450214c7f12eb290008722f9e6790c264"}]}