)]}'
{"tempest/tests/services/compute/test_floating_ips_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dff03dc311ebd6df6aec5dd7a610fcf20b347aa4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _test_list_floating_ips(self, bytes_body\u003dFalse):"},{"line_number":35,"context_line":"        expected \u003d {\u0027floating_ips\u0027: []}"},{"line_number":36,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":37,"context_line":"        if bytes_body:"},{"line_number":38,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2cd787ee","line":35,"updated":"2015-09-03 08:45:24.000000000","message":"We should tests with some response instead of empty one","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"54752a068bb4fb7c25677cf445e8271a04a1064e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _test_list_floating_ips(self, bytes_body\u003dFalse):"},{"line_number":35,"context_line":"        expected \u003d {\u0027floating_ips\u0027: []}"},{"line_number":36,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":37,"context_line":"        if bytes_body:"},{"line_number":38,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b18be61d","line":35,"in_reply_to":"da20952f_2cd787ee","updated":"2015-09-03 14:12:37.000000000","message":"Done","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dff03dc311ebd6df6aec5dd7a610fcf20b347aa4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _test_show_floating_ip(self, bytes_body\u003dFalse):"},{"line_number":52,"context_line":"        expected \u003d {\"floating_ip\": {\"fixed_ip\": None,"},{"line_number":53,"context_line":"                                    \"id\": 1,"},{"line_number":54,"context_line":"                                    \"instance_id\": None,"},{"line_number":55,"context_line":"                                    \"ip\": \"10.10.10.1\","},{"line_number":56,"context_line":"                                    \"pool\": \"nova\"}}"},{"line_number":57,"context_line":"        body \u003d json.dumps(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2cc0e729","line":54,"updated":"2015-09-03 08:45:24.000000000","message":"how about having some UUID here","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"54752a068bb4fb7c25677cf445e8271a04a1064e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def _test_show_floating_ip(self, bytes_body\u003dFalse):"},{"line_number":52,"context_line":"        expected \u003d {\"floating_ip\": {\"fixed_ip\": None,"},{"line_number":53,"context_line":"                                    \"id\": 1,"},{"line_number":54,"context_line":"                                    \"instance_id\": None,"},{"line_number":55,"context_line":"                                    \"ip\": \"10.10.10.1\","},{"line_number":56,"context_line":"                                    \"pool\": \"nova\"}}"},{"line_number":57,"context_line":"        body \u003d json.dumps(expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_71854e05","line":54,"in_reply_to":"da20952f_2cc0e729","updated":"2015-09-03 14:12:37.000000000","message":"Done","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dff03dc311ebd6df6aec5dd7a610fcf20b347aa4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                    \"id\": 1,"},{"line_number":54,"context_line":"                                    \"instance_id\": None,"},{"line_number":55,"context_line":"                                    \"ip\": \"10.10.10.1\","},{"line_number":56,"context_line":"                                    \"pool\": \"nova\"}}"},{"line_number":57,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":58,"context_line":"        if bytes_body:"},{"line_number":59,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ece0afce","line":56,"updated":"2015-09-03 08:45:24.000000000","message":"We can define this up as class var and use in create, list tests also","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"54752a068bb4fb7c25677cf445e8271a04a1064e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                    \"id\": 1,"},{"line_number":54,"context_line":"                                    \"instance_id\": None,"},{"line_number":55,"context_line":"                                    \"ip\": \"10.10.10.1\","},{"line_number":56,"context_line":"                                    \"pool\": \"nova\"}}"},{"line_number":57,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":58,"context_line":"        if bytes_body:"},{"line_number":59,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_117df21b","line":56,"in_reply_to":"da20952f_ece0afce","updated":"2015-09-03 14:12:37.000000000","message":"Done","commit_id":"66188fae0c5a57a2404f09b98075794c95a37155"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"da2107380e86856d7dbdefd03cdfc6e4effe763a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":86,"context_line":"            \u0027tempest.common.service_client.ServiceClient.delete\u0027,"},{"line_number":87,"context_line":"            return_value\u003dresponse))"},{"line_number":88,"context_line":"        self.client.delete_floating_ip(\u0027fake-id\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_associate_floating_ip_to_server(self):"},{"line_number":91,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 202}), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_20bf90ab","line":88,"updated":"2015-09-10 08:22:33.000000000","message":"check_service_client_function() can be reused here also. with expected \u003d {} and status\u003d202","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"73abe4c380d3e754ff8c675ab806c418a30e93f7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":86,"context_line":"            \u0027tempest.common.service_client.ServiceClient.delete\u0027,"},{"line_number":87,"context_line":"            return_value\u003dresponse))"},{"line_number":88,"context_line":"        self.client.delete_floating_ip(\u0027fake-id\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_associate_floating_ip_to_server(self):"},{"line_number":91,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 202}), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_ebac0c8e","line":88,"in_reply_to":"da20952f_20bf90ab","updated":"2015-09-10 14:20:58.000000000","message":"Done","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"da2107380e86856d7dbdefd03cdfc6e4effe763a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            return_value\u003dresponse))"},{"line_number":95,"context_line":"        self.assertEqual("},{"line_number":96,"context_line":"            {}, self.client.associate_floating_ip_to_server("},{"line_number":97,"context_line":"                \u002710.10.10.1\u0027, \u0027fake-server\u0027))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_disassociate_floating_ip_from_server(self):"},{"line_number":100,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 202}), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_40d164fa","line":97,"updated":"2015-09-10 08:22:33.000000000","message":"ditto","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"73abe4c380d3e754ff8c675ab806c418a30e93f7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            return_value\u003dresponse))"},{"line_number":95,"context_line":"        self.assertEqual("},{"line_number":96,"context_line":"            {}, self.client.associate_floating_ip_to_server("},{"line_number":97,"context_line":"                \u002710.10.10.1\u0027, \u0027fake-server\u0027))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_disassociate_floating_ip_from_server(self):"},{"line_number":100,"context_line":"        response \u003d (httplib2.Response({\u0027status\u0027: 202}), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_0ba86076","line":97,"in_reply_to":"da20952f_40d164fa","updated":"2015-09-10 14:20:58.000000000","message":"Done","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"da2107380e86856d7dbdefd03cdfc6e4effe763a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            return_value\u003dresponse))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            {}, self.client.disassociate_floating_ip_from_server("},{"line_number":106,"context_line":"                \u002710.10.10.1\u0027, \u0027fake-server\u0027))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_is_resource_deleted(self):"},{"line_number":109,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e0067884","line":106,"updated":"2015-09-10 08:22:33.000000000","message":"ditto","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"73abe4c380d3e754ff8c675ab806c418a30e93f7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            return_value\u003dresponse))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            {}, self.client.disassociate_floating_ip_from_server("},{"line_number":106,"context_line":"                \u002710.10.10.1\u0027, \u0027fake-server\u0027))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_is_resource_deleted(self):"},{"line_number":109,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_cbb828ca","line":106,"in_reply_to":"da20952f_e0067884","updated":"2015-09-10 14:20:58.000000000","message":"Done","commit_id":"078d5e5cf6609fc5c8185782e28ca36a0b92e0b6"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"7c48bcf52c7d08239b118543ae7277c4e647e282","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            self.client.associate_floating_ip_to_server,"},{"line_number":91,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":92,"context_line":"            {}, status\u003d202, floating_ip\u003d\u002710.10.10.1\u0027,"},{"line_number":93,"context_line":"            server_id\u003d\u0027c782b7a9-33cd-45f0-b795-7f87f456408b\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_disassociate_floating_ip_from_server(self):"},{"line_number":96,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_5c27e462","line":93,"updated":"2015-09-11 07:24:47.000000000","message":":nit: may be you can declare a dict at the start like \n\nreq_body \u003d {\u0027floating_ip\u0027: \u0027\u0027, \u0027server_id\u0027:\u0027\u0027} \n\nand reuse the same everywhere using **req_body?","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"2347e7383a40a1b122c94e9258a15a6c621b0659","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            self.client.associate_floating_ip_to_server,"},{"line_number":91,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":92,"context_line":"            {}, status\u003d202, floating_ip\u003d\u002710.10.10.1\u0027,"},{"line_number":93,"context_line":"            server_id\u003d\u0027c782b7a9-33cd-45f0-b795-7f87f456408b\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_disassociate_floating_ip_from_server(self):"},{"line_number":96,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c4bbff73","line":93,"in_reply_to":"da20952f_5c27e462","updated":"2015-09-11 20:04:58.000000000","message":"I\u0027m thinking in this case the clarity of having the parameters spelled out (no need to look elsewhere to see what they are) outweighs the benefits of reuse.  If the proposed dict were reused 3+ times in the class or it had 3+ key-value pairs, I could see the benefit of doing as you suggest.","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"7c48bcf52c7d08239b118543ae7277c4e647e282","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            self.client.disassociate_floating_ip_from_server,"},{"line_number":98,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":99,"context_line":"            {}, status\u003d202, floating_ip\u003d\u002710.10.10.1\u0027,"},{"line_number":100,"context_line":"            server_id\u003d\u0027c782b7a9-33cd-45f0-b795-7f87f456408b\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_is_resource_deleted(self):"},{"line_number":103,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_5cb5a4ea","line":100,"updated":"2015-09-11 07:24:47.000000000","message":"ditto","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"2347e7383a40a1b122c94e9258a15a6c621b0659","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            self.client.disassociate_floating_ip_from_server,"},{"line_number":98,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":99,"context_line":"            {}, status\u003d202, floating_ip\u003d\u002710.10.10.1\u0027,"},{"line_number":100,"context_line":"            server_id\u003d\u0027c782b7a9-33cd-45f0-b795-7f87f456408b\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_is_resource_deleted(self):"},{"line_number":103,"context_line":"        self.useFixture(mockpatch.Patch("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_275bdd23","line":100,"in_reply_to":"da20952f_5cb5a4ea","updated":"2015-09-11 20:04:58.000000000","message":"See above comment","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"7c48bcf52c7d08239b118543ae7277c4e647e282","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":104,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":105,"context_line":"            side_effect\u003dlib_exc.NotFound()))"},{"line_number":106,"context_line":"        self.assertTrue(self.client.is_resource_deleted(\u0027fake-id\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_fc96f892","line":106,"updated":"2015-09-11 07:24:47.000000000","message":"False case is missed here, better to add test case when resource is not deleted","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"2347e7383a40a1b122c94e9258a15a6c621b0659","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":104,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":105,"context_line":"            side_effect\u003dlib_exc.NotFound()))"},{"line_number":106,"context_line":"        self.assertTrue(self.client.is_resource_deleted(\u0027fake-id\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e4c083e2","line":106,"in_reply_to":"da20952f_fc96f892","updated":"2015-09-11 20:04:58.000000000","message":"Done","commit_id":"a2625c83ed18537425ce6e7b1cee3c2ba87e3a85"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"431d8cf0fc154ff92dd0361292fa1b0e6bf7ce39","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest_lib import exceptions as lib_exc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslotest import mockpatch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.services.compute.json import floating_ips_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_5f094330","line":16,"updated":"2015-09-15 17:35:12.000000000","message":"A blank line is not necessary between lib_exc and mockpatch because both is 3rd party libs.","commit_id":"8dc0d9c058d3c8084306068ea74034eeb2ecd5aa"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"9da3747ee3c200353f6bf001be63b81d68ee1d0f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest_lib import exceptions as lib_exc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslotest import mockpatch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.services.compute.json import floating_ips_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_f0788491","line":16,"in_reply_to":"ba15a1d1_5f094330","updated":"2015-09-15 17:58:28.000000000","message":"Done","commit_id":"8dc0d9c058d3c8084306068ea74034eeb2ecd5aa"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd503e22ec9648998eeb0719818089e34d8320f4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestFloatingIpsClient(base.BaseComputeServiceTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    floating_ip \u003d {\"fixed_ip\": None,"},{"line_number":27,"context_line":"                   \"id\": 1,"},{"line_number":28,"context_line":"                   \"instance_id\": \"a1daa443-a6bb-463e-aea2-104b7d912eb8\","},{"line_number":29,"context_line":"                   \"ip\": \"10.10.10.1\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_2d8fdb24","line":26,"updated":"2015-09-14 04:57:11.000000000","message":"Can the floating_ip dictionary be renamed as FAKE_FLOATING_IP ?\nJust thinking of keeping the test case information in sync with the nomenclature.\nExcept that there is no specific comment.","commit_id":"8dc0d9c058d3c8084306068ea74034eeb2ecd5aa"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"431d8cf0fc154ff92dd0361292fa1b0e6bf7ce39","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestFloatingIpsClient(base.BaseComputeServiceTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    floating_ip \u003d {\"fixed_ip\": None,"},{"line_number":27,"context_line":"                   \"id\": 1,"},{"line_number":28,"context_line":"                   \"instance_id\": \"a1daa443-a6bb-463e-aea2-104b7d912eb8\","},{"line_number":29,"context_line":"                   \"ip\": \"10.10.10.1\","},{"line_number":30,"context_line":"                   \"pool\": \"nova\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_65e4b80c","line":27,"updated":"2015-09-15 17:35:12.000000000","message":"at line 59, the id of floating-ip is defined as uuid, but integer here.\n\nOn my env, the id is uuid like\n\n $ nova --debug floating-ip-create \n [..]\n RESP BODY: {\"floating_ip\": {\"instance_id\": null, \"ip\": \"172.24.4.17\", \"fixed_ip\": null, \"id\": \"46d61064-13ba-4bf0-9557-69de824c3d6f\", \"pool\": \"public\"}}\n [..]\n $\n\nSo here should be uuid for avoiding confusion like line 59.","commit_id":"8dc0d9c058d3c8084306068ea74034eeb2ecd5aa"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"9da3747ee3c200353f6bf001be63b81d68ee1d0f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class TestFloatingIpsClient(base.BaseComputeServiceTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    floating_ip \u003d {\"fixed_ip\": None,"},{"line_number":27,"context_line":"                   \"id\": 1,"},{"line_number":28,"context_line":"                   \"instance_id\": \"a1daa443-a6bb-463e-aea2-104b7d912eb8\","},{"line_number":29,"context_line":"                   \"ip\": \"10.10.10.1\","},{"line_number":30,"context_line":"                   \"pool\": \"nova\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_906fc8c4","line":27,"in_reply_to":"ba15a1d1_65e4b80c","updated":"2015-09-15 17:58:28.000000000","message":"Done","commit_id":"8dc0d9c058d3c8084306068ea74034eeb2ecd5aa"}]}