)]}'
{"tempest/tests/services/compute/test_flavors_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97cebbe747e31262d4972ba6f455fd0255c374b2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \"name\": \"m1.tiny\","},{"line_number":88,"context_line":"            \"ram\": 512,"},{"line_number":89,"context_line":"            \"swap\": 1,"},{"line_number":90,"context_line":"            \"vcpus\": 1}"},{"line_number":91,"context_line":"        expected \u003d {\"flavor\": flavor}"},{"line_number":92,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":93,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2c2eb0fa","line":90,"updated":"2015-09-03 03:10:12.000000000","message":"nit: better to put the last } at a new line for the readability.","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"af2b98a8f73f251e598cfdeff6ca73917d6cc17d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \"name\": \"m1.tiny\","},{"line_number":88,"context_line":"            \"ram\": 512,"},{"line_number":89,"context_line":"            \"swap\": 1,"},{"line_number":90,"context_line":"            \"vcpus\": 1}"},{"line_number":91,"context_line":"        expected \u003d {\"flavor\": flavor}"},{"line_number":92,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":93,"context_line":"        if bytes_body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ab15b39b","line":90,"in_reply_to":"da20952f_2c2eb0fa","updated":"2015-09-03 13:34:56.000000000","message":"Done","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97cebbe747e31262d4972ba6f455fd0255c374b2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":97,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":98,"context_line":"            return_value\u003dresponse))"},{"line_number":99,"context_line":"        self.assertEqual(expected, self.client.create_flavor(**flavor))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_create_flavor_str_body(self):"},{"line_number":102,"context_line":"        self._test_create_flavor(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ccfdb46f","line":99,"updated":"2015-09-03 03:10:12.000000000","message":"we cannot pass the parameter links when creating a flavor.\nso how about defining\n\n request \u003d {\n            \"disk\": 1,\n            \"id\": \"1\",\n            \"name\": \"m1.tiny\",\n            \"ram\": 512,\n            \"swap\": 1,\n            \"vcpus\": 1\n }\n\nand\n\n expected \u003d {\"flavor\": copy.deepcopy(request)}\n expected[\u0027flavor\u0027][\u0027links\u0027] \u003d [{\n    \"href\": \"http://openstack.example.com/v2/openstack/flavors/1\",\n    ...\n \n?","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"af2b98a8f73f251e598cfdeff6ca73917d6cc17d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":97,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":98,"context_line":"            return_value\u003dresponse))"},{"line_number":99,"context_line":"        self.assertEqual(expected, self.client.create_flavor(**flavor))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_create_flavor_str_body(self):"},{"line_number":102,"context_line":"        self._test_create_flavor(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cb4907d2","line":99,"in_reply_to":"da20952f_ccfdb46f","updated":"2015-09-03 13:34:56.000000000","message":"I addressed this a little differently, but it should get the job done.","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97cebbe747e31262d4972ba6f455fd0255c374b2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def _test_set_flavor_extra_spec(self, bytes_body\u003dFalse):"},{"line_number":131,"context_line":"        expected \u003d {\"extra_specs\": {"},{"line_number":132,"context_line":"            \"key1\": \"value1\","},{"line_number":133,"context_line":"            \"key2\": \"value2\"}}"},{"line_number":134,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":135,"context_line":"        if bytes_body:"},{"line_number":136,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ec37584b","line":133,"updated":"2015-09-03 03:10:12.000000000","message":"nit: better to put the last } at a new line for the readability.","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"af2b98a8f73f251e598cfdeff6ca73917d6cc17d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def _test_set_flavor_extra_spec(self, bytes_body\u003dFalse):"},{"line_number":131,"context_line":"        expected \u003d {\"extra_specs\": {"},{"line_number":132,"context_line":"            \"key1\": \"value1\","},{"line_number":133,"context_line":"            \"key2\": \"value2\"}}"},{"line_number":134,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":135,"context_line":"        if bytes_body:"},{"line_number":136,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b9f9c03","line":133,"in_reply_to":"da20952f_ec37584b","updated":"2015-09-03 13:34:56.000000000","message":"Done","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97cebbe747e31262d4972ba6f455fd0255c374b2","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        expected \u003d {"},{"line_number":231,"context_line":"            \"flavor_access\": [{"},{"line_number":232,"context_line":"                \"flavor_id\": \"10\","},{"line_number":233,"context_line":"                \"tenant_id\": \"fake_tenant\"}]}"},{"line_number":234,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":235,"context_line":"        if bytes_body:"},{"line_number":236,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ac3ac032","line":233,"updated":"2015-09-03 03:10:12.000000000","message":"nit: better to put the last } at a new line for the readability.","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"af2b98a8f73f251e598cfdeff6ca73917d6cc17d","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        expected \u003d {"},{"line_number":231,"context_line":"            \"flavor_access\": [{"},{"line_number":232,"context_line":"                \"flavor_id\": \"10\","},{"line_number":233,"context_line":"                \"tenant_id\": \"fake_tenant\"}]}"},{"line_number":234,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":235,"context_line":"        if bytes_body:"},{"line_number":236,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ebfc0c40","line":233,"in_reply_to":"da20952f_ac3ac032","updated":"2015-09-03 13:34:56.000000000","message":"Done","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97cebbe747e31262d4972ba6f455fd0255c374b2","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _test_remove_flavor_access(self, bytes_body\u003dFalse):"},{"line_number":251,"context_line":"        expected \u003d {"},{"line_number":252,"context_line":"            \"flavor_access\": []}"},{"line_number":253,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":254,"context_line":"        if bytes_body:"},{"line_number":255,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0c12ccb4","line":252,"updated":"2015-09-03 03:10:12.000000000","message":"nit: how about just\n\n expected \u003d {\"flavor_access\": []}\n\nlike line 213.","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"af2b98a8f73f251e598cfdeff6ca73917d6cc17d","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _test_remove_flavor_access(self, bytes_body\u003dFalse):"},{"line_number":251,"context_line":"        expected \u003d {"},{"line_number":252,"context_line":"            \"flavor_access\": []}"},{"line_number":253,"context_line":"        body \u003d json.dumps(expected)"},{"line_number":254,"context_line":"        if bytes_body:"},{"line_number":255,"context_line":"            body \u003d body.encode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b0c7c94","line":252,"in_reply_to":"da20952f_0c12ccb4","updated":"2015-09-03 13:34:56.000000000","message":"Done","commit_id":"019fcb862ca59e1f39bf95a8a3c97fe2ef7c138a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d66bb8d01c888ac020d46c31a84e4be5a0093e8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    flavor_access \u003d {"},{"line_number":48,"context_line":"        \"flavor_id\": \"10\","},{"line_number":49,"context_line":"        \"tenant_id\": \"1a951d98-8e26-4818-afe5-20e78697dcbf\""},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_486f22c4","line":49,"updated":"2015-09-11 03:25:54.000000000","message":"tenant-id is generated without hyphens.\nSo it will be nice to remove them for avoiding confusions.","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"45f1eb9acf906c7c2d0eb301c3c1327d8da789dc","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    flavor_access \u003d {"},{"line_number":48,"context_line":"        \"flavor_id\": \"10\","},{"line_number":49,"context_line":"        \"tenant_id\": \"1a951d98-8e26-4818-afe5-20e78697dcbf\""},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_f1be07d3","line":49,"in_reply_to":"da20952f_486f22c4","updated":"2015-09-11 19:05:30.000000000","message":"Done","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d66bb8d01c888ac020d46c31a84e4be5a0093e8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            expected,"},{"line_number":229,"context_line":"            bytes_body,"},{"line_number":230,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":231,"context_line":"            tenant_id\u003d\u00271a951d98-8e26-4818-afe5-20e78697dcbf\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def test_add_flavor_access_str_body(self):"},{"line_number":234,"context_line":"        self._test_add_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_286aeeb5","line":231,"updated":"2015-09-11 03:25:54.000000000","message":"ditto","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"45f1eb9acf906c7c2d0eb301c3c1327d8da789dc","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            expected,"},{"line_number":229,"context_line":"            bytes_body,"},{"line_number":230,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":231,"context_line":"            tenant_id\u003d\u00271a951d98-8e26-4818-afe5-20e78697dcbf\u0027)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def test_add_flavor_access_str_body(self):"},{"line_number":234,"context_line":"        self._test_add_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_91af8b9c","line":231,"in_reply_to":"da20952f_286aeeb5","updated":"2015-09-11 19:05:30.000000000","message":"Done","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d66bb8d01c888ac020d46c31a84e4be5a0093e8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            expected,"},{"line_number":247,"context_line":"            bytes_body,"},{"line_number":248,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":249,"context_line":"            tenant_id\u003d\u0027a6edd4d6-6ad0-4245-b5d2-d8716ecc91e3\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_remove_flavor_access_str_body(self):"},{"line_number":252,"context_line":"        self._test_remove_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_08660aed","line":249,"updated":"2015-09-11 03:25:54.000000000","message":"ditto","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"45f1eb9acf906c7c2d0eb301c3c1327d8da789dc","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            expected,"},{"line_number":247,"context_line":"            bytes_body,"},{"line_number":248,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":249,"context_line":"            tenant_id\u003d\u0027a6edd4d6-6ad0-4245-b5d2-d8716ecc91e3\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_remove_flavor_access_str_body(self):"},{"line_number":252,"context_line":"        self._test_remove_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b1b40ff1","line":249,"in_reply_to":"da20952f_08660aed","updated":"2015-09-11 19:05:30.000000000","message":"Done","commit_id":"0af3634da58a8cd3b7d2cbec890b74dad7b8af1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3075ad855cfe86481e087a964a51b671757290c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestFlavorsClient(base.BaseComputeServiceTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    flavor \u003d {"},{"line_number":29,"context_line":"        \"disk\": 1,"},{"line_number":30,"context_line":"        \"id\": \"1\","},{"line_number":31,"context_line":"        \"links\": [{"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_cdc73f44","line":28,"updated":"2015-09-14 05:15:56.000000000","message":"can this be changed to FAKE_FLAVOR_DATA?","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"3eaabe30043ad6b94ccc08f3feec66dccd5aaf43","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestFlavorsClient(base.BaseComputeServiceTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    flavor \u003d {"},{"line_number":29,"context_line":"        \"disk\": 1,"},{"line_number":30,"context_line":"        \"id\": \"1\","},{"line_number":31,"context_line":"        \"links\": [{"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_8deb2a78","line":28,"in_reply_to":"ba15a1d1_cdc73f44","updated":"2015-09-22 17:02:44.000000000","message":"Done","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3075ad855cfe86481e087a964a51b671757290c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"vcpus\": 1"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    extra_specs \u003d {\"extra_specs\": {"},{"line_number":43,"context_line":"        \"key1\": \"value1\","},{"line_number":44,"context_line":"        \"key2\": \"value2\"}"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_6dc4f33f","line":42,"updated":"2015-09-14 05:15:56.000000000","message":"As above, can this be changed to FAKE_EXTRA_SPECS?","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"3eaabe30043ad6b94ccc08f3feec66dccd5aaf43","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"vcpus\": 1"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    extra_specs \u003d {\"extra_specs\": {"},{"line_number":43,"context_line":"        \"key1\": \"value1\","},{"line_number":44,"context_line":"        \"key2\": \"value2\"}"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_8da24a4a","line":42,"in_reply_to":"ba15a1d1_6dc4f33f","updated":"2015-09-22 17:02:44.000000000","message":"I left off the \"FAKE\" because these are values that could legitimately be passed in.","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"27c539bd3fadd5cb74bda75269c46376d452af61","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            expected,"},{"line_number":190,"context_line":"            bytes_body,"},{"line_number":191,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":192,"context_line":"            key\u003d\u0027key\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_update_flavor_extra_spec_str_body(self):"},{"line_number":195,"context_line":"        self._test_update_flavor_extra_spec(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_f454ea21","line":192,"updated":"2015-09-16 06:31:52.000000000","message":"Need to pass req body also  - {\"key\": \"value\"}","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"3eaabe30043ad6b94ccc08f3feec66dccd5aaf43","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            expected,"},{"line_number":190,"context_line":"            bytes_body,"},{"line_number":191,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":192,"context_line":"            key\u003d\u0027key\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_update_flavor_extra_spec_str_body(self):"},{"line_number":195,"context_line":"        self._test_update_flavor_extra_spec(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_adbcee6c","line":192,"in_reply_to":"ba15a1d1_f454ea21","updated":"2015-09-22 17:02:44.000000000","message":"Done","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"27c539bd3fadd5cb74bda75269c46376d452af61","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            expected,"},{"line_number":247,"context_line":"            bytes_body,"},{"line_number":248,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":249,"context_line":"            tenant_id\u003d\u0027a6edd4d66ad04245b5d2d8716ecc91e3\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_remove_flavor_access_str_body(self):"},{"line_number":252,"context_line":"        self._test_remove_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_f4f86a4b","line":249,"updated":"2015-09-16 06:31:52.000000000","message":"tenant id should be same as in TestFlavorsClient.flavor_access means 1a951d988e264818afe520e78697dcbf","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29b0e102beba48be0234e1243df8ad09c1849655","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            expected,"},{"line_number":247,"context_line":"            bytes_body,"},{"line_number":248,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":249,"context_line":"            tenant_id\u003d\u0027a6edd4d66ad04245b5d2d8716ecc91e3\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_remove_flavor_access_str_body(self):"},{"line_number":252,"context_line":"        self._test_remove_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_2c8e522e","line":249,"in_reply_to":"ba15a1d1_4d08b22d","updated":"2015-09-24 07:56:05.000000000","message":"Yea, that is true.","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"3eaabe30043ad6b94ccc08f3feec66dccd5aaf43","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            expected,"},{"line_number":247,"context_line":"            bytes_body,"},{"line_number":248,"context_line":"            flavor_id\u003d\u00278c7aae5a-d315-4216-875b-ed9b6a5bcfc6\u0027,"},{"line_number":249,"context_line":"            tenant_id\u003d\u0027a6edd4d66ad04245b5d2d8716ecc91e3\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_remove_flavor_access_str_body(self):"},{"line_number":252,"context_line":"        self._test_remove_flavor_access(bytes_body\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_4d08b22d","line":249,"in_reply_to":"ba15a1d1_f4f86a4b","updated":"2015-09-22 17:02:44.000000000","message":"I respectfully disagree.  With these types of requests, the server returns the remaining flavor accesses.  The scenario is that the flavor has two accesses and a request comes in to remove one of them.  The response contains the remaining flavor access that was not removed.  The flavor ID was incorrect, however, so I changed that to match what is in the the class variable.","commit_id":"2acdfd4e9674fd2b5f8fe47eabe9faf1a1489dd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"db5de33ebfbf58be61b7af5acd53d5b2d34d87ce","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from tempest.services.compute.json import flavors_client"},{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":"from tempest.tests.services.compute import base as base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestFlavorsClient(base.BaseComputeServiceTest):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_4c9066ed","line":23,"updated":"2015-09-24 08:12:46.000000000","message":"This \"as base\" seems unnecessary","commit_id":"f128a231928066adb332df36b5ca88ed03f0639f"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"65ea522426d478e874ca2ea1a6f1f60954a05dd8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from tempest.services.compute.json import flavors_client"},{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":"from tempest.tests.services.compute import base as base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestFlavorsClient(base.BaseComputeServiceTest):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_ba284687","line":23,"in_reply_to":"ba15a1d1_4c9066ed","updated":"2015-09-24 13:24:57.000000000","message":"Done","commit_id":"f128a231928066adb332df36b5ca88ed03f0639f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2761f98e4081c730246c3299520a273c3ebbd9c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self._test_show_flavor_extra_spec(bytes_body\u003dTrue)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _test_update_flavor_extra_spec(self, bytes_body\u003dFalse):"},{"line_number":185,"context_line":"        expected \u003d {\"key1\": \"value\"}"},{"line_number":186,"context_line":"        self.check_service_client_function("},{"line_number":187,"context_line":"            self.client.update_flavor_extra_spec,"},{"line_number":188,"context_line":"            \u0027tempest.common.service_client.ServiceClient.put\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_6c99aa78","line":185,"updated":"2015-09-24 07:56:25.000000000","message":"You should keep this \u0027key\u0027 as passed in arg L192.  In actual it returns 400 if both are diff","commit_id":"f128a231928066adb332df36b5ca88ed03f0639f"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"65ea522426d478e874ca2ea1a6f1f60954a05dd8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self._test_show_flavor_extra_spec(bytes_body\u003dTrue)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _test_update_flavor_extra_spec(self, bytes_body\u003dFalse):"},{"line_number":185,"context_line":"        expected \u003d {\"key1\": \"value\"}"},{"line_number":186,"context_line":"        self.check_service_client_function("},{"line_number":187,"context_line":"            self.client.update_flavor_extra_spec,"},{"line_number":188,"context_line":"            \u0027tempest.common.service_client.ServiceClient.put\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_5af7aad2","line":185,"in_reply_to":"ba15a1d1_6c99aa78","updated":"2015-09-24 13:24:57.000000000","message":"I had it as \"key\" originally which caused an error because of the \u0027key\u0027 keyword argument having multiple values (equivalent of (...key\u003d\u0027key\u0027, key\u003d\u0027value\u0027)), so I\u0027m keeping it as \"key1\" and changing the value of the \"key\" keyword argument to \"key1\" to match.  That should be the key to addressing your concern.","commit_id":"f128a231928066adb332df36b5ca88ed03f0639f"}]}