)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"424da147f908fa9bc8f02234b30687070d36f774","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                                    for s in security_groups])"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"                    sec_groups_names \u003d [s[\u0027name\u0027] for s in create_kwargs.pop("},{"line_number":1091,"context_line":"                        \u0027security_groups\u0027)]"},{"line_number":1092,"context_line":"                    security_groups_ids \u003d [sec_dict[s]"},{"line_number":1093,"context_line":"                                           for s in sec_groups_names]"},{"line_number":1094,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_8398191d","line":1091,"updated":"2015-09-09 07:59:05.000000000","message":"I think it should be just get not pop. We need sec grps on create_kwargs if it is passed","commit_id":"5f15eabb8eea9bff986f4c7fd42451895c4ede96"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d11e7344b7d51710926987f37a8db2b89b95b28","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                                    for s in security_groups])"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"                    sec_groups_names \u003d [s[\u0027name\u0027] for s in create_kwargs.pop("},{"line_number":1091,"context_line":"                        \u0027security_groups\u0027)]"},{"line_number":1092,"context_line":"                    security_groups_ids \u003d [sec_dict[s]"},{"line_number":1093,"context_line":"                                           for s in sec_groups_names]"},{"line_number":1094,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_7c5bf587","line":1091,"in_reply_to":"da20952f_8398191d","updated":"2015-09-15 16:47:31.000000000","message":"oops, nice catch.","commit_id":"5f15eabb8eea9bff986f4c7fd42451895c4ede96"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"424da147f908fa9bc8f02234b30687070d36f774","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                    if security_groups_ids:"},{"line_number":1096,"context_line":"                        create_port_body["},{"line_number":1097,"context_line":"                            \u0027security_groups\u0027] \u003d security_groups_ids"},{"line_number":1098,"context_line":"                networks \u003d create_kwargs.pop(\u0027networks\u0027)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"            # If there are no networks passed to us we look up"},{"line_number":1101,"context_line":"            # for the tenant\u0027s private networks and create a port"}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_a3919df3","line":1098,"updated":"2015-09-09 07:59:05.000000000","message":"This too if ports are not created then passed networks should be present in create_kwargs like UUID etc","commit_id":"5f15eabb8eea9bff986f4c7fd42451895c4ede96"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d11e7344b7d51710926987f37a8db2b89b95b28","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                    if security_groups_ids:"},{"line_number":1096,"context_line":"                        create_port_body["},{"line_number":1097,"context_line":"                            \u0027security_groups\u0027] \u003d security_groups_ids"},{"line_number":1098,"context_line":"                networks \u003d create_kwargs.pop(\u0027networks\u0027)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"            # If there are no networks passed to us we look up"},{"line_number":1101,"context_line":"            # for the tenant\u0027s private networks and create a port"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_9ca3694f","line":1098,"in_reply_to":"da20952f_a3919df3","updated":"2015-09-15 16:47:31.000000000","message":"Thanks, done","commit_id":"5f15eabb8eea9bff986f4c7fd42451895c4ede96"}]}