)]}'
{"id":"openstack%2Ftempest~21752","triplet_id":"openstack%2Ftempest~master~I5fedf2fc2de5724614ade9cb5af14dd75e684205","project":"openstack/tempest","branch":"master","topic":"variable-miss","hashtags":[],"change_id":"I5fedf2fc2de5724614ade9cb5af14dd75e684205","subject":"Fixes around variable usage","status":"MERGED","created":"2013-02-12 09:58:56.000000000","updated":"2013-02-14 02:29:07.000000000","submitted":"2013-02-14 02:29:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3e0d8d8630d53b5276ae32c3b8fe7ef9d3f6e217","_number":21752,"virtual_id_number":21752,"owner":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":2,"date":"2013-02-14 02:29:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"recommended":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"all":[{"value":1,"date":"2013-02-12 22:11:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":2,"date":"2013-02-13 21:02:28.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2013-02-12 13:30:38.000000000","_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"date":"2013-02-12 11:43:42.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":1,"date":"2013-02-13 21:02:28.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"date":"2013-02-12 13:30:38.000000000","_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"date":"2013-02-12 11:43:42.000000000","_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Release Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-12 13:30:38.000000000","updated_by":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"reviewer":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"state":"REVIEWER"},{"updated":"2013-02-12 22:11:06.000000000","updated_by":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"reviewer":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"state":"REVIEWER"},{"updated":"2013-02-13 21:02:28.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2013-02-14 02:29:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"992e494b6ba78172051357440127188eca1b5f28","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-02-12 10:28:04.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d2e90e79f8f5ffd5f3995810151150a664f1b1f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 11:12:48.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21752/1/check/gate-tempest-pep8/2035 : SUCCESS\n- http://logs.openstack.org/21752/1/check/gate-tempest-devstack-vm-full/2206 : FAILURE\n- http://logs.openstack.org/21752/1/check/gate-tempest-devstack-vm-postgres-full/1932 : FAILURE\n- http://logs.openstack.org/21752/1/check/gate-tempest-devstack-vm-quantum/6363 : SUCCESS\n- http://logs.openstack.org/21752/1/check/gate-tempest-devstack-vm-quantum-full/293 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"c4cfa11cb01acd0fcf3fb6156884519be05d843d","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-02-12 11:32:22.000000000","message":"Patch Set 1:\n\nLooks like it is different type of issue. I remove it from this change set.","accounts_in_message":[],"_revision_number":1},{"id":"6b619ed2e2d2b64f9d3620d186d4945deb800042","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-02-12 11:37:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"09df4b6df5ce746eb137bf85fc99f8b12b602402","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-02-12 11:43:42.000000000","message":"Patch Set 2:\n\nAn Error response with 200 status code ???? Looks like a BUG.","accounts_in_message":[],"_revision_number":2},{"id":"979b5df2adfa8235b40104520645bb66613fe8d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 12:27:35.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21752/2/check/gate-tempest-pep8/2038 : SUCCESS\n- http://logs.openstack.org/21752/2/check/gate-tempest-devstack-vm-full/2220 : SUCCESS\n- http://logs.openstack.org/21752/2/check/gate-tempest-devstack-vm-postgres-full/1946 : SUCCESS\n- http://logs.openstack.org/21752/2/check/gate-tempest-devstack-vm-quantum/6379 : SUCCESS\n- http://logs.openstack.org/21752/2/check/gate-tempest-devstack-vm-quantum-full/296 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"1774c12726e7d08457f32a5c8c4230947a520b89","author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"date":"2013-02-12 13:30:38.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f1979f2317861abd50a198cb505e653bd7a5826c","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2013-02-12 15:52:42.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fd49d10a2a9c98208dd88de7d675b8e22f5169fe","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-02-12 22:11:06.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ac794e328d5539dacae6b6a79105a5c507203a91","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2013-02-13 21:02:28.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ea37e85a7c5f4254ee2a824e3a85a9b366861bfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 21:02:29.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e0a07d9a9628201c0fb77138e244b2828c253d71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 02:29:07.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21752/2/gate/gate-tempest-pep8/2073 : SUCCESS\n- http://logs.openstack.org/21752/2/gate/gate-tempest-devstack-vm-full/2680 : SUCCESS\n- http://logs.openstack.org/21752/2/gate/gate-tempest-devstack-vm-postgres-full/2406 : SUCCESS\n- http://logs.openstack.org/21752/2/gate/gate-tempest-devstack-vm-quantum/6905 : SUCCESS\n- http://logs.openstack.org/21752/2/gate/gate-tempest-devstack-vm-quantum-full/329 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"57146e7c70af0e7a96ce2cac941f8f9b4dd31257","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 02:29:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fa756cbef65830235b0768a05273446d8b759a01","revisions":{"a3c407e3257fcc253491cd5146e794a362227910":{"kind":"REWORK","_number":1,"created":"2013-02-12 09:58:56.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/52/21752/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/52/21752/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/52/21752/1"}}},"commit":{"parents":[{"commit":"6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a","subject":"Merge \"Change quota tests to use assertEqual\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-02-12 09:52:42.000000000","tz":60},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-02-12 09:58:29.000000000","tz":60},"subject":"Fixes around variable usage","message":"Fixes around variable usage\n\nservers_client: used post request instead of get for get all tenants\nobject_client: missing self before a method\nsnapshots_client: method redeclaration\ntestboto: wrong variable name\ntest_ec2_instance_run: missing cls\ntest_ec2_network.py: missing self\ntest_server_metadata.py: meta dict was not in use\ntest_authorization.py: unused variables\ntest_live_block_migration: tricky error handling\nbase: unused variables\ntest_network_basic_ops: unused variables\n\nChange-Id: I5fedf2fc2de5724614ade9cb5af14dd75e684205\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/a3c407e3257fcc253491cd5146e794a362227910"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/a3c407e3257fcc253491cd5146e794a362227910"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"fa756cbef65830235b0768a05273446d8b759a01":{"kind":"REWORK","_number":2,"created":"2013-02-12 11:37:52.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/52/21752/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tempest","ref":"refs/changes/52/21752/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tempest refs/changes/52/21752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tempest refs/changes/52/21752/2"}}},"commit":{"parents":[{"commit":"6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a","subject":"Merge \"Change quota tests to use assertEqual\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-02-12 09:52:42.000000000","tz":60},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-02-12 11:37:09.000000000","tz":60},"subject":"Fixes around variable usage","message":"Fixes around variable usage\n\nservers_client: used post request instead of get for get all tenants\nobject_client: missing self before a method\nsnapshots_client: method redeclaration\ntestboto: wrong variable name\ntest_ec2_instance_run: missing cls\ntest_ec2_network.py: missing self\ntest_server_metadata.py: meta dict was not in use\ntest_authorization.py: unused variables\ntest_live_block_migration: tricky error handling\nbase: unused variables\ntest_network_basic_ops: unused variables\n\nChange-Id: I5fedf2fc2de5724614ade9cb5af14dd75e684205\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/fa756cbef65830235b0768a05273446d8b759a01"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tempest/commit/fa756cbef65830235b0768a05273446d8b759a01"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6d83ac1e8fcf4f080016f2baff99b31fa7bbbd6a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
