)]}'
{"tempest/tests/services/compute/test_security_group_default_rules_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"62ff1b902e160a9a5614688accf527d22d63d58b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":89,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":90,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":91,"context_line":"        resp \u003d self.client.create_security_default_group_rule(**self.FAKE_RULE)"},{"line_number":92,"context_line":"        self.assertEqual(expected, resp)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_security_group_default_rule_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_7c4a9156","line":91,"updated":"2015-09-01 03:13:38.000000000","message":"This self.FAKE_RULE should not be used as a request body because the cidr position is wrong.\n\nNova gets cidr parameter value like the following:\n\n./nova/api/openstack/compute/security_group_default_rules.py\n 41         sg_rule \u003d self._from_body(body, \u0027security_group_default_rule\u0027)\n 42\n 43         try:\n 44             values \u003d self._rule_args_to_dict(to_port\u003dsg_rule.get(\u0027to_port\u0027),\n 45                 from_port\u003dsg_rule.get(\u0027from_port\u0027),\n 46                 ip_protocol\u003dsg_rule.get(\u0027ip_protocol\u0027),\n 47                 cidr\u003dsg_rule.get(\u0027cidr\u0027))\n\nSo the position level of cidr as the same as the other parameters.\nIn addtion, the parameter \"id\" should not be passed to the API.\nSo the request body should be:\n\n reqeust_body \u003d {\n     \"to_port\": 80,\n     \"from_port\": 80,\n     \"ip_protocol\": \"TCP\",\n     \"cidr\": \"10.10.10.0/24\"\n }\n\nand here should be\n\n resp \u003d self.client.create_security_default_group_rule(**reqeust_body)","commit_id":"b163cce166c83a17091de45e54dbcf946873e42b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1a979a13794659935d9e46a0c9315051e6ec78dd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":75,"context_line":"            {\"security_group_default_rule\": self.FAKE_RULE},"},{"line_number":76,"context_line":"            to_utf\u003dbytes_body,"},{"line_number":77,"context_line":"            kwargs\u003drequest_body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_create_security_default_group_rule_with_str_body(self):"},{"line_number":80,"context_line":"        self._test_create_security_default_group_rule()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_7b8f9775","line":77,"updated":"2015-09-09 16:18:13.000000000","message":"I believe this is wrong and the fact that the unit test passed is wrong too.\n\n  def a(**kwargs):\n    for k,v in kwargs.items():\n      print k,v\n\n  a(**{\"key\":\"value\"}\n  a(kwargs\u003d{\"key\":\"value\"})","commit_id":"0a3eae3fcfc7e635f4ae6f394cddb65ff815ed52"}]}