)]}'
{"tempest/tests/services/compute/test_interfaces_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f2736a86a4bef0814407998d635e742b1deda2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestImagesClient(base.TestCase):"},{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_916ef0c7","line":25,"updated":"2015-09-03 08:24:42.000000000","message":"Interface client not image","commit_id":"5622daeb63ca04f35c903096673c640e78286ad7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e1cbcdc717258eacd6d052fd0c5d7b154ea5d992","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.tests import fake_auth_provider"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestImagesClient(base.TestCase):"},{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2ce1c79a","line":25,"in_reply_to":"da20952f_916ef0c7","updated":"2015-09-03 08:56:22.000000000","message":"Done","commit_id":"5622daeb63ca04f35c903096673c640e78286ad7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"12f2736a86a4bef0814407998d635e742b1deda2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"},{"line_number":79,"context_line":"                      \u0027port_id\u0027: self.FAKE_PORT_ID[\u0027port_id\u0027]}"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            expected_op \u003d False"},{"line_number":82,"context_line":"            function \u003d self.client.create_interface"},{"line_number":83,"context_line":"            mock_operation \u003d \u0027tempest.common.service_client.ServiceClient.post\u0027"},{"line_number":84,"context_line":"            params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_318fe4cd","line":81,"updated":"2015-09-03 08:24:42.000000000","message":"create_interface also return response same as show.","commit_id":"5622daeb63ca04f35c903096673c640e78286ad7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e1cbcdc717258eacd6d052fd0c5d7b154ea5d992","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"},{"line_number":79,"context_line":"                      \u0027port_id\u0027: self.FAKE_PORT_ID[\u0027port_id\u0027]}"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            expected_op \u003d False"},{"line_number":82,"context_line":"            function \u003d self.client.create_interface"},{"line_number":83,"context_line":"            mock_operation \u003d \u0027tempest.common.service_client.ServiceClient.post\u0027"},{"line_number":84,"context_line":"            params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d72698b9","line":81,"in_reply_to":"da20952f_318fe4cd","updated":"2015-09-03 08:56:22.000000000","message":"Done","commit_id":"5622daeb63ca04f35c903096673c640e78286ad7"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"63a6644bfeb26c83b9b9ce10b25590db5549bc84","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"},{"line_number":29,"context_line":"        \"list\": {"},{"line_number":30,"context_line":"            \"interfaceAttachments\": [{"},{"line_number":31,"context_line":"                \"fixed_ips\": [{"},{"line_number":32,"context_line":"                    \"ip_address\": \"192.168.1.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_fd9f68b1","line":29,"updated":"2015-09-08 06:32:20.000000000","message":"I didnt get, why is this splitted into list and show , if only the difference of base keyword (interfaceAttachment/s)\nMore cleaner way would be declaring a dict without that keyword and reuse the same in functions. \nMay be I\u0027m missing something here.","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a9bf3c7271d80983318952dbbe52f679051dc9c0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"},{"line_number":29,"context_line":"        \"list\": {"},{"line_number":30,"context_line":"            \"interfaceAttachments\": [{"},{"line_number":31,"context_line":"                \"fixed_ips\": [{"},{"line_number":32,"context_line":"                    \"ip_address\": \"192.168.1.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_e57ee169","line":29,"in_reply_to":"da20952f_49b25295","updated":"2015-09-08 12:38:50.000000000","message":"IMHO the best way is to do it like:\nhttps://github.com/openstack/tempest/blob/master/tempest/tests/services/compute/test_networks_client.py#L59","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"2df18d1dbea2f4e6304ec3fa5f98be84af889df3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"},{"line_number":29,"context_line":"        \"list\": {"},{"line_number":30,"context_line":"            \"interfaceAttachments\": [{"},{"line_number":31,"context_line":"                \"fixed_ips\": [{"},{"line_number":32,"context_line":"                    \"ip_address\": \"192.168.1.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_49b25295","line":29,"in_reply_to":"da20952f_dd2ce403","updated":"2015-09-08 09:06:34.000000000","message":"yes, functionality is not affected, but I prefer more cleaner way of reading/understanding code and also it is redundant ( actual dict of list and show are same ) , but again it is my opinion :) . If everyone else are fine, you can keep it. :)","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"20bfee2f9e9c93b890a834f431dd32c380945cdf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"},{"line_number":29,"context_line":"        \"list\": {"},{"line_number":30,"context_line":"            \"interfaceAttachments\": [{"},{"line_number":31,"context_line":"                \"fixed_ips\": [{"},{"line_number":32,"context_line":"                    \"ip_address\": \"192.168.1.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3e5a8c2b","line":29,"in_reply_to":"da20952f_e57ee169","updated":"2015-09-09 02:25:47.000000000","message":"@Marc , @Anusha San:\nI have modified it, with minor changes.\nUploading in my next patch","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"15e8dd21531575e4dea9e1edc077c0c4ee079aae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Data Values to be used for testing #"},{"line_number":27,"context_line":"    RESPONSE_CODE \u003d 200"},{"line_number":28,"context_line":"    FAKE_INTERFACE_DATA \u003d {"},{"line_number":29,"context_line":"        \"list\": {"},{"line_number":30,"context_line":"            \"interfaceAttachments\": [{"},{"line_number":31,"context_line":"                \"fixed_ips\": [{"},{"line_number":32,"context_line":"                    \"ip_address\": \"192.168.1.1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_dd2ce403","line":29,"in_reply_to":"da20952f_fd9f68b1","updated":"2015-09-08 06:46:18.000000000","message":"List has interfaceAttachments, while show has interfaceAttachment :)\nIt could be cleaner, but it is not affecting the overall code.","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a9bf3c7271d80983318952dbbe52f679051dc9c0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            mock_operation, return_value\u003dresponse))"},{"line_number":95,"context_line":"        if expected_op:"},{"line_number":96,"context_line":"            self.assertEqual(expected_op,"},{"line_number":97,"context_line":"                             function(**params))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_list_interfaces_with_str_body(self):"},{"line_number":100,"context_line":"        self._test_interface_operation(\u0027list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_65a89178","line":97,"updated":"2015-09-08 12:38:50.000000000","message":"code block need\u0027s to get deduplicated.","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"20bfee2f9e9c93b890a834f431dd32c380945cdf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            mock_operation, return_value\u003dresponse))"},{"line_number":95,"context_line":"        if expected_op:"},{"line_number":96,"context_line":"            self.assertEqual(expected_op,"},{"line_number":97,"context_line":"                             function(**params))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_list_interfaces_with_str_body(self):"},{"line_number":100,"context_line":"        self._test_interface_operation(\u0027list\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9e495863","line":97,"in_reply_to":"da20952f_65a89178","updated":"2015-09-09 02:25:47.000000000","message":"Dear Marc,\nCan you be more descriptive about the comment?","commit_id":"3e99342cc7286f848c79757c15149d2b2d42ca56"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9c90154533c386e76016d76a051f3cedbe4e687","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"interfaceAttachments\": [FAKE_INTERFACE_DATA]}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    FAKE_SERVER_ID \u003d \"ec14c864-096e-4e27-bb8a-2c2b4dc6f3f5\""},{"line_number":44,"context_line":"    FAKE_PORT_ID \u003d FAKE_SHOW_DATA[\u0027interfaceAttachment\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestInterfacesClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_c3b4d0d5","line":44,"updated":"2015-09-09 08:14:51.000000000","message":"FAKE_PORT_ID \u003d FAKE_SHOW_DATA[\u0027interfaceAttachment\u0027][\"port_id\"]","commit_id":"d59420841dae9897830ffc7c90a9c3b57a1926a8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9c90154533c386e76016d76a051f3cedbe4e687","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        elif operation \u003d\u003d \u0027show\u0027:"},{"line_number":65,"context_line":"            function \u003d self.client.show_interface"},{"line_number":66,"context_line":"            params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"},{"line_number":67,"context_line":"                      \u0027port_id\u0027: self.FAKE_PORT_ID[\u0027port_id\u0027]}"},{"line_number":68,"context_line":"        elif operation \u003d\u003d \u0027delete\u0027:"},{"line_number":69,"context_line":"            expected_op \u003d False"},{"line_number":70,"context_line":"            function \u003d self.client.delete_interface"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_83e578dd","line":67,"updated":"2015-09-09 08:14:51.000000000","message":"can be done as above comment as per variable name","commit_id":"d59420841dae9897830ffc7c90a9c3b57a1926a8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c9c90154533c386e76016d76a051f3cedbe4e687","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            mock_operation, return_value\u003dresponse))"},{"line_number":87,"context_line":"        if expected_op:"},{"line_number":88,"context_line":"            self.assertEqual(expected_op,"},{"line_number":89,"context_line":"                             function(**params))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_list_interfaces_with_str_body(self):"},{"line_number":92,"context_line":"        self._test_interface_operation(\u0027list\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_23eeecb4","line":89,"updated":"2015-09-09 08:14:51.000000000","message":"this can be further optimize by sharing code from base class- https://review.openstack.org/#/c/220152/","commit_id":"d59420841dae9897830ffc7c90a9c3b57a1926a8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d3c2083605228d692da2359ba9208f7f1fa259ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_010e003b","line":67,"updated":"2015-09-28 16:27:16.000000000","message":"You never switch back to value to 200 (the default). So your tests are dependent on the order in which they are executed. Here you are okay because for the moment we never actually read the value of RESPONSE_CODE so you can put a bogus value (like \"100000\") and your tests will pass\n\nSo you should not make this RESPONSE_CODE variable a class variable. But instead, define it on a per test basis.\n\nAs a good practice, always think of the visibility/scope of your variables.","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6616f1e8ae69e6806edc98b9914b933d66d1036c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_163952f2","line":67,"in_reply_to":"9a1a9d01_010e003b","updated":"2015-09-29 00:30:54.000000000","message":"That\u0027s not true. Those does not depends on tests execution order. \n\nself.RESPONSE_CODE at L67 is created as instance variable and it does not change class one.\n\n\u003eso you can put a bogus value (like \"100000\") and your tests will pass\nTest will fail if any wrong response code is returned that\u0027s why service client check expected response code either directly or through schema in this case. \n\nIt could have been issue with self.__class__.RESPONSE_CODE","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"70cb5d3887f28a7ae22b784665ca885b0f0c3f22","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_fe8d55d3","line":67,"in_reply_to":"9a1a9d01_163952f2","updated":"2015-09-30 09:07:24.000000000","message":"I disagree on both points. \n\nclass a():\n    RESPONSE_CODE\u003d200\n    def test(self):\n      self.RESPONSE_CODE\u003d202\n    def test2(self):\n       print self.RESPONSE_CODE\nmy \u003d a()\nmy.RESPONSE_CODE\nmy.test()\nmy.RESPONSE_CODE\nmy.test2()\n\n\nYou\u0027ll see a different value whether you call test or test2 first. (but I misused the term class variable in my last comment, sorry about that).","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f1e4019edf381d9e755812f6cad37ee3ae7d555","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_c14f4c32","line":67,"in_reply_to":"9a1a9d01_87e649e6","updated":"2015-09-30 13:06:59.000000000","message":"Thanks Jordan. Yea, response_code can be local here.","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8b2b68698163e4353534686b903b2f32757938b2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_1e1b4082","line":67,"in_reply_to":"9a1a9d01_c14f4c32","updated":"2015-10-01 00:20:24.000000000","message":"Done","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a89ce3a3d2e62032dad3ebf06ea860bd19a1dc2d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_87e649e6","line":67,"in_reply_to":"9a1a9d01_c43204a7","updated":"2015-09-30 12:02:50.000000000","message":"After some discussion with Ghanshyam the current code is okay and works.\n\nBut I argue that sharing variable (i.e the RESPONSE_CODE variable) between independent tests is a bad practice.\n\nYou should declare the response_code in each of your if/elif/else branch, ie do not you or declare self.RESPONSE_CODE","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86ef5672013bf7769bc4dded855cbf59c2410029","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.RESPONSE_CODE \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_c43204a7","line":67,"in_reply_to":"9a1a9d01_fe8d55d3","updated":"2015-09-30 09:31:03.000000000","message":"After test(), test2() always refer instance variable not class one.\n\nBut there is little bit difference for testr run, where each test will get created as separate tests object right?\n\nThat\u0027s why even with any order of tests it pass. If it change the response code for other test method then it will get failed as schema check expected code otherwise they fails.","commit_id":"4fe4c7e858458600f00be67ca9bfc8322d8e6f11"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e583f0b95f31eafa99dce6a9c815e8f102024de8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                                         \"regionOne\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _test_interface_operation(self, operation\u003d\"create\", bytes_body\u003dFalse):"},{"line_number":52,"context_line":"        self.response_code \u003d 200"},{"line_number":53,"context_line":"        expected_op \u003d self.FAKE_SHOW_DATA"},{"line_number":54,"context_line":"        mock_operation \u003d self.func2mock[\u0027get\u0027]"},{"line_number":55,"context_line":"        params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_3f502f0a","line":52,"updated":"2015-10-02 16:17:02.000000000","message":"This is not a local variable, this is an instance variable.\n\nPlease make this a local variable:\n\n  response_code \u003d 200\n\nno \"self\".\n\nThanks :)","commit_id":"e687123b15b4fd2edc1801e55a6fa4c813ad0dc8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"273e37d603a816cf85e1fac25e15dafac9785068","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                                         \"regionOne\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _test_interface_operation(self, operation\u003d\"create\", bytes_body\u003dFalse):"},{"line_number":52,"context_line":"        self.response_code \u003d 200"},{"line_number":53,"context_line":"        expected_op \u003d self.FAKE_SHOW_DATA"},{"line_number":54,"context_line":"        mock_operation \u003d self.func2mock[\u0027get\u0027]"},{"line_number":55,"context_line":"        params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_d17eba69","line":52,"in_reply_to":"9a1a9d01_3f502f0a","updated":"2015-10-03 01:27:18.000000000","message":"Even if it is an instance variable ,will it have an affect on the code?\nIt is being redefined at every new call of the function","commit_id":"e687123b15b4fd2edc1801e55a6fa4c813ad0dc8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"bbbdd304b10e7a841a755c623aa68970151d617b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                                         \"regionOne\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _test_interface_operation(self, operation\u003d\"create\", bytes_body\u003dFalse):"},{"line_number":52,"context_line":"        self.response_code \u003d 200"},{"line_number":53,"context_line":"        expected_op \u003d self.FAKE_SHOW_DATA"},{"line_number":54,"context_line":"        mock_operation \u003d self.func2mock[\u0027get\u0027]"},{"line_number":55,"context_line":"        params \u003d {\u0027server_id\u0027: self.FAKE_SERVER_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_49067621","line":52,"in_reply_to":"9a1a9d01_d17eba69","updated":"2015-10-04 16:22:54.000000000","message":"It\u0027s not because it works that it\u0027s good. I can tell you from experience that (ab)using instance variables when a local variable could work is a source of bugs.","commit_id":"e687123b15b4fd2edc1801e55a6fa4c813ad0dc8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e583f0b95f31eafa99dce6a9c815e8f102024de8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            expected_op \u003d {}"},{"line_number":65,"context_line":"            mock_operation \u003d self.func2mock[\u0027delete\u0027]"},{"line_number":66,"context_line":"            function \u003d self.client.delete_interface"},{"line_number":67,"context_line":"            self.response_code \u003d 202"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            function \u003d self.client.create_interface"},{"line_number":70,"context_line":"            mock_operation \u003d self.func2mock[\u0027post\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_5f4ba359","line":67,"updated":"2015-10-02 16:17:02.000000000","message":"same","commit_id":"e687123b15b4fd2edc1801e55a6fa4c813ad0dc8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e583f0b95f31eafa99dce6a9c815e8f102024de8","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.check_service_client_function("},{"line_number":73,"context_line":"            function, mock_operation, expected_op,"},{"line_number":74,"context_line":"            bytes_body, self.response_code, **params)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_list_interfaces_with_str_body(self):"},{"line_number":77,"context_line":"        self._test_interface_operation(\u0027list\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_1f744b9a","line":74,"updated":"2015-10-02 16:17:02.000000000","message":"same","commit_id":"e687123b15b4fd2edc1801e55a6fa4c813ad0dc8"}]}