)]}'
{"tempest/config.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0caedc2812a2b2283c53f34219435226a292c20a","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    cfg.IntOpt(\u0027notification_wait\u0027,"},{"line_number":875,"context_line":"               default\u003d120,"},{"line_number":876,"context_line":"               help\u003d\"The seconds to wait on notifications about the container \""},{"line_number":877,"context_line":"                    \"and objects sent to swift.\"),"},{"line_number":878,"context_line":"    cfg.IntOpt(\u0027notification_sleep\u0027,"},{"line_number":879,"context_line":"               default\u003d1,"},{"line_number":880,"context_line":"               help\u003d\"The seconds to sleep after an unsuccessful notification \""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_e0d48bbe","line":877,"updated":"2015-10-12 08:40:09.000000000","message":"Does this have to be swift specific? If so the config option name should say so, but I\u0027d rather keep it generic and drop the reference to swift.","commit_id":"dd5ba3c16500ba2e55b41bd362b93d7047ca457b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0caedc2812a2b2283c53f34219435226a292c20a","unresolved":false,"context_lines":[{"line_number":877,"context_line":"                    \"and objects sent to swift.\"),"},{"line_number":878,"context_line":"    cfg.IntOpt(\u0027notification_sleep\u0027,"},{"line_number":879,"context_line":"               default\u003d1,"},{"line_number":880,"context_line":"               help\u003d\"The seconds to sleep after an unsuccessful notification \""},{"line_number":881,"context_line":"                    \"checking.\"),"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_a0fe9336","line":880,"updated":"2015-10-12 08:40:09.000000000","message":"This is fine if the swift reference is removed above.","commit_id":"dd5ba3c16500ba2e55b41bd362b93d7047ca457b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"42b4a2a6521f7bfdd6fcd10f86abcc6398c5e9c5","unresolved":false,"context_lines":[{"line_number":871,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":872,"context_line":"                help\u003d\"This variable is used as flag to enable \""},{"line_number":873,"context_line":"                     \"notification tests\"),"},{"line_number":874,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"},{"line_number":875,"context_line":"               default\u003d120,"},{"line_number":876,"context_line":"               help\u003d\"The seconds to wait on notifications about the container \""},{"line_number":877,"context_line":"                    \"and objects sent to swift.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_6a6edb02","line":874,"updated":"2015-12-05 21:17:59.000000000","message":"I understand that build_timeout and build_interval are used by other services as well, so they are consistent in that sense, but the name strikes me as a bit odd when applied to a notification timeout.","commit_id":"39f7af7fe550ec0cae1ca62d4ad3c648d80bb70c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"41751aff9ee1c984177d266560769bd8a55e4487","unresolved":false,"context_lines":[{"line_number":871,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":872,"context_line":"                help\u003d\"This variable is used as flag to enable \""},{"line_number":873,"context_line":"                     \"notification tests\"),"},{"line_number":874,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"},{"line_number":875,"context_line":"               default\u003d120,"},{"line_number":876,"context_line":"               help\u003d\"The seconds to wait on notifications about the container \""},{"line_number":877,"context_line":"                    \"and objects sent to swift.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_d8db50ec","line":874,"in_reply_to":"7a740942_6a6edb02","updated":"2016-01-12 16:08:41.000000000","message":"I agree, notifications are not builds, this should be a more meaningful variable name.","commit_id":"39f7af7fe550ec0cae1ca62d4ad3c648d80bb70c"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"42b4a2a6521f7bfdd6fcd10f86abcc6398c5e9c5","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"},{"line_number":875,"context_line":"               default\u003d120,"},{"line_number":876,"context_line":"               help\u003d\"The seconds to wait on notifications about the container \""},{"line_number":877,"context_line":"                    \"and objects sent to swift.\"),"},{"line_number":878,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":879,"context_line":"               default\u003d1,"},{"line_number":880,"context_line":"               help\u003d\"The seconds to sleep after an unsuccessful notification \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4aad1f30","line":877,"updated":"2015-12-05 21:17:59.000000000","message":"Is this timeout really specific to swift? \nSimilar API tests use the compute configured timeouts (http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/telemetry/base.py#n104), so I wonder whether we should have telemetry notification timeout used by all the telemetry tests.","commit_id":"39f7af7fe550ec0cae1ca62d4ad3c648d80bb70c"}],"tempest/scenario/test_swift_telemetry_middleware.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"73fa9867a70f43b920f021da29de2305f43da901","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            return (container_name in containers and obj_name in objects)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Loop for up to 120 seconds waiting on notifications"},{"line_number":90,"context_line":"        # NOTE(chdent): The choice of 120 seconds is fairly"},{"line_number":91,"context_line":"        # arbitrary: Long enough to give the notifications the"},{"line_number":92,"context_line":"        # chance to travel across a highly latent bus but not"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_9652b467","line":89,"updated":"2015-09-08 16:26:33.000000000","message":"I am not sure we should keep the code comment. The \"120\" seconds part doesn\u0027t seem right.","commit_id":"e6a3e8d166955bd3628b184a8465044aa586a7de"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"b157cd1444e4866c1ee8c5de504d48bda0b78cab","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            return (container_name in containers and obj_name in objects)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Loop for up to 120 seconds waiting on notifications"},{"line_number":90,"context_line":"        # NOTE(chdent): The choice of 120 seconds is fairly"},{"line_number":91,"context_line":"        # arbitrary: Long enough to give the notifications the"},{"line_number":92,"context_line":"        # chance to travel across a highly latent bus but not"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3e128c0a","line":89,"in_reply_to":"da20952f_9652b467","updated":"2015-09-09 02:13:16.000000000","message":"I think it\u0027s worth leaving a note here about the \"120\" seconds. Otherwise, people may confuse about why the notification_wait is set to 120.","commit_id":"e6a3e8d166955bd3628b184a8465044aa586a7de"}]}