)]}'
{"HACKING.rst":[{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"0e0a501de3a51d34ac2a4776527593646070cc2c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- [T106] vim configuration should not be kept in source files."},{"line_number":16,"context_line":"- [T107] Check that a service tag isn\u0027t in the module path"},{"line_number":17,"context_line":"- [T108] Check no hyphen at the end of rand_name() argument"},{"line_number":18,"context_line":"- [T109] Cannot use testtools.skip decorator"},{"line_number":19,"context_line":"- [N322] Method\u0027s default argument shouldn\u0027t be mutable"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Test Data/Configuration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_235d7179","line":18,"updated":"2015-09-02 19:13:51.000000000","message":"This should match the message that is produced:\n\n    [T109] Cannot use testtools.skip decorator; instead use decorators.skip_because from tempest-lib","commit_id":"3352f87a3601bd759bae54a0eb59f3898ff608ad"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"79b2e86b37c1b3222911c44d02c8844a178e42b3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- [T106] vim configuration should not be kept in source files."},{"line_number":16,"context_line":"- [T107] Check that a service tag isn\u0027t in the module path"},{"line_number":17,"context_line":"- [T108] Check no hyphen at the end of rand_name() argument"},{"line_number":18,"context_line":"- [T109] Cannot use testtools.skip decorator"},{"line_number":19,"context_line":"- [N322] Method\u0027s default argument shouldn\u0027t be mutable"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Test Data/Configuration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_9ebe14fe","line":18,"in_reply_to":"da20952f_235d7179","updated":"2015-09-02 19:23:05.000000000","message":"Done","commit_id":"3352f87a3601bd759bae54a0eb59f3898ff608ad"}],"tempest/hacking/checks.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c7b455b28acfb7d631ecf8a65bf912907f58fc4c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    T109"},{"line_number":140,"context_line":"    \"\"\""},{"line_number":141,"context_line":"    if TESTTOOLS_SKIP_DECORATOR.match(logical_line):"},{"line_number":142,"context_line":"        yield (0, \"T109: Cannot use testtools.skip decorator\")"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def factory(register):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_94618cd5","line":142,"updated":"2015-08-31 19:39:48.000000000","message":"I think we should probably tell people what they should be using instead. We don\u0027t want unconditional skips without a bug being tracked. To do the tracking using skip-tracker from tempest-lib we need to ensure we\u0027re using decorators.skip_because from tempest-lib.\n\nSo I think we need to the other decorator in the error message","commit_id":"087c3b3d8471727aeba9591ccbb20857ce0c5f70"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"b389b6b1019588c35cc2fe0a6f4b3c5f16f05b66","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    T109"},{"line_number":140,"context_line":"    \"\"\""},{"line_number":141,"context_line":"    if TESTTOOLS_SKIP_DECORATOR.match(logical_line):"},{"line_number":142,"context_line":"        yield (0, \"T109: Cannot use testtools.skip decorator\")"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def factory(register):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_28014038","line":142,"in_reply_to":"da20952f_94618cd5","updated":"2015-08-31 20:26:08.000000000","message":"Done","commit_id":"087c3b3d8471727aeba9591ccbb20857ce0c5f70"}],"tempest/tests/test_hacking.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4818062bb7bbd550faae64668d390405b75a8cd6","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def test_no_testtools_skip_decorator(self):"},{"line_number":143,"context_line":"        self.assertEqual(1, len(list(checks.no_testtools_skip_decorator("},{"line_number":144,"context_line":"            \" @testtools.skip(\u0027Bug xxx\u0027)\"))))"},{"line_number":145,"context_line":"        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator("},{"line_number":146,"context_line":"            \" @testtools.skipUnless(CONF.something, \u0027msg\u0027)\"))))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_381f20b9","line":145,"updated":"2015-09-01 16:39:34.000000000","message":"Might as well add a check for skipIf:\n\nhttps://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L12","commit_id":"89c09b563debba42cb7198d177ed9d650614c706"},{"author":{"_account_id":8001,"name":"John Warren","email":"jswarren@us.ibm.com","username":"jswarren"},"change_message_id":"d6654484b663c10ccedb07d715777a179597a53f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def test_no_testtools_skip_decorator(self):"},{"line_number":143,"context_line":"        self.assertEqual(1, len(list(checks.no_testtools_skip_decorator("},{"line_number":144,"context_line":"            \" @testtools.skip(\u0027Bug xxx\u0027)\"))))"},{"line_number":145,"context_line":"        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator("},{"line_number":146,"context_line":"            \" @testtools.skipUnless(CONF.something, \u0027msg\u0027)\"))))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e3f459d0","line":145,"in_reply_to":"da20952f_381f20b9","updated":"2015-09-02 18:59:57.000000000","message":"Done","commit_id":"89c09b563debba42cb7198d177ed9d650614c706"}]}