)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"534d99c48d6dc77644b01b7b707173d62011dc0a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"so we don\u0027t rely on tight coupling between method calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I24149494a42c3c2988c1f6b9ef9b8541ed65dc06"},{"line_number":13,"context_line":"Related-Bug: #1482299"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_a776a8d6","line":13,"updated":"2015-09-01 18:43:28.000000000","message":"I would have used Partial-Bug: for this since it is a partial fix","commit_id":"cbdef08c936ac8c94c33c9afdb402c7aa1ac001b"}],"tempest/scenario/manager.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1d9b7480110a80f723a84a228eb9057196b2397e","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            floating_ip[\u0027ip\u0027], thing[\u0027id\u0027])"},{"line_number":559,"context_line":"        return floating_ip"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def create_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":562,"context_line":"                         private_key\u003dNone):"},{"line_number":563,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip,"},{"line_number":564,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_fa42e867","line":561,"updated":"2015-10-12 16:23:29.000000000","message":"I think this method should receive a ssh_client instead of both server_or_ip and private_key.","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"152135a2051e8e3e7af9ff665208eb2ca864b539","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            floating_ip[\u0027ip\u0027], thing[\u0027id\u0027])"},{"line_number":559,"context_line":"        return floating_ip"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    def create_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":562,"context_line":"                         private_key\u003dNone):"},{"line_number":563,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip,"},{"line_number":564,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_6c185285","line":561,"in_reply_to":"7a2fa921_fa42e867","updated":"2015-10-14 04:31:04.000000000","message":"That is a nice idea,I prefer it.\nbut the behavior of getting remove_client in each method is the exiting behavior and I feel fine to merge current patch by the scope of this patch.","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1d9b7480110a80f723a84a228eb9057196b2397e","unresolved":false,"context_lines":[{"line_number":573,"context_line":"            ssh_client.umount(mount_path)"},{"line_number":574,"context_line":"        return timestamp"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def get_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027,"},{"line_number":577,"context_line":"                      private_key\u003dNone):"},{"line_number":578,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip,"},{"line_number":579,"context_line":"                                            private_key\u003dprivate_key)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_ba5d504a","line":576,"updated":"2015-10-12 16:23:29.000000000","message":"same","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"614a6de932b878a4ef3f74ee2a6cd6b63d637bf5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":109,"context_line":"        self._wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _wait_for_volume_available_on_the_system(self, server_or_ip):"},{"line_number":112,"context_line":"        ssh \u003d self.get_remote_client(server_or_ip)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        def _func():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_2f3e79da","line":111,"updated":"2015-10-08 01:39:31.000000000","message":"Need to pass private_key here too as remote client would not find self.keypair for this tests.","commit_id":"afc0bfcd760177f514433eee5c8d3ac3b399d430"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c5fe9c1f8abd6acf68d45944a38a55ccc48613a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":109,"context_line":"        self._wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _wait_for_volume_available_on_the_system(self, server_or_ip):"},{"line_number":112,"context_line":"        ssh \u003d self.get_remote_client(server_or_ip)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        def _func():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_c81a02c6","line":111,"in_reply_to":"7a2fa921_2f3e79da","updated":"2015-10-09 16:00:57.000000000","message":"Ah yeah nice catch.","commit_id":"afc0bfcd760177f514433eee5c8d3ac3b399d430"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1d9b7480110a80f723a84a228eb9057196b2397e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume[\u0027id\u0027])"},{"line_number":109,"context_line":"        self._wait_for_volume_status(volume, \u0027available\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _wait_for_volume_available_on_the_system(self, server_or_ip, keypair):"},{"line_number":112,"context_line":"        ssh \u003d self.get_remote_client(server_or_ip, private_key\u003dkeypair)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        def _func():"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_3abb8077","line":111,"updated":"2015-10-12 16:23:29.000000000","message":"I think this method should receive a ssh_client instead. It weird to pass a keypair to a method called \u0027_wait_for_volume_available_on_the_system\u0027","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1d9b7480110a80f723a84a228eb9057196b2397e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            ip_for_server \u003d server"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self._attach_volume(server, volume)"},{"line_number":147,"context_line":"        self._wait_for_volume_available_on_the_system(ip_for_server, keypair)"},{"line_number":148,"context_line":"        timestamp \u003d self.create_timestamp(ip_for_server,"},{"line_number":149,"context_line":"                                          CONF.compute.volume_device_name,"},{"line_number":150,"context_line":"                                          private_key\u003dkeypair)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_ba76b0d6","line":147,"updated":"2015-10-12 16:23:29.000000000","message":"The ssh_client should be created here and then passed to _wait_for_volume_available_on_the_system and create_timestamp","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2bd20fa9eab41e4e53fdd4ff4bec8b10851cf55e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._wait_for_volume_available_on_the_system(ip_for_server, keypair)"},{"line_number":148,"context_line":"        timestamp \u003d self.create_timestamp(ip_for_server,"},{"line_number":149,"context_line":"                                          CONF.compute.volume_device_name,"},{"line_number":150,"context_line":"                                          private_key\u003dkeypair)"},{"line_number":151,"context_line":"        self._detach_volume(server, volume)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        # snapshot the volume"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_5c0adf27","line":150,"updated":"2015-10-14 09:16:04.000000000","message":"private_key\u003dkeypair[\u0027private_key\u0027]","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2bd20fa9eab41e4e53fdd4ff4bec8b10851cf55e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        # check the existence of the timestamp file in the volume2"},{"line_number":180,"context_line":"        timestamp2 \u003d self.get_timestamp(ip_for_snapshot,"},{"line_number":181,"context_line":"                                        CONF.compute.volume_device_name,"},{"line_number":182,"context_line":"                                        private_key\u003dkeypair)"},{"line_number":183,"context_line":"        self.assertEqual(timestamp, timestamp2)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_d0049316","line":182,"updated":"2015-10-14 09:16:04.000000000","message":"private_key\u003dkeypair[\u0027private_key\u0027]","commit_id":"87a753f382f72a98de6ac59625bfa69a86b27a1b"}]}