)]}'
{"tempest/services/nova/json/images_client.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"4899d84e3f8f5771f4322f770942516213dc0817","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            for param, value in params.iteritems():"},{"line_number":57,"context_line":"                param_list.append(\"%s\u003d%s\u0026\" % (param, value))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            url \u003d \"images/detail?\" + \"\".join(param_list)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        resp, body \u003d self.client.get(url)"},{"line_number":62,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2BIs%3D","line":59,"updated":"2011-12-09 01:27:53.000000000","message":"This really isn\u0027t how I intended to handle exceptions. By handling exceptions in each individual method, this means that every method would need to handle every exception. Is there some good reason you think this can\u0027t be handled in rest_client.py?","commit_id":"679096982757b89a930d2f04ca1b00bf640d5471"}],"tempest/tests/test_image_metadata.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"4899d84e3f8f5771f4322f770942516213dc0817","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        cls.build_interval \u003d cls.config.nova.build_interval"},{"line_number":23,"context_line":"        cls.build_timeout \u003d cls.config.nova.build_timeout"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_server_fixture(self):"},{"line_number":26,"context_line":"        \"\"\""},{"line_number":27,"context_line":"        Creates a new server instance fixture and returns the server ID"},{"line_number":28,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2BIw%3D","line":25,"updated":"2011-12-09 01:27:53.000000000","message":"I\u0027m not clear why we\u0027re creating this method as opposed to using the standard per method setup and tear down. It doesn\u0027t necessarily matter what standard we follow, but we should follow a standard","commit_id":"679096982757b89a930d2f04ca1b00bf640d5471"}],"tempest/tests/test_images.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"4899d84e3f8f5771f4322f770942516213dc0817","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.client.delete_image(image_id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Verify image no longer found. Note that this does not"},{"line_number":64,"context_line":"        # work for users with admin rights, as they always can see"},{"line_number":65,"context_line":"        # deleted images..."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2BI0%3D","line":63,"updated":"2011-12-09 01:27:53.000000000","message":"This concerns me since it relies on the user seeing this comment. Couldn\u0027t you also do a list images with the changes-since parameter to also verify that the image is deleted? If it works the same as it does for servers (I surely hope it would), this should be possible.","commit_id":"679096982757b89a930d2f04ca1b00bf640d5471"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"4899d84e3f8f5771f4322f770942516213dc0817","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            time.sleep(self.build_interval)"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                resp, image \u003d self.client.get_image(image_id)"},{"line_number":72,"context_line":"                "},{"line_number":73,"context_line":"                if int(time.time()) - start \u003e\u003d self.build_timeout:"},{"line_number":74,"context_line":"                    self.assertTrue(False,"},{"line_number":75,"context_line":"                        \"Failed to get an image not found \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2BI4%3D","line":72,"updated":"2011-12-09 01:27:53.000000000","message":"Got a bit of a whitespace problem","commit_id":"679096982757b89a930d2f04ca1b00bf640d5471"}]}
