)]}'
{"tempest/tests/services/compute/test_security_group_rules_client.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7662918a9323990ee80720868437b202426a0975","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":73,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":74,"context_line":"        resp \u003d self.client.create_security_group_rule(**req_body)"},{"line_number":75,"context_line":"        self.assertEqual(self.FAKE_SECURITY_GROUP_RULE, resp)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_create_security_group_rule_with_str_body(self):"},{"line_number":78,"context_line":"        self._test_create_security_group_rule()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e844a847","line":75,"updated":"2015-09-07 06:33:34.000000000","message":"Duplicate code with other tests","commit_id":"6928bfac3c21b428470ea3ba1bb06dd77a19d88e"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"7662918a9323990ee80720868437b202426a0975","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":90,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":91,"context_line":"            return_value\u003dmocked_resp))"},{"line_number":92,"context_line":"        resp \u003d self.client.list_security_group_rules(group_id)"},{"line_number":93,"context_line":"        return resp"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_list_security_group_rules_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_a879d094","line":92,"updated":"2015-09-07 06:33:34.000000000","message":"Duplicate code with other tests","commit_id":"6928bfac3c21b428470ea3ba1bb06dd77a19d88e"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"b42c2205dd1c05ab9b76398d5e2b2c3d6b407b26","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if bytes_body:"},{"line_number":81,"context_line":"            serialized_body \u003d serialized_body.encode(\u0027utf-8\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        mocked_resp \u003d (httplib2.Response({\u0027status\u0027: 200}), serialized_body)"},{"line_number":84,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":85,"context_line":"            \u0027tempest.common.service_client.ServiceClient.get\u0027,"},{"line_number":86,"context_line":"            return_value\u003dmocked_resp))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_587ea219","line":83,"updated":"2015-09-08 07:25:56.000000000","message":"You could use::\n  mocked_resp \u003d self.create_response(self.FAKE_SECURITY_GROUPS, bytes_body) \n\nAnd delete L79-L83","commit_id":"82646445a04b7283ae540b1c460abb586a8aec73"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"278200a953ba69a9ef50bd96b637269057081a56","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.client.create_security_group_rule,"},{"line_number":65,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":66,"context_line":"            self.FAKE_SECURITY_GROUP_RULE,"},{"line_number":67,"context_line":"            to_utf\u003dbytes_body, kwargs\u003dreq_body)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_security_group_rule_with_str_body(self):"},{"line_number":70,"context_line":"        self._test_create_security_group_rule()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_3bc6ff16","line":67,"updated":"2015-09-09 16:23:59.000000000","message":"I believe this is wrong and the fact that the unit test passed is wrong too.\n  def a(**kwargs):\n    for k,v in kwargs.items():\n      print k,v\n  a(**{\"key\":\"value\"}\n  a(kwargs\u003d{\"key\":\"value\"})","commit_id":"ff49dd22161c0f94b0e630179031188e6f06f97c"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"3ae88ed04122a2ca8a2e39418be26e793d78926d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.client.create_security_group_rule,"},{"line_number":65,"context_line":"            \u0027tempest.common.service_client.ServiceClient.post\u0027,"},{"line_number":66,"context_line":"            self.FAKE_SECURITY_GROUP_RULE,"},{"line_number":67,"context_line":"            to_utf\u003dbytes_body, kwargs\u003dreq_body)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_security_group_rule_with_str_body(self):"},{"line_number":70,"context_line":"        self._test_create_security_group_rule()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_4c4d24c3","line":67,"in_reply_to":"da20952f_3bc6ff16","updated":"2015-09-10 05:04:33.000000000","message":"Sorry, my bad, didn\u0027t give much thought as test case is passing :( \nI believe it is calling function as \n\ncreate_security_group_rule({\u0027kwargs\u0027: req_body}) . \n\nSo on the caller side, it is assigning the same as one dictionary, hence not raising error.\n\npost_body \u003d json.dumps({\u0027security_group_rule\u0027: kwargs})\n\nhttps://github.com/openstack/tempest/blob/master/tempest/services/compute/json/security_group_rules_client.py#L36\n\nI will correct it as **req_body, which would pass only req body not the kwargs keyword with it.\n\nThanks","commit_id":"ff49dd22161c0f94b0e630179031188e6f06f97c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"370404ee0fc6eb58a3ac1add7f20a4bda23441d6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return resp"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_list_security_group_rules_with_str_body(self):"},{"line_number":85,"context_line":"        expected \u003d self.FAKE_SECURITY_GROUPS[\u0027security_groups\u0027][0]"},{"line_number":86,"context_line":"        resp \u003d self._test_list_security_group_rules(group_id\u003d\u0027fake-id\u0027)"},{"line_number":87,"context_line":"        self.assertEqual(expected, resp)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_00c4cc3d","line":85,"updated":"2015-09-10 08:20:52.000000000","message":"This looks bad method on service client, wait till https://review.openstack.org/#/c/221660/","commit_id":"170132de0c7433c7ed7dd8e126e259c5825337e6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fee71b369c185760456ae5ea54cd314bf8656ee9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        }"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    FAKE_SECURITY_GROUPS \u003d {"},{"line_number":37,"context_line":"        \"security_groups\": [{"},{"line_number":38,"context_line":"            \"description\": \"default\","},{"line_number":39,"context_line":"            \"id\": \"fake-id\","}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9affbb00","line":36,"updated":"2015-09-11 08:43:53.000000000","message":"This FAKE_SECURITY_GROUPS is not used in this test case, so we need to remove this.","commit_id":"096afdf35b48b102b212305fb375bd5ffacb1c2b"}]}