)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"cda6e74861e341a73d311ce0d1d7f737897b78ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move add/remove fixed ip action to servers clients"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add/remove fixed ips are server action and currently in"},{"line_number":10,"context_line":"interface_cleint. As all other servers actions are in server_client"},{"line_number":11,"context_line":"so these two methods also should be there."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit moves add/remove fixed ips methods to server_client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_be1d4f11","line":10,"updated":"2015-09-14 07:52:32.000000000","message":":nit: s/interface_cleint/interface_client\n:nit: s/server_client/ servers_client","commit_id":"e0319f7681375a833ee4a7956326d042ded0dc77"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13bac382e99571739eff351205b8e1a77111a68","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move add/remove fixed ip action to servers clients"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add/remove fixed ips are server action and currently in"},{"line_number":10,"context_line":"interface_cleint. As all other servers actions are in server_client"},{"line_number":11,"context_line":"so these two methods also should be there."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit moves add/remove fixed ips methods to server_client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_fe7187e1","line":10,"in_reply_to":"ba15a1d1_be1d4f11","updated":"2015-09-14 08:01:11.000000000","message":"opps, will do","commit_id":"e0319f7681375a833ee4a7956326d042ded0dc77"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"cda6e74861e341a73d311ce0d1d7f737897b78ec","unresolved":false,"context_lines":[{"line_number":10,"context_line":"interface_cleint. As all other servers actions are in server_client"},{"line_number":11,"context_line":"so these two methods also should be there."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit moves add/remove fixed ips methods to server_client."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partially implements blueprint consistent-service-method-names"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_7ec57759","line":13,"updated":"2015-09-14 07:52:32.000000000","message":"+1 to move them to servers_client, as it looks confusing to be listed under interface_client.","commit_id":"e0319f7681375a833ee4a7956326d042ded0dc77"}],"tempest/api/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"cda6e74861e341a73d311ce0d1d7f737897b78ec","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":180,"context_line":"    @test.idempotent_id(\u0027c7e0e60b-ee45-43d0-abeb-8596fd42a2f9\u0027)"},{"line_number":181,"context_line":"    @test.services(\u0027network\u0027)"},{"line_number":182,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":183,"context_line":"        # Add and Remove the fixed IP to server."},{"line_number":184,"context_line":"        server, ifs \u003d self._create_server_get_interfaces()"},{"line_number":185,"context_line":"        interface_count \u003d len(ifs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1e2b1bed","line":182,"updated":"2015-09-14 07:52:32.000000000","message":"just a thought, would it be more apt to move this test case to test_server_actions.py?","commit_id":"e0319f7681375a833ee4a7956326d042ded0dc77"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e13bac382e99571739eff351205b8e1a77111a68","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":180,"context_line":"    @test.idempotent_id(\u0027c7e0e60b-ee45-43d0-abeb-8596fd42a2f9\u0027)"},{"line_number":181,"context_line":"    @test.services(\u0027network\u0027)"},{"line_number":182,"context_line":"    def test_add_remove_fixed_ip(self):"},{"line_number":183,"context_line":"        # Add and Remove the fixed IP to server."},{"line_number":184,"context_line":"        server, ifs \u003d self._create_server_get_interfaces()"},{"line_number":185,"context_line":"        interface_count \u003d len(ifs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_5e58b356","line":182,"in_reply_to":"ba15a1d1_1e2b1bed","updated":"2015-09-14 08:01:11.000000000","message":"Yea, that was the thought when we added this tests but it looks more appropriate here as it has to deal with server interface and we can reuse get interface logic here.","commit_id":"e0319f7681375a833ee4a7956326d042ded0dc77"}],"tempest/services/compute/json/interfaces_client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bd5a69467da535b564cab8d2b59532990b3d0eb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        resp, body \u003d self.delete(\u0027servers/%s/os-interface/%s\u0027 % (server_id,"},{"line_number":49,"context_line":"                                                                 port_id))"},{"line_number":50,"context_line":"        self.validate_response(schema.delete_interface, resp, body)"},{"line_number":51,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def add_fixed_ip(self, server_id, **kwargs):"},{"line_number":54,"context_line":"        \"\"\"Add a fixed IP to input server instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_de08432b","side":"PARENT","line":51,"updated":"2015-09-14 07:31:41.000000000","message":"Dont you need to return  the response body as it was being done earlier?","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"84db3ae4f872c4d283d500864d73f5dc96d6f28d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        resp, body \u003d self.delete(\u0027servers/%s/os-interface/%s\u0027 % (server_id,"},{"line_number":49,"context_line":"                                                                 port_id))"},{"line_number":50,"context_line":"        self.validate_response(schema.delete_interface, resp, body)"},{"line_number":51,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def add_fixed_ip(self, server_id, **kwargs):"},{"line_number":54,"context_line":"        \"\"\"Add a fixed IP to input server instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_fea987e0","side":"PARENT","line":51,"in_reply_to":"ba15a1d1_1e747b9a","updated":"2015-09-14 08:01:17.000000000","message":"Oh okay, got it","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f682eeaec781d964b8d66ef7385de5c67567879b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        resp, body \u003d self.delete(\u0027servers/%s/os-interface/%s\u0027 % (server_id,"},{"line_number":49,"context_line":"                                                                 port_id))"},{"line_number":50,"context_line":"        self.validate_response(schema.delete_interface, resp, body)"},{"line_number":51,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def add_fixed_ip(self, server_id, **kwargs):"},{"line_number":54,"context_line":"        \"\"\"Add a fixed IP to input server instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1e747b9a","side":"PARENT","line":51,"in_reply_to":"ba15a1d1_de08432b","updated":"2015-09-14 07:34:27.000000000","message":"Thanks for review. It is there at L69. It is juts rearrangement of code by git","commit_id":"0f825255e60337d163a3713e799ef7efb2b3fef3"}]}