)]}'
{"tempest/services/compute/xml/servers_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee0ddc03967791e11768ae8665b6257d2568494c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                self._parse_links(body, json[sub])"},{"line_number":132,"context_line":"        return json"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _virtual_interfaces_xml_to_json(self, xml_dom):"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        Return server\u0027s virtual interfaces XML as JSON."},{"line_number":137,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BuzM%3D","line":134,"updated":"2013-02-20 14:34:19.000000000","message":"I\u0027d rather see something other than json used here. That was a bad habit we started for the xml parsing.","commit_id":"4437a19135b429f48e546979e2151758047743ac"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee0ddc03967791e11768ae8665b6257d2568494c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        Return server\u0027s virtual interfaces XML as JSON."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        json \u003d {\"virtual_interfaces\": []}"},{"line_number":139,"context_line":"        for int in xml_dom.getchildren():"},{"line_number":140,"context_line":"            json[\"virtual_interfaces\"].append("},{"line_number":141,"context_line":"                {\"virtual_interface\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BuzA%3D","line":138,"updated":"2013-02-20 14:34:19.000000000","message":"Same here can you call it something more descriptive like data.","commit_id":"4437a19135b429f48e546979e2151758047743ac"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee0ddc03967791e11768ae8665b6257d2568494c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        Return server\u0027s virtual interfaces XML as JSON."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        json \u003d {\"virtual_interfaces\": []}"},{"line_number":139,"context_line":"        for int in xml_dom.getchildren():"},{"line_number":140,"context_line":"            json[\"virtual_interfaces\"].append("},{"line_number":141,"context_line":"                {\"virtual_interface\":"},{"line_number":142,"context_line":"                    {\"id\": int.get(\"id\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Buys%3D","line":139,"updated":"2013-02-20 14:34:19.000000000","message":"int here is a bit confusing. How about using interface or iface?","commit_id":"4437a19135b429f48e546979e2151758047743ac"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee0ddc03967791e11768ae8665b6257d2568494c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            json[\"virtual_interfaces\"].append("},{"line_number":141,"context_line":"                {\"virtual_interface\":"},{"line_number":142,"context_line":"                    {\"id\": int.get(\"id\"),"},{"line_number":143,"context_line":"                     \"mac_addrsss\": int.get(\"mac_address\")}})"},{"line_number":144,"context_line":"        return json"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_server(self, server_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Buyo%3D","line":143,"updated":"2013-02-20 14:34:19.000000000","message":"is this supposed to be mac_address?","commit_id":"4437a19135b429f48e546979e2151758047743ac"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"bc438240ee45b104e801e7361343ff466dc3bb8e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                self._parse_links(body, json[sub])"},{"line_number":132,"context_line":"        return json"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _virtual_interfaces_xml_to_json(self, xml_dom):"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        Return server\u0027s virtual interfaces XML as JSON."},{"line_number":137,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BsFM%3D","line":134,"updated":"2013-02-22 15:09:18.000000000","message":"this method name still is xml_to_json. Could you please change it to something a bit more descriptive, like: _parse_xml_virtual_interfaces()","commit_id":"c941b227d60348c64a9f7f34380732471339737f"}],"tempest/tests/compute/servers/test_virtual_interfaces.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ee0ddc03967791e11768ae8665b6257d2568494c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # for an invalid server_id"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            resp, output \u003d self.client.list_virtual_interfaces(\u0027!@#$%^\u0026*()\u0027)"},{"line_number":58,"context_line":"        except exceptions.NotFound:"},{"line_number":59,"context_line":"            pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bu0k%3D","line":58,"updated":"2013-02-20 14:34:19.000000000","message":"Why don\u0027t you change this to:\n\nself.assertRaises()","commit_id":"4437a19135b429f48e546979e2151758047743ac"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"bc438240ee45b104e801e7361343ff466dc3bb8e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        invalid_server_id \u003d rand_name(\u0027!@#$%^\u0026*()\u0027)"},{"line_number":63,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":64,"context_line":"                          self.client.list_virtual_interfaces,"},{"line_number":65,"context_line":"                          invalid_server_id)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"@attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BsEo%3D","line":65,"updated":"2013-02-22 15:09:18.000000000","message":"I think you should have a more descriptive message here. What you have here will just print the random name and no explanation of what happened.","commit_id":"c941b227d60348c64a9f7f34380732471339737f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9dfae0706c57ce367700e0156463e51e34cd2353","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        invalid_server_id \u003d rand_name(\u0027!@#$%^\u0026*()\u0027)"},{"line_number":63,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":64,"context_line":"                          self.client.list_virtual_interfaces,"},{"line_number":65,"context_line":"                          invalid_server_id)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"@attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BqC4%3D","line":65,"in_reply_to":"AAAAM3%2F%2BsEo%3D","updated":"2013-02-22 16:43:12.000000000","message":"Actually nm, don\u0027t know what I was thinking, this is fine as is. Sorry about that.","commit_id":"c941b227d60348c64a9f7f34380732471339737f"}]}