)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ad210b0323a85939670c2264591fff3313a2600c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Truong Le \u003clet@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-16 17:06:48 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit test for test_servers_client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a plan to migrate service clients to tempest-lib from Tempest."},{"line_number":10,"context_line":"However, we are not doing enough tests for service clients now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_ebe4c7a8","line":7,"updated":"2015-09-24 03:55:53.000000000","message":"It is better to change the title to\n\n Add unit tests for show_server and list_servers\n\nfor distinguishing from the other servers_client tests.","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ad210b0323a85939670c2264591fff3313a2600c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a plan to migrate service clients to tempest-lib from Tempest."},{"line_number":10,"context_line":"However, we are not doing enough tests for service clients now."},{"line_number":11,"context_line":"This patch adds unit test for test_servers_client."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia3deead19f60c2e32201d3ccfab8b6d2070b2a33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_4b9b7318","line":11,"updated":"2015-09-24 03:55:53.000000000","message":"ditto\n\n This patch adds unit tests for show_server and list_servers.","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"}],"tempest/tests/services/compute/test_servers_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31052fcdc6d486f4226713968579bd999757d946","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ],"},{"line_number":79,"context_line":"        \"metadata\": {"},{"line_number":80,"context_line":"            \"My Server Name\": \"Apache1\""},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        \"name\": \"new-server-test\","},{"line_number":83,"context_line":"        \"progress\": 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_13ec9f28","line":80,"updated":"2015-09-18 10:11:02.000000000","message":"Would you mind adding a unicode char here ? For instance:\n\n  u\"My Server Nu\\1234me\": u\"Apau\\1234che1\"","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3feeba9d447fb87231c820014d9754d7ca36d083","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ],"},{"line_number":79,"context_line":"        \"metadata\": {"},{"line_number":80,"context_line":"            \"My Server Name\": \"Apache1\""},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        \"name\": \"new-server-test\","},{"line_number":83,"context_line":"        \"progress\": 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a972b2e1","line":80,"in_reply_to":"9a1a9d01_c80c0445","updated":"2015-10-04 16:13:37.000000000","message":"If you only use ASCII characters, then there\u0027s no difference between a UTF-8 string an and ASCII string. So you need to add \"special\" chars such as u\"\\u1234\"","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":17866,"name":"Truong Le","email":"let@us.ibm.com","username":"truongle"},"change_message_id":"32c2e1fb6afd9d309dfa0b2a4704bdb5e977ecba","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ],"},{"line_number":79,"context_line":"        \"metadata\": {"},{"line_number":80,"context_line":"            \"My Server Name\": \"Apache1\""},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        \"name\": \"new-server-test\","},{"line_number":83,"context_line":"        \"progress\": 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c80c0445","line":80,"in_reply_to":"ba15a1d1_13ec9f28","updated":"2015-10-02 15:36:32.000000000","message":"I know why we have \"u\" character, but I don\u0027t understand why we would have to insert u\\1234. I think I just need insert \"u\" like below\nu\"My Server Name\": u\"Apache1\"","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f450e4bae59d6ef80ee1b90944316b05e8c5a037","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        ],"},{"line_number":79,"context_line":"        \"metadata\": {"},{"line_number":80,"context_line":"            \"My Server Name\": \"Apache1\""},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        \"name\": \"new-server-test\","},{"line_number":83,"context_line":"        \"progress\": 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_2664fab6","line":80,"in_reply_to":"ba15a1d1_13ec9f28","updated":"2015-10-01 04:55:36.000000000","message":"Maybe\n\n s/\"\\1234\"/\"\\u1234\"/ on Jordan\u0027s comment for representing unitcode data\n\nhttps://docs.python.org/2/howto/unicode.html#unicode-literals-in-python-source-code\n\nTruong, there is a lot of good samples for implementing unit tests under tempest/tests/services/compute/.\n\nThis Jordan\u0027s point also is implemented in test_volumes_extensions_client.py like\n\n 27     FAKE_VOLUME \u003d {\n 28         \"id\": \"521752a6-acf6-4b2d-bc7a-119f9148cd8c\",\n 29         \"displayName\": u\"v\\u12345ol-001\",\n\nThey are useful to implement actual code.","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31052fcdc6d486f4226713968579bd999757d946","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"metadata\": {"},{"line_number":80,"context_line":"            \"My Server Name\": \"Apache1\""},{"line_number":81,"context_line":"        },"},{"line_number":82,"context_line":"        \"name\": \"new-server-test\","},{"line_number":83,"context_line":"        \"progress\": 0,"},{"line_number":84,"context_line":"        \"status\": \"ACTIVE\","},{"line_number":85,"context_line":"        \"tenant_id\": \"openstack\","}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b3db737b","line":82,"updated":"2015-09-18 10:11:02.000000000","message":"Same here.","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"31052fcdc6d486f4226713968579bd999757d946","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"user_id\": \"fake\"}"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    server_id \u003d \u00273426c2ee-2658-43a9-bd05-3f1fecd1c027\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def setUp(self):"},{"line_number":93,"context_line":"        super(TestServersClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_332c4398","line":90,"updated":"2015-09-18 10:11:02.000000000","message":"This is a bit confusing: in test_show_server you ask to \"get\" the server with id 3426c2ee-2658-43a9-bd05-3f1fecd1c027 but then your Mock returns a server with id 893c7791-f1df-4c3d-8... In the future we might tighten our test to check that what is returned is what we asked for.\n\nYou can replace L90 with:\n  server_id \u003d FAKE_SERVER_GET[\u0027id\u0027]","commit_id":"3f5105bff7629047cd6b9d7a054bab70acfd5706"}]}