)]}'
{"tempest/tests/common/test_service_clients.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec7e2850a972024e45bb1ec53dd03db94bfe5985","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.services.baremetal.v1.json import baremetal_client"},{"line_number":20,"context_line":"from tempest.services.compute.json import agents_client"},{"line_number":21,"context_line":"from tempest.services.compute.json import aggregates_client"},{"line_number":22,"context_line":"from tempest.services.compute.json import availability_zone_client"},{"line_number":23,"context_line":"from tempest.services.compute.json import certificates_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6db1c146","side":"PARENT","line":20,"updated":"2015-09-17 00:30:21.000000000","message":"should not we keep these tests (import client from tempest-lib)? and once all gets migrated we can move this tests file to lib?","commit_id":"eb9941ba06d87b3fb458ce472cae4c594ad8c0cf"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a60f64de5911bce656d7b8da24f9b5cb7b9a0326","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.services.baremetal.v1.json import baremetal_client"},{"line_number":20,"context_line":"from tempest.services.compute.json import agents_client"},{"line_number":21,"context_line":"from tempest.services.compute.json import aggregates_client"},{"line_number":22,"context_line":"from tempest.services.compute.json import availability_zone_client"},{"line_number":23,"context_line":"from tempest.services.compute.json import certificates_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_b3417665","side":"PARENT","line":20,"in_reply_to":"ba15a1d1_6db1c146","updated":"2015-09-17 02:23:22.000000000","message":"Very nice point, I also did think about that.\nHowever, I got these tests are unnecessary now.\n\nThe main purpose of this test was for checking all parameters\u0027 values are passed to RestClient via ServiceClient.\nBut we don\u0027t need ServiceClient now and we can implement service clients without ServiceClient in tempest-lib.\nAs https://review.openstack.org/#/c/223286/7/tempest_lib/services/compute/agents_client.py , the service client uses RestClient directly. So this test is meaningless now in tempest-lib.\nThat is a reason why I abandoned https://review.openstack.org/#/c/224053/","commit_id":"eb9941ba06d87b3fb458ce472cae4c594ad8c0cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56af14cb0c8d6cefd16dee6f74fe51b93c29317e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.services.baremetal.v1.json import baremetal_client"},{"line_number":20,"context_line":"from tempest.services.compute.json import agents_client"},{"line_number":21,"context_line":"from tempest.services.compute.json import aggregates_client"},{"line_number":22,"context_line":"from tempest.services.compute.json import availability_zone_client"},{"line_number":23,"context_line":"from tempest.services.compute.json import certificates_client"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_459cc20e","side":"PARENT","line":20,"in_reply_to":"ba15a1d1_b3417665","updated":"2015-09-17 10:49:11.000000000","message":"Ahh I see. Now I can remember the rational behind those tests. Thanks. m ok with that.","commit_id":"eb9941ba06d87b3fb458ce472cae4c594ad8c0cf"}]}