)]}'
{"tempest/tests/compute/servers/test_server_metadata.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"3967d577acb6ee508dca1389369302c821a612d1","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        try:"},{"line_number":223,"context_line":"            resp, metadata \u003d self.client.set_server_metadata(self.server_id,"},{"line_number":224,"context_line":"                                                             req_metadata)"},{"line_number":225,"context_line":"        except exceptions.OverLimit:"},{"line_number":226,"context_line":"            pass"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            self.fail(\u0027Should raise overlimit exception if metadata items for\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BtMQ%3D","line":225,"updated":"2013-02-21 01:53:06.000000000","message":"To be consistent in negative testing, we should exclusively be using assertRaises or the try/except methodology, but not both","commit_id":"a9b86f26510b887fdc3143b9af5d94bb6566eb94"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"3967d577acb6ee508dca1389369302c821a612d1","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        _, quota_set \u003d self.quotas.get_quota_set(self.tenant_id)"},{"line_number":236,"context_line":"        quota_metadata \u003d quota_set[\u0027metadata_items\u0027]"},{"line_number":237,"context_line":"        req_metadata \u003d {}"},{"line_number":238,"context_line":"        for sz in range(1, quota_metadata + 2):"},{"line_number":239,"context_line":"            req_metadata[\u0027key\u0027 + str(sz)] \u003d \u0027val\u0027 + str(sz)"},{"line_number":240,"context_line":"        try:"},{"line_number":241,"context_line":"            resp, metadata \u003d self.client.update_server_metadata(self.server_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BtME%3D","line":238,"updated":"2013-02-21 01:53:06.000000000","message":"sz is not a good variable name. I have no idea what it stands for","commit_id":"a9b86f26510b887fdc3143b9af5d94bb6566eb94"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"e1be6eacd32bb200fe2fa929a2125ccb54f84697","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        req_metadata \u003d {}"},{"line_number":235,"context_line":"        for num in range(1, quota_metadata + 2):"},{"line_number":236,"context_line":"            req_metadata[\u0027key\u0027 + str(num)] \u003d \u0027val\u0027 + str(num)"},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            resp, metadata \u003d self.client.set_server_metadata(self.server_id,"},{"line_number":239,"context_line":"                                                             req_metadata)"},{"line_number":240,"context_line":"        except exceptions.OverLimit:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bqpk%3D","line":237,"updated":"2013-02-22 07:23:11.000000000","message":"Would you mind changing the try/except/else format of the test to use self.assertRaises. Eg it would like:\n\nself.assertRaises(exceptions.OverLimit, self.client.set_server_metadata,\n                            self.server_id, req_metadata)\n\nThere is now a consensus that we\u0027ll use the self.assertRaises approach so we don\u0027t want to add anymore of the try/except/else while we replace the others. Feel free to update the other cases in this file.","commit_id":"2157be3bb4e2b4444408aa92c743b7e9903b2010"},{"author":{"_account_id":6706,"name":"Ashish Chandra","email":"mail.ashishchandra@gmail.com","username":"ashish-chandra"},"change_message_id":"5c3def6be122b02bfaf9dfca7f1a7651c15d1cd3","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        req_metadata \u003d {}"},{"line_number":235,"context_line":"        for num in range(1, quota_metadata + 2):"},{"line_number":236,"context_line":"            req_metadata[\u0027key\u0027 + str(num)] \u003d \u0027val\u0027 + str(num)"},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            resp, metadata \u003d self.client.set_server_metadata(self.server_id,"},{"line_number":239,"context_line":"                                                             req_metadata)"},{"line_number":240,"context_line":"        except exceptions.OverLimit:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bqaw%3D","line":237,"in_reply_to":"AAAAM3%2F%2Bqpk%3D","updated":"2013-02-22 12:13:17.000000000","message":"Changed the try/except/fail usage to self.assertRaises for tests submitted by me and re-factored other tests as suggested by you.","commit_id":"2157be3bb4e2b4444408aa92c743b7e9903b2010"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b53a0995e813c7b7f43a85263b277355bd08a93b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                          self.client.update_server_metadata,"},{"line_number":226,"context_line":"                          self.server_id, req_metadata)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":229,"context_line":"    def test_update_metadata_empty_body(self):"},{"line_number":230,"context_line":"        # The original metadata should not be lost if empty metadata body is"},{"line_number":231,"context_line":"        # passed"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Boxo%3D","line":228,"updated":"2013-02-24 04:06:21.000000000","message":"I think this is should be marked as a positive test?","commit_id":"a74bdeecd6fa4953e8863fa72195ae4ef2c87ff0"}]}