)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d27defc603816d58a42a27769bbb1f0e55b310d8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Refactor init command so if it detects we are not in a virtual"},{"line_number":17,"context_line":"environment, try to find the global config directory /etc/tempest."},{"line_number":18,"context_line":"If that fails fallback to [sys.prefix]/etc/tempest."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I960bc711ff78ac2b0441ef63dff8ec4fb268fd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba15a1d1_94ace78d","line":19,"updated":"2015-09-21 04:12:44.000000000","message":"Can we put the bug numbers that this will fix here too? I think it\u0027s just:\n\nhttps://bugs.launchpad.net/tempest/+bug/1491058\n\nThe other open tempest init bug:\n\nhttps://bugs.launchpad.net/tempest/+bug/1491264\n\nI think is unrelated","commit_id":"a519512f94c78f63bb361a1f76b1224818b5514a"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"c64a89083739662316c8bf657f1643cbd506926e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Refactor init command so if it detects we are not in a virtual"},{"line_number":17,"context_line":"environment, try to find the global config directory /etc/tempest."},{"line_number":18,"context_line":"If that fails fallback to [sys.prefix]/etc/tempest."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I960bc711ff78ac2b0441ef63dff8ec4fb268fd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba15a1d1_2931efec","line":19,"in_reply_to":"ba15a1d1_94ace78d","updated":"2015-09-21 15:28:56.000000000","message":"Done","commit_id":"a519512f94c78f63bb361a1f76b1224818b5514a"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"436dd1db174fd7a00090e70885458c8469b012ed","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Init command was not working properly as it could not locate the"},{"line_number":10,"context_line":"configuration sample file."},{"line_number":11,"context_line":"Steps taken:"},{"line_number":12,"context_line":"- Move conif-generator.tempest.conf to etc so it will be installed"},{"line_number":13,"context_line":"with pbr."},{"line_number":14,"context_line":"- Update all files with new path to conf-generator-tempest.conf as"},{"line_number":15,"context_line":"needed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_09550bc5","line":12,"updated":"2015-09-21 15:32:23.000000000","message":"Could you please fix the typo here?","commit_id":"1508c0e6a47701b2667a405dd62597996513e7dd"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e6dcfe323133a0226d6df52d6103b4a8fe9782e7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Init command was not working properly as it could not locate the"},{"line_number":10,"context_line":"configuration sample file."},{"line_number":11,"context_line":"Steps taken:"},{"line_number":12,"context_line":"- Move conif-generator.tempest.conf to etc so it will be installed"},{"line_number":13,"context_line":"with pbr."},{"line_number":14,"context_line":"- Update all files with new path to conf-generator-tempest.conf as"},{"line_number":15,"context_line":"needed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_1202033f","line":12,"in_reply_to":"ba15a1d1_09550bc5","updated":"2015-09-21 19:48:55.000000000","message":"Done","commit_id":"1508c0e6a47701b2667a405dd62597996513e7dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8338e33e8726ef10cce6ee3d61ccf6e60d1e5509","unresolved":false,"context_lines":[{"line_number":17,"context_line":"environment, try to find the global config directory /etc/tempest."},{"line_number":18,"context_line":"If that fails fallback to [sys.prefix]/etc/tempest."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1491058"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I960bc711ff78ac2b0441ef63dff8ec4fb268fd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a1a9d01_6eb3d20a","line":20,"updated":"2015-09-30 10:54:23.000000000","message":"Please include this bug too - #1490670","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"0c9d6ce262dcec3ca9d62866d57229a4c7d3cb56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"environment, try to find the global config directory /etc/tempest."},{"line_number":18,"context_line":"If that fails fallback to [sys.prefix]/etc/tempest."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1491058"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I960bc711ff78ac2b0441ef63dff8ec4fb268fd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a1a9d01_4292f158","line":20,"in_reply_to":"9a1a9d01_6eb3d20a","updated":"2015-10-02 15:19:35.000000000","message":"Done","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"}],"tempest/cmd/init.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"100a7c9b9a2593351397b93f291f398a40883caf","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def copy_config(self, etc_dir, config_dir):"},{"line_number":104,"context_line":"        if os.path.isdir(etc_dir):"},{"line_number":105,"context_line":"            shutil.rmtree(etc_dir)"},{"line_number":106,"context_line":"        shutil.copytree(config_dir, etc_dir)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def generate_sample_config(self, local_dir, config_dir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_58294436","line":105,"updated":"2015-09-22 20:44:21.000000000","message":"Why are your removing the tree if it already exists? If it already exists\nthere could already be local config in here we shouldn\u0027t ever delete this.\n\nIf you\u0027re trying to protect against running init on the same dir twice I\u0027d\nsay we should just detect that and exit fast with an error message like the\ndir already exists.","commit_id":"86124a65354b86b65b93b7c881dd9a00e392d1ed"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"e362d665fd1cb1e98650cba3d86b4b2c5846d573","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def copy_config(self, etc_dir, config_dir):"},{"line_number":104,"context_line":"        if os.path.isdir(etc_dir):"},{"line_number":105,"context_line":"            shutil.rmtree(etc_dir)"},{"line_number":106,"context_line":"        shutil.copytree(config_dir, etc_dir)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def generate_sample_config(self, local_dir, config_dir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_81a015f6","line":105,"in_reply_to":"ba15a1d1_58294436","updated":"2015-09-25 14:03:18.000000000","message":"I inherited this from the original patch for this bug here:\nhttps://review.openstack.org/#/c/219589/1/tempest/cmd/init.py\n\nYou are correct, I will change the logic and submit new patch.","commit_id":"86124a65354b86b65b93b7c881dd9a00e392d1ed"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"feb67ccd43d9fbd1560a104791667ec269888e33","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            LOG.debug(\u0027Creating local working dir: %s\u0027 % local_dir)"},{"line_number":118,"context_line":"            os.mkdir(local_dir)"},{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            raise OSError(\"Directory you are trying to initialize already \""},{"line_number":121,"context_line":"                          \"exists: %s\" % local_dir)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        lock_dir \u003d os.path.join(local_dir, \u0027tempest_lock\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a2fa921_def74b89","line":120,"updated":"2015-10-08 20:05:22.000000000","message":"Personally I would have printed this and just called exit(1), but I don\u0027t think it matters too much. If this is actually an issue (which I doubt) it\u0027ll be simple enough to change later","commit_id":"0bf52d497bebb3a0b393f2a8862eaf5161d76d79"}],"tempest/tests/cmd/test_tempest_init.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8338e33e8726ef10cce6ee3d61ccf6e60d1e5509","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf_file \u003d open(conf_path, \u0027r\u0027)"},{"line_number":39,"context_line":"        self.addCleanup(conf_file.close)"},{"line_number":40,"context_line":"        self.assertEqual(conf_file.read(), testr_conf_file)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def negative_test_create_working_dir(self):"},{"line_number":43,"context_line":"        fake_local_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":44,"context_line":"        fake_local_conf_dir \u003d self.useFixture(fixtures.TempDir())"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_0e2a5690","line":41,"updated":"2015-09-30 10:54:23.000000000","message":"Can we have test for generate_sample_config also ?\n\nI was trying that on https://review.openstack.org/#/c/219589/3/tempest/tests/cmd/test_tempest_init.py\n\nBut it good to do it together here as it fix more issues than mine.\n\nThere some issue coming while running on py27 and py34 as unit tests runs on tmp and actual directory resp. I left comment there to make it work on both.","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"0c9d6ce262dcec3ca9d62866d57229a4c7d3cb56","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf_file \u003d open(conf_path, \u0027r\u0027)"},{"line_number":39,"context_line":"        self.addCleanup(conf_file.close)"},{"line_number":40,"context_line":"        self.assertEqual(conf_file.read(), testr_conf_file)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def negative_test_create_working_dir(self):"},{"line_number":43,"context_line":"        fake_local_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":44,"context_line":"        fake_local_conf_dir \u003d self.useFixture(fixtures.TempDir())"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_22201d49","line":41,"in_reply_to":"9a1a9d01_0e2a5690","updated":"2015-10-02 15:19:35.000000000","message":"I would rather add this test in a patch by itself.","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8338e33e8726ef10cce6ee3d61ccf6e60d1e5509","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.addCleanup(conf_file.close)"},{"line_number":40,"context_line":"        self.assertEqual(conf_file.read(), testr_conf_file)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def negative_test_create_working_dir(self):"},{"line_number":43,"context_line":"        fake_local_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":44,"context_line":"        fake_local_conf_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":45,"context_line":"        _init \u003d init.TempestInit(None, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_4e884ec5","line":42,"updated":"2015-09-30 10:54:23.000000000","message":"negative_test_create_working_dir would not be picked by some test loader how about something like-   test_create_working_dir_with_existing_local_dir","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"},{"author":{"_account_id":10644,"name":"David Paterson","email":"davpat2112@yahoo.com","username":"dpaterson"},"change_message_id":"0c9d6ce262dcec3ca9d62866d57229a4c7d3cb56","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.addCleanup(conf_file.close)"},{"line_number":40,"context_line":"        self.assertEqual(conf_file.read(), testr_conf_file)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def negative_test_create_working_dir(self):"},{"line_number":43,"context_line":"        fake_local_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":44,"context_line":"        fake_local_conf_dir \u003d self.useFixture(fixtures.TempDir())"},{"line_number":45,"context_line":"        _init \u003d init.TempestInit(None, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_c2d7e121","line":42,"in_reply_to":"9a1a9d01_4e884ec5","updated":"2015-10-02 15:19:35.000000000","message":"Thank you, will refactor","commit_id":"bc829965bd231f4ddcf1aab18a3d0706195266dc"}]}