)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f70a1cde43084fcd4ca7e4668bfc0ab178329a91","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactor tempest scenarios tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Moved methods \"write_timestamp\" and \"get_timestamp\","},{"line_number":10,"context_line":"which are dublicated in few scenarios, to the common class."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I527557a3cf3618ffa6589dbd1dbc92f2268ed50e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_9551cf38","line":10,"updated":"2015-09-29 07:56:10.000000000","message":"nit, s/dublicated/duplicated\nIf you have a chance to change the other, please consider to fix this.","commit_id":"35626bcc9ac3686189def8d0d9855d53548e6329"}],"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f70a1cde43084fcd4ca7e4668bfc0ab178329a91","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            floating_ip[\u0027ip\u0027], thing[\u0027id\u0027])"},{"line_number":558,"context_line":"        return floating_ip"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def create_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027):"},{"line_number":561,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":562,"context_line":"        if dev_name is not None:"},{"line_number":563,"context_line":"            cmd_mkfs \u003d \u0027sudo /usr/sbin/mkfs.ext4 /dev/%s\u0027 % dev_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b93e4d8a","line":560,"updated":"2015-09-29 07:56:10.000000000","message":"Hmm, I feel this method have too much function for its name.\nI\u0027d like to split this into \"mount\" function and \"create timestamp\" function.\nBut we can split it later.","commit_id":"35626bcc9ac3686189def8d0d9855d53548e6329"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1087aa215ddbf5240a44cfc4d240ef3feebb3b9b","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            floating_ip[\u0027ip\u0027], thing[\u0027id\u0027])"},{"line_number":558,"context_line":"        return floating_ip"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def create_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027):"},{"line_number":561,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":562,"context_line":"        if dev_name is not None:"},{"line_number":563,"context_line":"            cmd_mkfs \u003d \u0027sudo /usr/sbin/mkfs.ext4 /dev/%s\u0027 % dev_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a83835f0","line":560,"in_reply_to":"9a1a9d01_48ae3982","updated":"2015-09-29 10:40:09.000000000","message":"Yes please :)I see many benefit to this approach.","commit_id":"35626bcc9ac3686189def8d0d9855d53548e6329"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"6de3941626b3db45553c420a8edc11c82cd85d2a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            floating_ip[\u0027ip\u0027], thing[\u0027id\u0027])"},{"line_number":558,"context_line":"        return floating_ip"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def create_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027):"},{"line_number":561,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":562,"context_line":"        if dev_name is not None:"},{"line_number":563,"context_line":"            cmd_mkfs \u003d \u0027sudo /usr/sbin/mkfs.ext4 /dev/%s\u0027 % dev_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_48ae3982","line":560,"in_reply_to":"9a1a9d01_b93e4d8a","updated":"2015-09-29 10:31:31.000000000","message":"Should I move these to tempest/common/utils/linux/remote_client.py\nand make 3 methods \"make_fs\", \"mount\" and \"umount\" ?","commit_id":"35626bcc9ac3686189def8d0d9855d53548e6329"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f70a1cde43084fcd4ca7e4668bfc0ab178329a91","unresolved":false,"context_lines":[{"line_number":572,"context_line":"            ssh_client.exec_command(\u0027sudo umount %s\u0027 % mount_path)"},{"line_number":573,"context_line":"        return timestamp"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def get_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027):"},{"line_number":576,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":577,"context_line":"        if dev_name is not None:"},{"line_number":578,"context_line":"            cmd_mount \u003d \u0027sudo mount /dev/%s %s\u0027 % (dev_name, mount_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_d95301e1","line":575,"updated":"2015-09-29 07:56:10.000000000","message":"ditto here","commit_id":"35626bcc9ac3686189def8d0d9855d53548e6329"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9003e2199d90703a6fa3b3e8ad9f430c25229a3c","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":562,"context_line":"        if dev_name is not None:"},{"line_number":563,"context_line":"            ssh_client.make_fs(dev_name)"},{"line_number":564,"context_line":"            ssh_client.mount(dev_name)"},{"line_number":565,"context_line":"        cmd_timestamp \u003d \u0027sudo sh -c \"date \u003e %s/timestamp; sync\"\u0027 % mount_path"},{"line_number":566,"context_line":"        ssh_client.exec_command(cmd_timestamp)"},{"line_number":567,"context_line":"        timestamp \u003d ssh_client.exec_command(\u0027sudo cat %s/timestamp\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8a4e3239","line":564,"updated":"2015-09-30 21:39:50.000000000","message":"Should be passing mount_path in here.\n\nFixed: https://review.openstack.org/#/c/229639/","commit_id":"abd154c87a75bd4100bfe72c2ed3f5d31d5cf0a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9003e2199d90703a6fa3b3e8ad9f430c25229a3c","unresolved":false,"context_lines":[{"line_number":573,"context_line":"    def get_timestamp(self, server_or_ip, dev_name\u003dNone, mount_path\u003d\u0027/mnt\u0027):"},{"line_number":574,"context_line":"        ssh_client \u003d self.get_remote_client(server_or_ip)"},{"line_number":575,"context_line":"        if dev_name is not None:"},{"line_number":576,"context_line":"            ssh_client.mount(dev_name)"},{"line_number":577,"context_line":"        timestamp \u003d ssh_client.exec_command(\u0027sudo cat %s/timestamp\u0027"},{"line_number":578,"context_line":"                                            % mount_path)"},{"line_number":579,"context_line":"        if dev_name is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_6a4f1e34","line":576,"updated":"2015-09-30 21:39:50.000000000","message":"ditto","commit_id":"abd154c87a75bd4100bfe72c2ed3f5d31d5cf0a2"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9003e2199d90703a6fa3b3e8ad9f430c25229a3c","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _add_keypair(self):"},{"line_number":75,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _ssh_to_server(self, server_or_ip):"},{"line_number":78,"context_line":"        return self.get_remote_client(server_or_ip)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_ea59eefd","line":76,"updated":"2015-09-30 21:39:50.000000000","message":"This is now unused.  Fixed here:\n\nhttps://review.openstack.org/#/c/229638/","commit_id":"abd154c87a75bd4100bfe72c2ed3f5d31d5cf0a2"}]}