)]}'
{"tempest/tests/compute/base.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4efc6a847cdb78425c7bf9e59580e2ba1ca1c9f5","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\"Wrapper utility that returns a test server.\"\"\""},{"line_number":178,"context_line":"        name \u003d rand_name(cls.__name__ + \"-instance\")"},{"line_number":179,"context_line":"        if \u0027name\u0027 in kwargs:"},{"line_number":180,"context_line":"            name \u003d kwargs[\u0027name\u0027]"},{"line_number":181,"context_line":"            del kwargs[\u0027name\u0027]"},{"line_number":182,"context_line":"        flavor \u003d kwargs.get(\u0027flavor\u0027, cls.flavor_ref)"},{"line_number":183,"context_line":"        image_id \u003d kwargs.get(\u0027image_id\u0027, cls.image_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Bl0E%3D","line":180,"updated":"2013-02-26 16:06:34.000000000","message":"Why not use kwargs.pop() here? It does exactly this right?","commit_id":"250fb4ad98856bdd69c65bf5eeb69fc04a84fbb6"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"cefada28c5892b3c2876b01f053e4ae214d520a6","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        name \u003d rand_name(cls.__name__ + \"-instance\")"},{"line_number":179,"context_line":"        if \u0027name\u0027 in kwargs:"},{"line_number":180,"context_line":"            name \u003d kwargs[\u0027name\u0027]"},{"line_number":181,"context_line":"            del kwargs[\u0027name\u0027]"},{"line_number":182,"context_line":"        flavor \u003d kwargs.get(\u0027flavor\u0027, cls.flavor_ref)"},{"line_number":183,"context_line":"        image_id \u003d kwargs.get(\u0027image_id\u0027, cls.image_ref)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Bl2s%3D","line":181,"updated":"2013-02-26 15:43:39.000000000","message":"Sean, could this be rewritten as:\nif \u0027name\u0027 in kwargs:\n    name \u003d kwargs[\u0027name\u0027]\n    del kwargs[\u0027name\u0027]\nelse:\n    name \u003d rand_name(cls.__name__ + \"-instance\")","commit_id":"250fb4ad98856bdd69c65bf5eeb69fc04a84fbb6"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"e104c88aba0ce3c887ce603b4b68f9e5f24ddf5b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\"Wrapper utility that returns a test server.\"\"\""},{"line_number":178,"context_line":"        name \u003d rand_name(cls.__name__ + \"-instance\")"},{"line_number":179,"context_line":"        if \u0027name\u0027 in kwargs:"},{"line_number":180,"context_line":"            name \u003d kwargs.pop(\u0027name\u0027)"},{"line_number":181,"context_line":"        flavor \u003d kwargs.get(\u0027flavor\u0027, cls.flavor_ref)"},{"line_number":182,"context_line":"        image_id \u003d kwargs.get(\u0027image_id\u0027, cls.image_ref)"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Blv4%3D","line":180,"updated":"2013-02-26 16:24:23.000000000","message":"Sean, could the if stmt be rewritten w/ an if/else as in my previous comment to avoid the 1st assignment of name when not necessary?\nThis is what happens when you got too much free time... :)","commit_id":"6ed7bdd9458ac8038b9d3286cc15f584cdc18555"}],"tempest/tests/compute/images/test_list_image_filters.py":[{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"cefada28c5892b3c2876b01f053e4ae214d520a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        resp, cls.server1 \u003d cls.create_server()"},{"line_number":34,"context_line":"        resp, cls.server2 \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":35,"context_line":"        # NOTE(sdague) this is faster than doing the sync wait_util on both"},{"line_number":36,"context_line":"        cls.servers_client.wait_for_server_status(cls.server1[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Create images to be used in the filter tests"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Bl2Q%3D","line":35,"updated":"2013-02-26 15:43:39.000000000","message":"question: is it meant to be wait_until?","commit_id":"250fb4ad98856bdd69c65bf5eeb69fc04a84fbb6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8430778865fb3647b9278dd6895c42da4721292d","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        resp, cls.server1 \u003d cls.create_server()"},{"line_number":34,"context_line":"        resp, cls.server2 \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":35,"context_line":"        # NOTE(sdague) this is faster than doing the sync wait_util on both"},{"line_number":36,"context_line":"        cls.servers_client.wait_for_server_status(cls.server1[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Create images to be used in the filter tests"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BlxQ%3D","line":35,"in_reply_to":"AAAAM3%2F%2Bl2Q%3D","updated":"2013-02-26 16:15:48.000000000","message":"yes, the logic is\ncreate 1\ncreate \u0026 wait 2\nwait 1","commit_id":"250fb4ad98856bdd69c65bf5eeb69fc04a84fbb6"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"e104c88aba0ce3c887ce603b4b68f9e5f24ddf5b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        resp, cls.server1 \u003d cls.create_server()"},{"line_number":34,"context_line":"        resp, cls.server2 \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":35,"context_line":"        # NOTE(sdague) this is faster than doing the sync wait_util on both"},{"line_number":36,"context_line":"        cls.servers_client.wait_for_server_status(cls.server1[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Create images to be used in the filter tests"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BlwU%3D","line":35,"updated":"2013-02-26 16:24:23.000000000","message":"Sean, I meant is wait_util a typo? Should it be wait_until?","commit_id":"6ed7bdd9458ac8038b9d3286cc15f584cdc18555"}]}