)]}'
{"tempest/tests/compute/servers/test_attach_interfaces.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3603104f330f43a9f7ca9be656f3c31711b2b508","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(AttachInterfacesTestJSON, self).setUp()"},{"line_number":44,"context_line":"        self.client \u003d self.os.interfaces_client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _check_interface(self, iface, port_id\u003dNone, network_id\u003dNone,"},{"line_number":47,"context_line":"                         fixed_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F%2FG8%3D","line":44,"updated":"2013-02-28 15:27:57.000000000","message":"Why is this in setUp and not setUpClass? I don\u0027t think it needs to be run before each test, running once for the class should be fine.","commit_id":"646030559e396d21e5a8ee4394ecd31ba5514a8f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"49264a47833479e4f6b3e7a7cb96cfc02859a757","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(AttachInterfacesTestJSON, self).setUp()"},{"line_number":44,"context_line":"        self.client \u003d self.os.interfaces_client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _check_interface(self, iface, port_id\u003dNone, network_id\u003dNone,"},{"line_number":47,"context_line":"                         fixed_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F%2FDg%3D","line":44,"in_reply_to":"AAAANH%2F%2F%2FEQ%3D","updated":"2013-02-28 16:02:58.000000000","message":"Well I\u0027m not sure which way is better for the testr way of doing things. Chris should know...\n\nI think that it would probably be fine one way or the other, all the initial setup in either setUp or setUpClass instead of splitting it between the 2. (unless there is an explicit need to do so)","commit_id":"646030559e396d21e5a8ee4394ecd31ba5514a8f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b36bdae25f794b61ce31246db40f692fca784684","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(AttachInterfacesTestJSON, self).setUp()"},{"line_number":44,"context_line":"        self.client \u003d self.os.interfaces_client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _check_interface(self, iface, port_id\u003dNone, network_id\u003dNone,"},{"line_number":47,"context_line":"                         fixed_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F%2FEQ%3D","line":44,"in_reply_to":"AAAANH%2F%2F%2FG8%3D","updated":"2013-02-28 15:52:25.000000000","message":"Because I copied it from some other test and was trying to mimic what I thought was convention.\n\nIsn\u0027t lifeless trying to get folks to avoid using setUpClass() going forward? I was surprised to find a lot of its use all over the place in tempest.\n\nRegardless, I\u0027ll change this for the next round.","commit_id":"646030559e396d21e5a8ee4394ecd31ba5514a8f"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"1341f217f915c1eb596e43713cbd701366b1244f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                                  iface[\u0027port_id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(iface, _iface)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_delete_interface(self):"},{"line_number":101,"context_line":"        server, iface \u003d self.test_create_interface()"},{"line_number":102,"context_line":"        resp, ifs \u003d self.client.list_interfaces(server[\u0027id\u0027])"},{"line_number":103,"context_line":"        self.client.delete_interface(server[\u0027id\u0027], iface[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F%2FPU%3D","line":100,"updated":"2013-02-28 12:32:12.000000000","message":"Would it be better to just have one test_create_show_delete testcase rather than 3 separate ones since it would cover all of the behavior?","commit_id":"646030559e396d21e5a8ee4394ecd31ba5514a8f"}]}