)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7c172af7be05e13472cd4193479f6f3aeadb50d2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    @test.idempotent_id(\u0027e19c0cc6-6720-4ed8-be83-b6603ed5c812\u0027)"},{"line_number":149,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled.live_migration or not"},{"line_number":150,"context_line":"                      CONF.compute_feature_enabled."},{"line_number":151,"context_line":"                      block_migration_for_live_migration,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":153,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":154,"context_line":"                      block_migrate_cinder_iscsi,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_4a99a31e","side":"PARENT","line":151,"updated":"2015-10-29 06:34:59.000000000","message":"We are not using the block_migration_for_live_migration flag anymore ? Why is that ?","commit_id":"f358a7e88f4b246cdde54f2b158147046877c60e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f90cab2166c47fd6ffecdb349f557be03d063fb5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    @test.idempotent_id(\u0027e19c0cc6-6720-4ed8-be83-b6603ed5c812\u0027)"},{"line_number":149,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled.live_migration or not"},{"line_number":150,"context_line":"                      CONF.compute_feature_enabled."},{"line_number":151,"context_line":"                      block_migration_for_live_migration,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":153,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":154,"context_line":"                      block_migrate_cinder_iscsi,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_95ffdca9","side":"PARENT","line":151,"in_reply_to":"1a26ad4f_4a99a31e","updated":"2015-10-29 06:56:41.000000000","message":"Ah, nice point.\nThe new code needs to check it also.","commit_id":"f358a7e88f4b246cdde54f2b158147046877c60e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6604385801f4797326448044e8fecc79f51f0169","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    @test.idempotent_id(\u0027e19c0cc6-6720-4ed8-be83-b6603ed5c812\u0027)"},{"line_number":149,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled.live_migration or not"},{"line_number":150,"context_line":"                      CONF.compute_feature_enabled."},{"line_number":151,"context_line":"                      block_migration_for_live_migration,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":153,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":154,"context_line":"                      block_migrate_cinder_iscsi,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_dfba37c0","side":"PARENT","line":151,"in_reply_to":"1a26ad4f_95ffdca9","updated":"2015-10-30 00:33:41.000000000","message":"I suppose that it\u0027s ambiguous here, as we check \u0027block_migrate_cinder_iscsi\u0027 here too, and this flag has more priority for this test","commit_id":"f358a7e88f4b246cdde54f2b158147046877c60e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4d61336a39c8006a6fcbfa68e16c4373ccd76ecb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    @test.idempotent_id(\u0027e19c0cc6-6720-4ed8-be83-b6603ed5c812\u0027)"},{"line_number":149,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled.live_migration or not"},{"line_number":150,"context_line":"                      CONF.compute_feature_enabled."},{"line_number":151,"context_line":"                      block_migration_for_live_migration,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":153,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":154,"context_line":"                      block_migrate_cinder_iscsi,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_a6c7db96","side":"PARENT","line":151,"in_reply_to":"1a26ad4f_b9f753f4","updated":"2015-11-11 13:41:56.000000000","message":"Done","commit_id":"f358a7e88f4b246cdde54f2b158147046877c60e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"549c45b78328ac88a377d78caf68967036ac6441","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    @test.idempotent_id(\u0027e19c0cc6-6720-4ed8-be83-b6603ed5c812\u0027)"},{"line_number":149,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled.live_migration or not"},{"line_number":150,"context_line":"                      CONF.compute_feature_enabled."},{"line_number":151,"context_line":"                      block_migration_for_live_migration,"},{"line_number":152,"context_line":"                      \u0027Block Live migration not available\u0027)"},{"line_number":153,"context_line":"    @testtools.skipIf(not CONF.compute_feature_enabled."},{"line_number":154,"context_line":"                      block_migrate_cinder_iscsi,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_b9f753f4","side":"PARENT","line":151,"in_reply_to":"1a26ad4f_dfba37c0","updated":"2015-10-30 03:26:44.000000000","message":"I think those are 2 different flags with different purposes. I am no expert in this area but I would be more confident to let the current code as is, i.e just move the CONF.compute_feature_enabled.live_migration check and leave the check on block_migration_for_live_migration as is.","commit_id":"f358a7e88f4b246cdde54f2b158147046877c60e"}]}