)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"31128171c155d208f0f7f6e7477a7d1a378182bf","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @test.idempotent_id(\u00270c0ef21e-96cb-4f54-9133-bbefd12ec50d\u0027)"},{"line_number":166,"context_line":"    def test_live_migration_with_swap(self):"},{"line_number":167,"context_line":"        server_id \u003d self._create_server("},{"line_number":168,"context_line":"            flavor\u003dself.flavor_with_swap[\u0027id\u0027])"},{"line_number":169,"context_line":"        self._test_live_migration(server_id)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_1875f0f8","line":167,"updated":"2016-02-05 19:50:36.000000000","message":"It doesn\u0027t look like _create_flavor_with_swap is ever called, so I don\u0027t see how this test would pass","commit_id":"4fcbe1dd369ee4130028d1dd812e9ba17e9c8474"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"dc8397fc49919f35c8040d8d45943010d7d5eda5","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @test.idempotent_id(\u00270c0ef21e-96cb-4f54-9133-bbefd12ec50d\u0027)"},{"line_number":166,"context_line":"    def test_live_migration_with_swap(self):"},{"line_number":167,"context_line":"        server_id \u003d self._create_server("},{"line_number":168,"context_line":"            flavor\u003dself.flavor_with_swap[\u0027id\u0027])"},{"line_number":169,"context_line":"        self._test_live_migration(server_id)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_cccc76bd","line":167,"in_reply_to":"5a5ae5dd_1875f0f8","updated":"2016-02-05 21:28:43.000000000","message":"Good catch, thanks!","commit_id":"4fcbe1dd369ee4130028d1dd812e9ba17e9c8474"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"256736cc273fe81fe2797ffc9733c83fff154ce4","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def _create_flavor_with_swap(cls):"},{"line_number":57,"context_line":"        cls.flavor_with_swap \u003d cls.os_adm.flavors_client.create_flavor("},{"line_number":58,"context_line":"            name\u003d\u0027nano_with_swap\u0027, ram\u003d64, vcpus\u003d1,"},{"line_number":59,"context_line":"            disk\u003d0, swap\u003d100, rxtx_factor\u003d1.0)[\u0027flavor\u0027]"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_6cfd2b6d","line":57,"updated":"2016-02-07 08:10:01.000000000","message":"You do not return any object here but looks like you need to because of line #169","commit_id":"c8008b96082d5cc28f6df51e65d7e789f6389646"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7a9ddd7aebbd9f9c92f79c91715eeaa35be6d182","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _create_flavor_with_swap(cls):"},{"line_number":57,"context_line":"        return cls.os_adm.flavors_client.create_flavor("},{"line_number":58,"context_line":"            name\u003d\u0027nano_with_swap\u0027, ram\u003d64, vcpus\u003d1,"},{"line_number":59,"context_line":"            disk\u003d0, swap\u003d100, rxtx_factor\u003d1.0)[\u0027flavor\u0027]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"},{"line_number":62,"context_line":"    def _get_compute_hostnames(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_2f7b497d","line":59,"updated":"2016-02-09 11:52:17.000000000","message":"there is no reason to do this in a private method, that just makes reading the tests harder later","commit_id":"511a74be3e99ca37849cc787faf0392f54474f21"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"75e66973c2c5835d48d84cff3280c7c536f48e7f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _create_flavor_with_swap(cls):"},{"line_number":57,"context_line":"        return cls.os_adm.flavors_client.create_flavor("},{"line_number":58,"context_line":"            name\u003d\u0027nano_with_swap\u0027, ram\u003d64, vcpus\u003d1,"},{"line_number":59,"context_line":"            disk\u003d0, swap\u003d100, rxtx_factor\u003d1.0)[\u0027flavor\u0027]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"},{"line_number":62,"context_line":"    def _get_compute_hostnames(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_173d422b","line":59,"in_reply_to":"5a5ae5dd_2f7b497d","updated":"2016-02-10 10:20:07.000000000","message":"Done","commit_id":"511a74be3e99ca37849cc787faf0392f54474f21"}]}
