)]}'
{"tempest/tests/compute/servers/test_multiple_create.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"a0572aa11cdf5b8c7db80981bceaa6a6e83f8fe9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return servers_created"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_multiple_create(self):"},{"line_number":62,"context_line":"        name \u003d rand_name()"},{"line_number":63,"context_line":"        resp, body \u003d self._multiple_servers_create(name\u003dname,"},{"line_number":64,"context_line":"                                                   min_count\u003d2,"},{"line_number":65,"context_line":"                                                   max_count\u003d4)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1lA%3D","line":62,"updated":"2013-03-10 05:10:50.000000000","message":"I think we should specify what the name start with (like multiple_test), not use the defualt \"test\". Because it\u0027s very important when run tempest with parallel option, it maybe cause the race issue.","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"15cf9e5e69e8289291d2dc06ef6478fb1143378f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return servers_created"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_multiple_create(self):"},{"line_number":62,"context_line":"        name \u003d rand_name()"},{"line_number":63,"context_line":"        resp, body \u003d self._multiple_servers_create(name\u003dname,"},{"line_number":64,"context_line":"                                                   min_count\u003d2,"},{"line_number":65,"context_line":"                                                   max_count\u003d4)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2Fzw0%3D","line":62,"in_reply_to":"AAAAN3%2F%2F1lA%3D","updated":"2013-03-11 20:49:50.000000000","message":"Done","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"a0572aa11cdf5b8c7db80981bceaa6a6e83f8fe9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # harmful to the performance"},{"line_number":70,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":71,"context_line":"        for server in self._get_created_servers(name):"},{"line_number":72,"context_line":"            self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":75,"context_line":"    def test_min_count_less_than_one(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1lE%3D","line":72,"updated":"2013-03-10 05:10:50.000000000","message":"If one server time out, the test will be failed? Should we prolong the build_timeout when we create multiple server? Just be curious about these things.","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"15cf9e5e69e8289291d2dc06ef6478fb1143378f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # harmful to the performance"},{"line_number":70,"context_line":"        self.assertEqual(\u0027202\u0027, resp[\u0027status\u0027])"},{"line_number":71,"context_line":"        for server in self._get_created_servers(name):"},{"line_number":72,"context_line":"            self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":75,"context_line":"    def test_min_count_less_than_one(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2Fzww%3D","line":72,"in_reply_to":"AAAAN3%2F%2F1lE%3D","updated":"2013-03-11 20:49:50.000000000","message":"I don\u0027t think so, the tests so far failed in error status, not due to timeout, so the build_timeout seems properly","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"a0572aa11cdf5b8c7db80981bceaa6a6e83f8fe9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          name\u003drand_name(), min_count\u003dinvalid_min_count)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":87,"context_line":"    def t1est_max_count_less_than_one(self):"},{"line_number":88,"context_line":"        invalid_max_count \u003d 0"},{"line_number":89,"context_line":"        self.assertRaises(exceptions.BadRequest, self._multiple_servers_create,"},{"line_number":90,"context_line":"                          name\u003drand_name(), max_count\u003dinvalid_max_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1js%3D","line":87,"updated":"2013-03-10 05:10:50.000000000","message":"typo?","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"15cf9e5e69e8289291d2dc06ef6478fb1143378f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          name\u003drand_name(), min_count\u003dinvalid_min_count)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":87,"context_line":"    def t1est_max_count_less_than_one(self):"},{"line_number":88,"context_line":"        invalid_max_count \u003d 0"},{"line_number":89,"context_line":"        self.assertRaises(exceptions.BadRequest, self._multiple_servers_create,"},{"line_number":90,"context_line":"                          name\u003drand_name(), max_count\u003dinvalid_max_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2Fzwk%3D","line":87,"in_reply_to":"AAAAN3%2F%2F1js%3D","updated":"2013-03-11 20:49:50.000000000","message":"my bad.. Done","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"a0572aa11cdf5b8c7db80981bceaa6a6e83f8fe9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                                   max_count\u003d4,"},{"line_number":111,"context_line":"                                                   reservation_id\u003dTrue)"},{"line_number":112,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":113,"context_line":"        self.assertTrue(\u0027reservation_id\u0027 in body)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class MultipleCreateTestXML(MultipleCreateTestJSON):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1jc%3D","line":113,"updated":"2013-03-10 05:10:50.000000000","message":"We check if reservation_id is in body at this test.So need we check it in test_multiple_create when the reservation_id\u003dFalse.","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"15cf9e5e69e8289291d2dc06ef6478fb1143378f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                                   max_count\u003d4,"},{"line_number":111,"context_line":"                                                   reservation_id\u003dTrue)"},{"line_number":112,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":113,"context_line":"        self.assertTrue(\u0027reservation_id\u0027 in body)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class MultipleCreateTestXML(MultipleCreateTestJSON):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2FzwU%3D","line":113,"in_reply_to":"AAAAN3%2F%2F1jc%3D","updated":"2013-03-11 20:49:50.000000000","message":"Done","commit_id":"a59ef989f073efcc0e4cd14f098d335e2d4e5bb1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyqs%3D","line":20,"updated":"2013-03-12 14:22:12.000000000","message":"unused import...","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fypc%3D","line":20,"in_reply_to":"AAAAN3%2F%2Fyqs%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":24,"context_line":"from tempest.common.utils.linux.remote_client import RemoteClient"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyqk%3D","line":21,"updated":"2013-03-12 14:22:12.000000000","message":"There should only be one space between the different import blocks.","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":24,"context_line":"from tempest.common.utils.linux.remote_client import RemoteClient"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FypY%3D","line":21,"in_reply_to":"AAAAN3%2F%2Fyqk%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":24,"context_line":"from tempest.common.utils.linux.remote_client import RemoteClient"},{"line_number":25,"context_line":"import tempest.config"},{"line_number":26,"context_line":"from tempest import exceptions"},{"line_number":27,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyqw%3D","line":24,"updated":"2013-03-12 14:22:12.000000000","message":"Unused import...","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":24,"context_line":"from tempest.common.utils.linux.remote_client import RemoteClient"},{"line_number":25,"context_line":"import tempest.config"},{"line_number":26,"context_line":"from tempest import exceptions"},{"line_number":27,"context_line":"from tempest.test import attr"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FypU%3D","line":24,"in_reply_to":"AAAAN3%2F%2Fyqw%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import tempest.config"},{"line_number":26,"context_line":"from tempest import exceptions"},{"line_number":27,"context_line":"from tempest.test import attr"},{"line_number":28,"context_line":"from tempest.tests import compute"},{"line_number":29,"context_line":"from tempest.tests.compute import base"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyq0%3D","line":28,"updated":"2013-03-12 14:22:12.000000000","message":"Unused import...","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import tempest.config"},{"line_number":26,"context_line":"from tempest import exceptions"},{"line_number":27,"context_line":"from tempest.test import attr"},{"line_number":28,"context_line":"from tempest.tests import compute"},{"line_number":29,"context_line":"from tempest.tests.compute import base"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FypQ%3D","line":28,"in_reply_to":"AAAAN3%2F%2Fyq0%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class MultipleCreateTestJSON(base.BaseComputeTest):"},{"line_number":33,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":34,"context_line":"    run_ssh \u003d tempest.config.TempestConfig().compute.run_ssh"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _multiple_servers_create(self, name\u003dNone,"},{"line_number":37,"context_line":"                                 min_count\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyr0%3D","line":34,"updated":"2013-03-12 14:22:12.000000000","message":"I don\u0027t think this line is needed, it doesn\u0027t seem to be used anywhere else.","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class MultipleCreateTestJSON(base.BaseComputeTest):"},{"line_number":33,"context_line":"    _interface \u003d \u0027json\u0027"},{"line_number":34,"context_line":"    run_ssh \u003d tempest.config.TempestConfig().compute.run_ssh"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _multiple_servers_create(self, name\u003dNone,"},{"line_number":37,"context_line":"                                 min_count\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FypA%3D","line":34,"in_reply_to":"AAAAN3%2F%2Fyr0%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                          max_count\u003dmax_count)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":112,"context_line":"        name \u003d rand_name()"},{"line_number":113,"context_line":"        resp, body \u003d self._multiple_servers_create(name\u003dname,"},{"line_number":114,"context_line":"                                                   min_count\u003d2,"},{"line_number":115,"context_line":"                                                   max_count\u003d4,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyrQ%3D","line":112,"updated":"2013-03-12 14:22:12.000000000","message":"Do you need this, won\u0027t self.create_server specify a random name by default?","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                          max_count\u003dmax_count)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":112,"context_line":"        name \u003d rand_name()"},{"line_number":113,"context_line":"        resp, body \u003d self._multiple_servers_create(name\u003dname,"},{"line_number":114,"context_line":"                                                   min_count\u003d2,"},{"line_number":115,"context_line":"                                                   max_count\u003d4,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyW0%3D","line":112,"in_reply_to":"AAAAN3%2F%2FyrQ%3D","updated":"2013-03-12 16:56:56.000000000","message":"Done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df2e9739832ee9761e438e91e69744b4343cdd2a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                                   max_count\u003d4,"},{"line_number":116,"context_line":"                                                   reservation_id\u003dTrue)"},{"line_number":117,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":118,"context_line":"        self.assertTrue(\u0027reservation_id\u0027 in body)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class MultipleCreateTestXML(MultipleCreateTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyrY%3D","line":118,"updated":"2013-03-12 14:22:12.000000000","message":"Why not use self.assertIn here?","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"3780b826c4265cc95c004100295bf7b969a1c008","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                                   max_count\u003d4,"},{"line_number":116,"context_line":"                                                   reservation_id\u003dTrue)"},{"line_number":117,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":118,"context_line":"        self.assertTrue(\u0027reservation_id\u0027 in body)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class MultipleCreateTestXML(MultipleCreateTestJSON):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Fyo4%3D","line":118,"in_reply_to":"AAAAN3%2F%2FyrY%3D","updated":"2013-03-12 16:56:56.000000000","message":"dont think it made any difference.. but done","commit_id":"30b218fad9dc55157d32e8696e0e4f3df865e06c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46aeee1cb0a5458eae1b62cdeeeea43e5f411195","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        name \u003d rand_name(\u0027multiple-create-test\u0027)"},{"line_number":39,"context_line":"        resp, body \u003d self.create_server(name\u003dname,"},{"line_number":40,"context_line":"                                        min_count\u003d2,"},{"line_number":41,"context_line":"                                        max_count\u003d4)"},{"line_number":42,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":43,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":44,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F1PU%3D","line":41,"updated":"2013-03-25 19:58:35.000000000","message":"Can we use max_count 2 (or 3) ?","commit_id":"2e0c340f9e2d17fa55a78283ab00a46f9126f53d"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"f7fe44fb512233b27445715b84260a2151153855","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        name \u003d rand_name(\u0027multiple-create-test\u0027)"},{"line_number":39,"context_line":"        resp, body \u003d self.create_server(name\u003dname,"},{"line_number":40,"context_line":"                                        min_count\u003d2,"},{"line_number":41,"context_line":"                                        max_count\u003d4)"},{"line_number":42,"context_line":"        # NOTE(maurosr): do status response check and also make sure that"},{"line_number":43,"context_line":"        # reservation_id is not in the response body when the request send"},{"line_number":44,"context_line":"        # contains return_reservation_id\u003dFalse"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F0Mo%3D","line":41,"in_reply_to":"AAAAOH%2F%2F1PU%3D","updated":"2013-03-26 14:27:20.000000000","message":"sure","commit_id":"2e0c340f9e2d17fa55a78283ab00a46f9126f53d"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46aeee1cb0a5458eae1b62cdeeeea43e5f411195","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":88,"context_line":"        resp, body \u003d self.create_server(min_count\u003d2,"},{"line_number":89,"context_line":"                                        max_count\u003d4,"},{"line_number":90,"context_line":"                                        return_reservation_id\u003dTrue)"},{"line_number":91,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":92,"context_line":"        self.assertIn(\u0027reservation_id\u0027, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F1Po%3D","line":89,"updated":"2013-03-25 19:58:35.000000000","message":"Can we use max_count 2 (or 3) ?","commit_id":"2e0c340f9e2d17fa55a78283ab00a46f9126f53d"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"f7fe44fb512233b27445715b84260a2151153855","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":88,"context_line":"        resp, body \u003d self.create_server(min_count\u003d2,"},{"line_number":89,"context_line":"                                        max_count\u003d4,"},{"line_number":90,"context_line":"                                        return_reservation_id\u003dTrue)"},{"line_number":91,"context_line":"        self.assertTrue(resp[\u0027status\u0027], 202)"},{"line_number":92,"context_line":"        self.assertIn(\u0027reservation_id\u0027, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F0Ms%3D","line":89,"in_reply_to":"AAAAOH%2F%2F1Po%3D","updated":"2013-03-26 14:27:20.000000000","message":"sure","commit_id":"2e0c340f9e2d17fa55a78283ab00a46f9126f53d"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"17fcb9e5a3ee18066b30ef4506103039412c2e9c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                servers_created.append(server)"},{"line_number":35,"context_line":"        return servers_created"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_multiple_create(self):"},{"line_number":38,"context_line":"        name \u003d rand_name(\u0027multiple-create-test\u0027)"},{"line_number":39,"context_line":"        resp, body \u003d self.create_server(name\u003dname,"},{"line_number":40,"context_line":"                                        min_count\u003d1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2Fs9g%3D","line":37,"updated":"2013-04-02 12:26:12.000000000","message":"Perhaps add positive attr for function?","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"34b73d02e00f962dc08296d55a2d2b9e9ef41fa2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                servers_created.append(server)"},{"line_number":35,"context_line":"        return servers_created"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_multiple_create(self):"},{"line_number":38,"context_line":"        name \u003d rand_name(\u0027multiple-create-test\u0027)"},{"line_number":39,"context_line":"        resp, body \u003d self.create_server(name\u003dname,"},{"line_number":40,"context_line":"                                        min_count\u003d1,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2FsTM%3D","line":37,"in_reply_to":"AAAAOH%2F%2Fs9g%3D","updated":"2013-04-02 20:36:26.000000000","message":"Done","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"17fcb9e5a3ee18066b30ef4506103039412c2e9c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # NOTE(maurosr): get a server list, check status of the ones with names"},{"line_number":49,"context_line":"        # that match and wait for them become active. At a first look, since"},{"line_number":50,"context_line":"        # they are buiding in parallel, wait inside the for doesn\u0027t seem be"},{"line_number":51,"context_line":"        # harmful to the performance"},{"line_number":52,"context_line":"        for server in self._get_created_servers(name):"},{"line_number":53,"context_line":"            self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2Fs9Y%3D","line":50,"updated":"2013-04-02 12:26:12.000000000","message":"very minor nit: buiding -\u003e building","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"34b73d02e00f962dc08296d55a2d2b9e9ef41fa2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # NOTE(maurosr): get a server list, check status of the ones with names"},{"line_number":49,"context_line":"        # that match and wait for them become active. At a first look, since"},{"line_number":50,"context_line":"        # they are buiding in parallel, wait inside the for doesn\u0027t seem be"},{"line_number":51,"context_line":"        # harmful to the performance"},{"line_number":52,"context_line":"        for server in self._get_created_servers(name):"},{"line_number":53,"context_line":"            self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2FsTI%3D","line":50,"in_reply_to":"AAAAOH%2F%2Fs9Y%3D","updated":"2013-04-02 20:36:26.000000000","message":"Done","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"17fcb9e5a3ee18066b30ef4506103039412c2e9c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          min_count\u003dmin_count,"},{"line_number":85,"context_line":"                          max_count\u003dmax_count)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":88,"context_line":"        resp, body \u003d self.create_server(min_count\u003d1,"},{"line_number":89,"context_line":"                                        max_count\u003d2,"},{"line_number":90,"context_line":"                                        return_reservation_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2Fs9c%3D","line":87,"updated":"2013-04-02 12:26:12.000000000","message":"perhaps add positive attr for function?","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"34b73d02e00f962dc08296d55a2d2b9e9ef41fa2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          min_count\u003dmin_count,"},{"line_number":85,"context_line":"                          max_count\u003dmax_count)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_multiple_create_with_reservation_return(self):"},{"line_number":88,"context_line":"        resp, body \u003d self.create_server(min_count\u003d1,"},{"line_number":89,"context_line":"                                        max_count\u003d2,"},{"line_number":90,"context_line":"                                        return_reservation_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2FsTE%3D","line":87,"in_reply_to":"AAAAOH%2F%2Fs9c%3D","updated":"2013-04-02 20:36:26.000000000","message":"Done","commit_id":"287341b4c69f6516940fc88d7a60f1fd3ec60ad4"}]}