)]}'
{"tempest/api/volume/admin/test_backup_encrypted_volume.py":[{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"0a493d7940e708b49c7147532954ebab4739526c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        cls.volume_types_client.delete_volume_type("},{"line_number":62,"context_line":"            cls.body[\u0027volume_type\u0027][\u0027id\u0027])"},{"line_number":63,"context_line":"        cls.volumes_client.delete_volume(cls.vol_size,"},{"line_number":64,"context_line":"                                         volume_type\u003dcls.vol_type_name)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def _delete_backup(self, backup_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_5f1de764","line":64,"updated":"2015-10-27 05:38:09.000000000","message":"it should be \ncls.volumes_client.delete_volume(cls.volume[\u0027volume\u0027][\u0027id\u0027])\nbecause delete_volume only expect volume id.","commit_id":"42e6ac7586383ba8dc0fc784494502c68249a6e9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"894287b84160b2f45c47536bcefd62705dade83f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(VolumesBackupEncryptionV2Test, cls).resource_setup()"},{"line_number":43,"context_line":"        # Create Volume Type"},{"line_number":44,"context_line":"        cls.vol_type_name \u003d data_utils.rand_name(\u0027volume-type\u0027)"},{"line_number":45,"context_line":"        cls.body \u003d cls.volume_types_client.create_volume_type("},{"line_number":46,"context_line":"            cls.vol_type_name)"},{"line_number":47,"context_line":"        # Create Encryption Type Name"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_c4cab26e","line":44,"updated":"2015-11-30 17:14:28.000000000","message":"You don\u0027t need a class variable here. A local variable is enough.","commit_id":"e2daefcbcf8a474ac68e1ef25f04f5f7e391f73a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"894287b84160b2f45c47536bcefd62705dade83f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(VolumesBackupEncryptionV2Test, cls).resource_setup()"},{"line_number":43,"context_line":"        # Create Volume Type"},{"line_number":44,"context_line":"        cls.vol_type_name \u003d data_utils.rand_name(\u0027volume-type\u0027)"},{"line_number":45,"context_line":"        cls.body \u003d cls.volume_types_client.create_volume_type("},{"line_number":46,"context_line":"            cls.vol_type_name)"},{"line_number":47,"context_line":"        # Create Encryption Type Name"},{"line_number":48,"context_line":"        cls.encryption_type \u003d cls.volume_types_client.create_encryption_type("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_84c4aa5f","line":45,"updated":"2015-11-30 17:14:28.000000000","message":"This variable has a too generic name.","commit_id":"e2daefcbcf8a474ac68e1ef25f04f5f7e391f73a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"894287b84160b2f45c47536bcefd62705dade83f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            key_size\u003d512, cipher\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":52,"context_line":"            control_location\u003d\u0027front-end\u0027)"},{"line_number":53,"context_line":"        # Create Encrypted Volume"},{"line_number":54,"context_line":"        cls.vol_size \u003d 1"},{"line_number":55,"context_line":"        cls.volume \u003d cls.create_volume(cls.vol_size,"},{"line_number":56,"context_line":"                                       volume_type\u003dcls.vol_type_name)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_045bda2f","line":54,"updated":"2015-11-30 17:14:28.000000000","message":"You don\u0027t need a class variable here. In fact you don\u0027t need a variable at all. If you really want to use a variable here have a look at CONF.volume.volume_size","commit_id":"e2daefcbcf8a474ac68e1ef25f04f5f7e391f73a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ebffa53d11e55ee945755c7f8cb5f109f0a2482b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_3e97983b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":17},"updated":"2016-02-05 06:40:24.000000000","message":"2016?","commit_id":"02fe02fed5a8353be03a45c461ef19a11467f97c"},{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"61af3930588afbda20458e4d24a14081eb808344","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_3ecf982a","line":1,"updated":"2016-02-05 06:44:53.000000000","message":"Add  (c)  after Copyright.","commit_id":"02fe02fed5a8353be03a45c461ef19a11467f97c"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ebffa53d11e55ee945755c7f8cb5f109f0a2482b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    * Create Encrypted Volume"},{"line_number":28,"context_line":"    * Create Backup for Encrypted volume"},{"line_number":29,"context_line":"    * Show details of Created  Backup"},{"line_number":30,"context_line":"    * Delete backup"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_7e14309f","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":31},"updated":"2016-02-05 06:40:24.000000000","message":"one more blank here.","commit_id":"02fe02fed5a8353be03a45c461ef19a11467f97c"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ebffa53d11e55ee945755c7f8cb5f109f0a2482b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.backups_adm_client.wait_for_backup_deletion(backup_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.idempotent_id(\u00277fe61ea9-e3ab-454f-a1c9-afa2a4280ddf\u0027)"},{"line_number":71,"context_line":"    def test_create_show_delete_backupencrypted_volume(self):"},{"line_number":72,"context_line":"        # Create backup of encrypted volume"},{"line_number":73,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":74,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_dea8c479","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":47},"updated":"2016-02-05 06:40:24.000000000","message":"backup_encrypted_volume","commit_id":"02fe02fed5a8353be03a45c461ef19a11467f97c"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ebffa53d11e55ee945755c7f8cb5f109f0a2482b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":82,"context_line":"                                                       \u0027available\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # Show details of created  backup"},{"line_number":85,"context_line":"        backup \u003d self.backups_adm_client.show_backup(backup[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":86,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_fed34002","line":84,"range":{"start_line":84,"start_character":33,"end_line":84,"end_character":35},"updated":"2016-02-05 06:40:24.000000000","message":"one more blank here.","commit_id":"02fe02fed5a8353be03a45c461ef19a11467f97c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"138e19e132b828dc22a827c0f0a144172acf5a87","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            key_size\u003d512, cipher\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":52,"context_line":"            control_location\u003d\u0027front-end\u0027)"},{"line_number":53,"context_line":"        # Create Encrypted Volume"},{"line_number":54,"context_line":"        cls.volume \u003d cls.create_volume(size\u003dCONF.volume.volume_size,"},{"line_number":55,"context_line":"                                       display_name\u003dvol_type_name)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_4752b4de","line":55,"range":{"start_line":54,"start_character":21,"end_line":55,"end_character":66},"updated":"2017-01-04 03:22:31.000000000","message":"I don\u0027t understand why is this volume an \"Encrypted Volume\", it seems no relationship with cls.encryption_type","commit_id":"12c15abbd8e69b504823c565c902a92715c3284c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"138e19e132b828dc22a827c0f0a144172acf5a87","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.backups_adm_client.wait_for_backup_deletion(backup_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.idempotent_id(\u00277fe61ea9-e3ab-454f-a1c9-afa2a4280ddf\u0027)"},{"line_number":71,"context_line":"    def test_create_show_delete_backup_encrypted_volume(self):"},{"line_number":72,"context_line":"        # Create backup of encrypted volume"},{"line_number":73,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":74,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_c7af8492","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":31},"updated":"2017-01-04 03:22:31.000000000","message":"If you want to test \"delete\" operation, you should do delete in test steps, for delete failure in cleanup won\u0027t result in testcase failure.","commit_id":"12c15abbd8e69b504823c565c902a92715c3284c"}],"tempest/api/volume/v2/test_backup_encrypted_volume.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"adfd75aba9ae4a529d5fb3fb7ab88db8835f71ac","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumesBackupEncryptionV2Test(base.BaseVolumeAdminTest):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    Test to include Backup Support for Encrypted Volume"},{"line_number":27,"context_line":"    * Create Encrypted Volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_35f9064e","line":24,"updated":"2015-10-20 13:36:02.000000000","message":"If you inherit from BaseVolumeAdminTest this file should be put in api/volume/admin.","commit_id":"3b71de300db38631b95e862823f339e42756327a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"adfd75aba9ae4a529d5fb3fb7ab88db8835f71ac","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def resource_setup(cls):"},{"line_number":41,"context_line":"        super(VolumesBackupEncryptionV2Test, cls).resource_setup()"},{"line_number":42,"context_line":"        # Volume Encryption Type Details"},{"line_number":43,"context_line":"        cls.provider \u003d \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027"},{"line_number":44,"context_line":"        cls.key_size \u003d 512"},{"line_number":45,"context_line":"        cls.control_location \u003d \u0027front-end\u0027"},{"line_number":46,"context_line":"        cls.cipher \u003d \u0027aes-xts-plain64\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_154baaca","line":43,"updated":"2015-10-20 13:36:02.000000000","message":"You don\u0027t need to declare a new variable for \u0027provider\u0027, key_size, control_location and cipher because you are using the value only once.","commit_id":"3b71de300db38631b95e862823f339e42756327a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"adfd75aba9ae4a529d5fb3fb7ab88db8835f71ac","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls.vol_type_name)"},{"line_number":51,"context_line":"        # Create Encryption Type Name"},{"line_number":52,"context_line":"        cls.encryption_type \u003d cls.volume_types_client.create_encryption_type("},{"line_number":53,"context_line":"            cls.body[\u0027volume_type\u0027][\u0027id\u0027], provider\u003dcls.provider,"},{"line_number":54,"context_line":"            key_size\u003dcls.key_size, cipher\u003dcls.cipher,"},{"line_number":55,"context_line":"            control_location\u003dcls.control_location)"},{"line_number":56,"context_line":"        # Create Encrypted Volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f564ee49","line":53,"updated":"2015-10-20 13:36:02.000000000","message":"Inline the value for provider, key_size, control_location and cipher","commit_id":"3b71de300db38631b95e862823f339e42756327a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"adfd75aba9ae4a529d5fb3fb7ab88db8835f71ac","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            control_location\u003dcls.control_location)"},{"line_number":56,"context_line":"        # Create Encrypted Volume"},{"line_number":57,"context_line":"        cls.vol_size \u003d 1"},{"line_number":58,"context_line":"        cls.volume \u003d cls.create_volume(cls.vol_size,"},{"line_number":59,"context_line":"                                       volume_type\u003dcls.vol_type_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_7551be61","line":58,"updated":"2015-10-20 13:36:02.000000000","message":"This volume is not cleaned up.","commit_id":"3b71de300db38631b95e862823f339e42756327a"}]}