)]}'
{"tempest/api/compute/images/test_image_metadata.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b0b00069c44a8407a11d50530842c31c17f4745c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":"        elif not CONF.image.image_upload_allowed:"},{"line_number":36,"context_line":"            skip_msg \u003d \\"},{"line_number":37,"context_line":"                (\"%s Non admin user not allowed to update image.\""},{"line_number":38,"context_line":"                 % cls.__name__)"},{"line_number":39,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_41eebced","line":37,"updated":"2015-11-03 12:02:25.000000000","message":"This message could be clearer. \n\nI suggest (\"%s skipped because non admin users are not allowed to update image.\")","commit_id":"9db9297d130f46419bd1921806038fe4b2d88475"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":35,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":36,"context_line":"            skip_msg \u003d \\"},{"line_number":37,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":38,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":39,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_524cb0c7","line":37,"updated":"2015-11-06 16:26:39.000000000","message":"\"non admin\" should be \"non-admin\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":36,"context_line":"            skip_msg \u003d \\"},{"line_number":37,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":38,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":39,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_12c94826","line":38,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/api/compute/images/test_list_image_filters.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":41,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":42,"context_line":"            skip_msg \u003d \\"},{"line_number":43,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":44,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":45,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_ed594536","line":43,"updated":"2015-11-06 16:26:39.000000000","message":"\"non admin\" should be \"non-admin\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":42,"context_line":"            skip_msg \u003d \\"},{"line_number":43,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":44,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":45,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d2ce602c","line":44,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/api/compute/test_authorization.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            raise cls.skipException(\u0027Glance is not available.\u0027)"},{"line_number":40,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":41,"context_line":"            skip_msg \u003d \\"},{"line_number":42,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":43,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":44,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_cd6b21b8","line":42,"updated":"2015-11-06 16:26:39.000000000","message":"\"non admin\" should be \"non-admin\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        elif not CONF.image_feature_enabled.upload_image:"},{"line_number":41,"context_line":"            skip_msg \u003d \\"},{"line_number":42,"context_line":"                (\"%s skipped because non admin users are not allowed to\""},{"line_number":43,"context_line":"                 \"update image.\" % cls.__name__)"},{"line_number":44,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_92dd38e2","line":43,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/api/image/v1/test_images.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b0b00069c44a8407a11d50530842c31c17f4745c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"Here we test the registration and creation of images.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @test.idempotent_id(\u00273027f8e6-3492-4a11-8575-c3293017af4d\u0027)"},{"line_number":32,"context_line":"    @testtools.skipIf(not CONF.image.image_upload_allowed,"},{"line_number":33,"context_line":"                      \"Non admin user not allowed to update image.\")"},{"line_number":34,"context_line":"    def test_register_then_upload(self):"},{"line_number":35,"context_line":"        # Register, then upload an image"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_01bf54d1","line":32,"updated":"2015-11-03 12:02:25.000000000","message":"Use the skipUnless decorator.","commit_id":"9db9297d130f46419bd1921806038fe4b2d88475"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @test.idempotent_id(\u00273027f8e6-3492-4a11-8575-c3293017af4d\u0027)"},{"line_number":32,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":33,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":34,"context_line":"                          \"update image.\")"},{"line_number":35,"context_line":"    def test_register_then_upload(self):"},{"line_number":36,"context_line":"        # Register, then upload an image"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d26ae0ec","line":33,"updated":"2015-11-06 16:26:39.000000000","message":"\"Non admin\" should be \"Non-admin\".\n\nYou also need a space after \"to\" so that there will be proper spacing when this string is built","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @test.idempotent_id(\u00273027f8e6-3492-4a11-8575-c3293017af4d\u0027)"},{"line_number":32,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":33,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":34,"context_line":"                          \"update image.\")"},{"line_number":35,"context_line":"    def test_register_then_upload(self):"},{"line_number":36,"context_line":"        # Register, then upload an image"},{"line_number":37,"context_line":"        properties \u003d {\u0027prop1\u0027: \u0027val1\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_0d9da9bb","line":34,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @test.idempotent_id(\u0027d6d7649c-08ce-440d-9ea7-e3dda552f33c\u0027)"},{"line_number":271,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":272,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":273,"context_line":"                          \"update image.\")"},{"line_number":274,"context_line":"    def test_update_image_metadata(self):"},{"line_number":275,"context_line":"        # The metadata for the image should match the updated values"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_727c54b5","line":272,"updated":"2015-11-06 16:26:39.000000000","message":"\"Non admin\" should be \"Non-admin\".\n\nYou also need a space after \"to\" so that there will be proper spacing when this string is built","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    @test.idempotent_id(\u0027d6d7649c-08ce-440d-9ea7-e3dda552f33c\u0027)"},{"line_number":271,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":272,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":273,"context_line":"                          \"update image.\")"},{"line_number":274,"context_line":"    def test_update_image_metadata(self):"},{"line_number":275,"context_line":"        # The metadata for the image should match the updated values"},{"line_number":276,"context_line":"        req_metadata \u003d {\u0027key1\u0027: \u0027alt1\u0027, \u0027key2\u0027: \u0027value2\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_4db7313a","line":273,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":106,"context_line":"    @test.idempotent_id(\u0027f66891a7-a35c-41a8-b590-a065c2a1caa6\u0027)"},{"line_number":107,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":108,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":109,"context_line":"                          \"update image.\")"},{"line_number":110,"context_line":"    def test_update_image(self):"},{"line_number":111,"context_line":"        # Updates an image by image_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_f246047a","line":108,"updated":"2015-11-06 16:26:39.000000000","message":"\"Non admin\" should be \"Non-admin\".\n\nYou also need a space after \"to\" so that there will be proper spacing when this string is built","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    @test.idempotent_id(\u0027f66891a7-a35c-41a8-b590-a065c2a1caa6\u0027)"},{"line_number":107,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":108,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":109,"context_line":"                          \"update image.\")"},{"line_number":110,"context_line":"    def test_update_image(self):"},{"line_number":111,"context_line":"        # Updates an image by image_id"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2d898d75","line":109,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/api/telemetry/test_telemetry_notification_api.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @testtools.skipIf(not CONF.image_feature_enabled.api_v1,"},{"line_number":40,"context_line":"                      \"Glance api v1 is disabled\")"},{"line_number":41,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":42,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":43,"context_line":"                          \"update image.\")"},{"line_number":44,"context_line":"    def test_check_glance_v1_notifications(self):"},{"line_number":45,"context_line":"        body \u003d self.create_image(self.image_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_922778c9","line":42,"updated":"2015-11-06 16:26:39.000000000","message":"\"Non admin\" should be \"Non-admin\"\n\nYou also need a space after \"to\" so that there will be proper spacing when this string is built","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                      \"Glance api v1 is disabled\")"},{"line_number":41,"context_line":"    @testtools.skipUnless(CONF.image_feature_enabled.upload_image,"},{"line_number":42,"context_line":"                          \"Non admin users are not allowed to\""},{"line_number":43,"context_line":"                          \"update image.\")"},{"line_number":44,"context_line":"    def test_check_glance_v1_notifications(self):"},{"line_number":45,"context_line":"        body \u003d self.create_image(self.image_client)"},{"line_number":46,"context_line":"        self.image_client.update_image(body[\u0027id\u0027], data\u003d\u0027data\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_ed7e2569","line":43,"updated":"2015-11-06 16:26:39.000000000","message":"\"update image\" should be \"upload images\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}],"tempest/config.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b0b00069c44a8407a11d50530842c31c17f4745c","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                    \"checks.\"),"},{"line_number":487,"context_line":"    cfg.BoolOpt(\u0027image_upload_allowed\u0027,"},{"line_number":488,"context_line":"                default\u003dTrue,"},{"line_number":489,"context_line":"                help\u003d\"Does Non admin user have permission for\""},{"line_number":490,"context_line":"                     \"image upload in glance.\"),"},{"line_number":491,"context_line":"    cfg.ListOpt(\u0027container_formats\u0027,"},{"line_number":492,"context_line":"                default\u003d[\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027bare\u0027, \u0027ovf\u0027, \u0027ova\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_210378ba","line":489,"updated":"2015-11-03 12:02:25.000000000","message":"s/have permission for/have permission to/\n\ns/Non admin/non admin/","commit_id":"9db9297d130f46419bd1921806038fe4b2d88475"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d53e0e7d44d9a6d2745a6f3874a2438fd5d7bef6","unresolved":false,"context_lines":[{"line_number":484,"context_line":"               default\u003d1,"},{"line_number":485,"context_line":"               help\u003d\"Time in seconds between image operation status \""},{"line_number":486,"context_line":"                    \"checks.\"),"},{"line_number":487,"context_line":"    cfg.BoolOpt(\u0027image_upload_allowed\u0027,"},{"line_number":488,"context_line":"                default\u003dTrue,"},{"line_number":489,"context_line":"                help\u003d\"Does non admin user have permission for\""},{"line_number":490,"context_line":"                     \"image upload in glance.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_a9bb75e4","line":487,"updated":"2015-11-05 10:35:07.000000000","message":"\"Image upload\" is a feature, thus this option should be in the \"image_feature_group\" group. Then I would rename this option just \u0027upload_image\u0027. So you would access this value with CONF.image_feature_enabled.upload_image","commit_id":"f9b49c326b6ac2502300def9da17f01450a96293"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"d6b76882f3a8456c05aabdaf1f06398a419e4ecb","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                     \" The feature has been integrated since Kilo.\"),"},{"line_number":512,"context_line":"    cfg.BoolOpt(\u0027upload_image\u0027,"},{"line_number":513,"context_line":"                default\u003dTrue,"},{"line_number":514,"context_line":"                help\u003d\"Does non admin user have permission for\""},{"line_number":515,"context_line":"                     \"image upload in glance.\"),"},{"line_number":516,"context_line":"]"},{"line_number":517,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_cd06c11b","line":514,"updated":"2015-11-06 16:26:39.000000000","message":"\"non admin\" should be \"non-admin\"","commit_id":"42775ff358d93dcd8ef2c45d9adee6deb9015656"}]}