)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"46913795213032d9ffe9e7f7a03a6f0c94f0c126","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Policies Negative Test cases for V3 version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following Negative test case added:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. create policy with invalid policy type."},{"line_number":12,"context_line":"2. delete non-existent policy."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_a48632d9","line":9,"updated":"2015-12-10 21:49:14.000000000","message":"case -\u003e cases","commit_id":"604a201af1a0b1ffc9ca3d22581a6a53c1dec65e"}],"tempest/api/identity/admin/v3/test_policies_negative.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"011cdfc1ade827844bc05614c50625160703690e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.api.identity import base"},{"line_number":19,"context_line":"from tempest.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":"from tempest_lib import exceptions as lib_exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8a610cd6","line":18,"updated":"2015-11-30 19:42:23.000000000","message":"The import order should be the following:\n\n    \u003csystem libraries\u003e\n\n    \u003cthird-party libraries\u003e\n\n    \u003clocal imports\u003e\n\n    import uuid\n\n    from tempest_lib import exceptions as lib_exc\n\n    from tempest.api.identity import base\n    from tempest.common.utils import data_utils\n    from tempest import test","commit_id":"cd4b5f6048823573cbfe49909215842b71b732c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"011cdfc1ade827844bc05614c50625160703690e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PoliciesNegativeTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":25,"context_line":"    \"\"\"Here we have negative tests for"},{"line_number":26,"context_line":"        * create policy with invalid policy type."},{"line_number":27,"context_line":"        * delete non-existent policy."},{"line_number":28,"context_line":"        * show non-existent policy."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ead9b884","line":25,"updated":"2015-11-30 19:42:23.000000000","message":"PEP8 will fail in this doc string if you rebase the patch.","commit_id":"cd4b5f6048823573cbfe49909215842b71b732c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"011cdfc1ade827844bc05614c50625160703690e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        blob \u003d data_utils.rand_name(\u0027BlobName\u0027)"},{"line_number":38,"context_line":"        policy_type \u003d 1234"},{"line_number":39,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":40,"context_line":"                          self.policy_client.create_policy,"},{"line_number":41,"context_line":"                          blob, policy_type)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6abe28d6","line":40,"updated":"2015-11-30 19:42:23.000000000","message":"Now it should be\n \n    self.assertRaises(lib_exc.BadRequest, \n                      self.policy_client.create_policy, \n                      blob\u003dblob, policy_type\u003dpolicy_type)\n\nSee https://review.openstack.org/#/c/244091/","commit_id":"cd4b5f6048823573cbfe49909215842b71b732c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"46913795213032d9ffe9e7f7a03a6f0c94f0c126","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a4a872dc","line":16,"updated":"2015-12-10 21:49:14.000000000","message":"Wrong import order. It should be\n\n    import uuid\n    \n    from tempest_lib import exceptions as lib_exc\n\n    from tempest.api.identity import base\n    from tempest.common.utils import data_utils\n    from tempest import test","commit_id":"604a201af1a0b1ffc9ca3d22581a6a53c1dec65e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"46913795213032d9ffe9e7f7a03a6f0c94f0c126","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class PoliciesNegativeTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":27,"context_line":"    \"\"\"Here we have negative tests for"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        * create policy with invalid policy type."},{"line_number":30,"context_line":"        * delete non-existent policy."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a412b207","line":27,"updated":"2015-12-10 21:49:14.000000000","message":"I believe it should be something like this\n\n    The test class contains the following negative test cases:","commit_id":"604a201af1a0b1ffc9ca3d22581a6a53c1dec65e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"46913795213032d9ffe9e7f7a03a6f0c94f0c126","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        * update non-existent policy."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    non_existent_id \u003d str(uuid.uuid4())"},{"line_number":35,"context_line":"    type_updated \u003d data_utils.rand_name(\u0027UpdatedPolicyType\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":38,"context_line":"    @test.idempotent_id(\u0027ac6c137e-4d3d-448f-8c83-4f13d0933651\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_241c82c0","line":35,"updated":"2015-12-10 21:49:14.000000000","message":"type_updated is used only once. Maybe it is worth moving it to the test_update_non_existent_policy test.","commit_id":"604a201af1a0b1ffc9ca3d22581a6a53c1dec65e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"46913795213032d9ffe9e7f7a03a6f0c94f0c126","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @test.idempotent_id(\u0027ac6c137e-4d3d-448f-8c83-4f13d0933651\u0027)"},{"line_number":39,"context_line":"    def test_create_policy_with_invalid_type(self):"},{"line_number":40,"context_line":"        blob \u003d data_utils.rand_name(\u0027BlobName\u0027)"},{"line_number":41,"context_line":"        policy_type \u003d 1234"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":43,"context_line":"                          self.policy_client.create_policy,"},{"line_number":44,"context_line":"                          blob\u003dblob, type\u003dpolicy_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_84b0d6de","line":41,"updated":"2015-12-10 21:49:14.000000000","message":"I think it will be better to use here data_utils.rand_name(...).","commit_id":"604a201af1a0b1ffc9ca3d22581a6a53c1dec65e"}]}