)]}'
{"tempest/api/identity/admin/v3/test_regions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e00c74f37a8b0d0fa49a9e7c86986f5b05e377c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        r_region_id \u003d data_utils.rand_uuid()"},{"line_number":81,"context_line":"        r_description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":82,"context_line":"        region \u003d self.client.create_region("},{"line_number":83,"context_line":"            description\u003dr_description, region_id\u003dr_region_id)[\u0027region\u0027]"},{"line_number":84,"context_line":"        self.addCleanup(self._delete_region, region[\u0027id\u0027])"},{"line_number":85,"context_line":"        # Asserting Create Region with specific id response body"},{"line_number":86,"context_line":"        self.assertEqual(r_region_id, region[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_2dc6f216","line":83,"updated":"2015-11-13 10:55:49.000000000","message":"could you change the order like:\n\n region_id\u003dr_region_id, description\u003dr_description)[\u0027region\u0027]\n\nfor fitting the order of client side ?","commit_id":"1d1d15b23bb20ce8696ecc7eb0eec52ec47780de"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8ec275046be8a7b6dc667b8a9bd308edb5512aef","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        r_region_id \u003d data_utils.rand_uuid()"},{"line_number":81,"context_line":"        r_description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":82,"context_line":"        region \u003d self.client.create_region("},{"line_number":83,"context_line":"            description\u003dr_description, region_id\u003dr_region_id)[\u0027region\u0027]"},{"line_number":84,"context_line":"        self.addCleanup(self._delete_region, region[\u0027id\u0027])"},{"line_number":85,"context_line":"        # Asserting Create Region with specific id response body"},{"line_number":86,"context_line":"        self.assertEqual(r_region_id, region[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_4d16d556","line":83,"in_reply_to":"da85f559_2dc6f216","updated":"2015-11-13 11:19:12.000000000","message":"NP.","commit_id":"1d1d15b23bb20ce8696ecc7eb0eec52ec47780de"}],"tempest/services/identity/v3/json/region_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ff3875ca12a6debdae0ad445ad2b63449fc3ba05","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RegionClient(service_client.ServiceClient):"},{"line_number":23,"context_line":"    api_version \u003d \"v3\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_region(self, **kwargs):"},{"line_number":26,"context_line":"        \"\"\"Create region.\"\"\""},{"line_number":27,"context_line":"        if kwargs.get(\u0027unique_region_id\u0027):"},{"line_number":28,"context_line":"            method \u003d self.put"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4accc9ba","line":25,"updated":"2015-11-12 05:04:10.000000000","message":"The following code seems a little tricky because unique_region_id is handled differently.\nSo how about:\n\n def create_region(self, region_id\u003dNone, **kwargs):\n     if region_id is not None:\n         method \u003d self.put\n         url \u003d \u0027regions/%s\u0027 % region_id\n     else:\n         ...\n\n?","commit_id":"35d5825cc0501da0233dd2427a582a4451761a4c"}]}