)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"508697ebbe83c48d927c0d5b2de6a51ee7047e1b","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            ssh_client.umount(mount_path)"},{"line_number":602,"context_line":"        return timestamp"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def _get_server_ip(self, server):"},{"line_number":605,"context_line":"        if CONF.compute.use_floatingip_for_ssh:"},{"line_number":606,"context_line":"            ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]"},{"line_number":607,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d7812bc4","line":604,"updated":"2015-11-12 14:02:00.000000000","message":"CONF.compute.use_floatingip_for_ssh is going to be deleted soon. I suggest that you use as follows:\n\n    def get_server_ip(self, server):\n        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:\n            ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]\n        elif CONF.validation.connect_method \u003d\u003d \u0027fixed\u0027:\n            ip \u003d server\n        return ip\n\nAlso, please, take a look at https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L344. We already have it. I really don\u0027t want we to make one more method. Anyway your work may overlap with jlanoux\u0027s work. I advise you to talk to this guy about it :)","commit_id":"12a6700e8d448aa2913631242a5a065cc74b5fc0"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"54dc2f1b5bb6f17d5e2f9dfb2cd8b84a435944f9","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            ssh_client.umount(mount_path)"},{"line_number":602,"context_line":"        return timestamp"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def _get_server_ip(self, server):"},{"line_number":605,"context_line":"        if CONF.compute.use_floatingip_for_ssh:"},{"line_number":606,"context_line":"            ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]"},{"line_number":607,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_6d1f4cb7","line":604,"in_reply_to":"da85f559_d7812bc4","updated":"2015-11-12 14:24:45.000000000","message":"ok, thank you","commit_id":"12a6700e8d448aa2913631242a5a065cc74b5fc0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f894b9b88da05e2a048ca0c00c4fbb6883857cef","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]"},{"line_number":607,"context_line":"        elif CONF.validation.connect_method \u003d\u003d \u0027fixed\u0027:"},{"line_number":608,"context_line":"            ip \u003d server"},{"line_number":609,"context_line":"        return ip"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"class NetworkScenarioTest(ScenarioTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_5b51a161","line":609,"updated":"2015-11-13 15:58:39.000000000","message":"I don\u0027t like when there\u0027s a if/elif but no else statement. Especially when you return something that could be undefined.\n\nI suggest you either use a simple if/else or if/elif/else and you raise an Exception in the \"else\" case.","commit_id":"0e41b02485a2b58f8786c1e6e0c121c56f526644"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac8655c916f569b83ccda9d347ea96e95ae3ec9c","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            ssh_client.umount(mount_path)"},{"line_number":602,"context_line":"        return timestamp"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def get_server_ip(self, server):"},{"line_number":605,"context_line":"        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":606,"context_line":"            ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]"},{"line_number":607,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_47aa29d6","line":604,"updated":"2015-11-16 23:30:41.000000000","message":"This method returns not only ip but also server.\nThe return value is assumed to be used with the above methods, and the arguments are server_or_ip.\n\nSo how about defining get_server_or_ip as the method name?\n\nWhen I saw this patches first time, I was confused because server is not ip. It would be nice to clarify the morning.","commit_id":"99491bf09fb0985e884d5e1d71c1dab854f9ebca"}],"tempest/scenario/test_shelve_instance.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"292b86699dc17953a548f983c738c6cf835d8498","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            server \u003d self.create_server(image\u003dCONF.compute.image_ref,"},{"line_number":79,"context_line":"                                        create_kwargs\u003dcreate_kwargs)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if CONF.compute.use_floatingip_for_ssh:"},{"line_number":82,"context_line":"            floating_ip \u003d self.create_floating_ip(server)[\u0027ip\u0027]"},{"line_number":83,"context_line":"            timestamp \u003d self.create_timestamp("},{"line_number":84,"context_line":"                floating_ip, private_key\u003dkeypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_7534ae49","side":"PARENT","line":81,"updated":"2015-11-13 17:45:47.000000000","message":"the new get_server_ip method doesn\u0027t appear to use this config variable. Do we still need it? My thinking is yes, but I admit I\u0027m not quite up to date - I just know this is or was significant in the IPv6 case since we can\u0027t use floating IPs.","commit_id":"81b82beef6a838a16b8deaf6c8bdcaa8bb6948bc"}]}