)]}'
{"tempest/services/compute/json/base.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0d2adc40550a00ea3c0bd497209ad2e427c9b950","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            elif version.matches(min_version, max_version):"},{"line_number":56,"context_line":"                schema \u003d items[\u0027schema\u0027]"},{"line_number":57,"context_line":"                break"},{"line_number":58,"context_line":"        if schema is None:"},{"line_number":59,"context_line":"            msg \u003d (\"Schema file for version- %s is not found in \\n %s\""},{"line_number":60,"context_line":"                   % (version.get_string(), schema_versions_info))"},{"line_number":61,"context_line":"            raise lib_exc.NotFound(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_9496a23d","line":58,"updated":"2015-11-26 11:41:15.000000000","message":"Nit: I wonder about checking for invalid version_info lists, but thats probably overkill.","commit_id":"8e7aaff901aa383ca2caa5070a3c402df1cbab49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d03203d04e4d2f294e18e64eef07a31508fdd06","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            elif version.matches(min_version, max_version):"},{"line_number":56,"context_line":"                schema \u003d items[\u0027schema\u0027]"},{"line_number":57,"context_line":"                break"},{"line_number":58,"context_line":"        if schema is None:"},{"line_number":59,"context_line":"            msg \u003d (\"Schema file for version- %s is not found in \\n %s\""},{"line_number":60,"context_line":"                   % (version.get_string(), schema_versions_info))"},{"line_number":61,"context_line":"            raise lib_exc.NotFound(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_10e614b0","line":58,"in_reply_to":"9a8ffd7b_9496a23d","updated":"2015-11-27 09:15:37.000000000","message":"Nice idea and I think its worth to check that. If there is overlap between version in that list then it might pick first one and that might be wrong and end with wrong validation.\n\nI will add that. Thanks","commit_id":"8e7aaff901aa383ca2caa5070a3c402df1cbab49"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7edda68e48b1b93fc178a01a4d1a157f4df51670","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def set_api_microversion(self, microversion):"},{"line_number":32,"context_line":"        self.api_microversion \u003d microversion"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _check_schema_info(self, schema_versions_info):"},{"line_number":35,"context_line":"        previous_max \u003d None"},{"line_number":36,"context_line":"        for items in schema_versions_info:"},{"line_number":37,"context_line":"            min_version \u003d api_version_request.APIVersionRequest(items[\u0027min\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a7b0d38_b02752b5","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":26},"updated":"2015-12-25 05:17:44.000000000","message":"This check is just for Tempest implementation bugs, not for testing.\n\nThis check runs every REST API operation, so I feel it is a little overkill. Can we skip(remove) this check at this first implementation ?","commit_id":"b3cd171d54cd2e56c1679e87bf5cbaebf5e9ce6f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f04cea77104225785b6f0627b7ba3a16522f3e37","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def set_api_microversion(self, microversion):"},{"line_number":32,"context_line":"        self.api_microversion \u003d microversion"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _check_schema_info(self, schema_versions_info):"},{"line_number":35,"context_line":"        previous_max \u003d None"},{"line_number":36,"context_line":"        for items in schema_versions_info:"},{"line_number":37,"context_line":"            min_version \u003d api_version_request.APIVersionRequest(items[\u0027min\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a7b0d38_50aceeec","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":26},"in_reply_to":"1a7b0d38_b02752b5","updated":"2015-12-25 05:27:42.000000000","message":"humm, yea that is for checking the static list and can be done on UT side. I will remove it from here. and later we will add in UT","commit_id":"b3cd171d54cd2e56c1679e87bf5cbaebf5e9ce6f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7edda68e48b1b93fc178a01a4d1a157f4df51670","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            max_version \u003d api_version_request.APIVersionRequest(items[\u0027max\u0027])"},{"line_number":64,"context_line":"            # This is case where self.api_microversion is None, which means"},{"line_number":65,"context_line":"            # request without microversion So select base v2.1 schema."},{"line_number":66,"context_line":"            if version.is_null():"},{"line_number":67,"context_line":"                if items[\u0027min\u0027] is None:"},{"line_number":68,"context_line":"                    schema \u003d items[\u0027schema\u0027]"},{"line_number":69,"context_line":"                    break"},{"line_number":70,"context_line":"            # else select appropriate schema as per self.api_microversion"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a7b0d38_8dba416d","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":40},"updated":"2015-12-25 05:17:44.000000000","message":"nit: I tend to prefer less indents.\n\nSo how about\n\n if version.is_null() and items[\u0027min\u0027] is None:\n     schema \u003d items[\u0027schema\u0027]\n     break\n\n?","commit_id":"b3cd171d54cd2e56c1679e87bf5cbaebf5e9ce6f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f04cea77104225785b6f0627b7ba3a16522f3e37","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            max_version \u003d api_version_request.APIVersionRequest(items[\u0027max\u0027])"},{"line_number":64,"context_line":"            # This is case where self.api_microversion is None, which means"},{"line_number":65,"context_line":"            # request without microversion So select base v2.1 schema."},{"line_number":66,"context_line":"            if version.is_null():"},{"line_number":67,"context_line":"                if items[\u0027min\u0027] is None:"},{"line_number":68,"context_line":"                    schema \u003d items[\u0027schema\u0027]"},{"line_number":69,"context_line":"                    break"},{"line_number":70,"context_line":"            # else select appropriate schema as per self.api_microversion"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a7b0d38_d0869e64","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":40},"in_reply_to":"1a7b0d38_8dba416d","updated":"2015-12-25 05:27:42.000000000","message":"Nice. Done","commit_id":"b3cd171d54cd2e56c1679e87bf5cbaebf5e9ce6f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5cb8f41e09accf30fc8f833b5ab63726e34284cc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def set_api_microversion(self, microversion):"},{"line_number":31,"context_line":"        self.api_microversion \u003d microversion"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_schema_file(self, schema_versions_info):"},{"line_number":34,"context_line":"        \"\"\"Get schema file"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        This method provide the matching schema file for requested"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_4ae38fa4","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":24},"updated":"2016-01-05 15:34:22.000000000","message":"Are these really separate files? Or is this just jsonschema terminology?","commit_id":"2e4f9ee047088912765bb989acfe1e3c40f46547"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ed6636d946c0b594aa990022353d6142506e011","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def set_api_microversion(self, microversion):"},{"line_number":31,"context_line":"        self.api_microversion \u003d microversion"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_schema_file(self, schema_versions_info):"},{"line_number":34,"context_line":"        \"\"\"Get schema file"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        This method provide the matching schema file for requested"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_0e38363c","line":33,"range":{"start_line":33,"start_character":19,"end_line":33,"end_character":24},"in_reply_to":"fa69d971_4ae38fa4","updated":"2016-01-05 23:52:25.000000000","message":"not separate file actually. how about just get_schema()","commit_id":"2e4f9ee047088912765bb989acfe1e3c40f46547"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5cb8f41e09accf30fc8f833b5ab63726e34284cc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if schema is None:"},{"line_number":61,"context_line":"            msg \u003d (\"Schema file for version- %s is not found in \\n %s\""},{"line_number":62,"context_line":"                   % (version.get_string(), schema_versions_info))"},{"line_number":63,"context_line":"            raise lib_exc.NotFound(msg)"},{"line_number":64,"context_line":"        return schema"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_ea5cc37e","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":39},"updated":"2016-01-05 15:34:22.000000000","message":"So I don\u0027t think this is the right exception here. This is a rest client exception, meaning it should be from a 404 response code not a missing file. We probably need a new exception here or maybe we can reuse something else","commit_id":"2e4f9ee047088912765bb989acfe1e3c40f46547"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7ed6636d946c0b594aa990022353d6142506e011","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if schema is None:"},{"line_number":61,"context_line":"            msg \u003d (\"Schema file for version- %s is not found in \\n %s\""},{"line_number":62,"context_line":"                   % (version.get_string(), schema_versions_info))"},{"line_number":63,"context_line":"            raise lib_exc.NotFound(msg)"},{"line_number":64,"context_line":"        return schema"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_eefb6279","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":39},"in_reply_to":"fa69d971_ea5cc37e","updated":"2016-01-05 23:52:25.000000000","message":"Yea, i will update.","commit_id":"2e4f9ee047088912765bb989acfe1e3c40f46547"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"8dea4fbb31b44ba4c324c318fd8fad2271a4419f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def get_schema(self, schema_versions_info):"},{"line_number":34,"context_line":"        \"\"\"Get JSON schema"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        This method provide the matching schema for requested"},{"line_number":37,"context_line":"        microversion (self.api_microversion)."},{"line_number":38,"context_line":"        :param schema_versions_info: List of dict which provides schema"},{"line_number":39,"context_line":"        information with range of valid versions."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa69d971_9a85245b","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":27},"updated":"2016-01-06 15:51:42.000000000","message":"s/provide/provides/","commit_id":"621322a8b04f3910a4527b1cea5ac5e6fbac96b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9694313563b7ad75ff96d06f519a8e85f2aa9f7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def get_schema(self, schema_versions_info):"},{"line_number":34,"context_line":"        \"\"\"Get JSON schema"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        This method provide the matching schema for requested"},{"line_number":37,"context_line":"        microversion (self.api_microversion)."},{"line_number":38,"context_line":"        :param schema_versions_info: List of dict which provides schema"},{"line_number":39,"context_line":"        information with range of valid versions."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa69d971_19a13046","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":27},"in_reply_to":"fa69d971_9a85245b","updated":"2016-01-06 23:49:00.000000000","message":"Done","commit_id":"621322a8b04f3910a4527b1cea5ac5e6fbac96b4"}]}