)]}'
{"tempest/api/compute/admin/test_images.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c6613cf7a6980a6b6ac16a236924dd0a98624b4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ImagesAdminTestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_7d3dfc29","line":27,"updated":"2016-01-11 13:12:16.000000000","message":"This is mostly a duplicate of BasicAdminOperationsImagesTest","commit_id":"fe68a823e3d18186570a2a01cdf8185ac8bb07e1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c6613cf7a6980a6b6ac16a236924dd0a98624b4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ImagesAdminTestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_fd17aca0","line":27,"updated":"2016-01-11 13:12:16.000000000","message":"This is mostly a duplicate of BasicAdminOperationsImagesTest","commit_id":"fe68a823e3d18186570a2a01cdf8185ac8bb07e1"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93b396cbed5eb402b939924140accd0ea0ff6c63","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.addCleanup(self.client.delete_image, image_id)"},{"line_number":54,"context_line":"        # upload an image file"},{"line_number":55,"context_line":"        url_image \u003d CONF.image.http_image"},{"line_number":56,"context_line":"        header, image_data \u003d httplib2.Http().request(url_image)"},{"line_number":57,"context_line":"        self.assertEqual(\"200\", header[\u0027status\u0027])"},{"line_number":58,"context_line":"        self.client.store_image_file(image_id, image_data)"},{"line_number":59,"context_line":"        # deactivate image"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_e19b7315","line":56,"updated":"2016-01-11 17:54:11.000000000","message":"You don\"t need a real image here. You should be able to boot from a random binary file, this instance should be able to reach the \"active\" state\" even if the image is not a valid OS.\n\nPlease have a look at https://github.com/openstack/tempest/blob/master/tempest/api/image/admin/v2/test_images.py#L45","commit_id":"100b86f8bee794663201f32ad67eaf4a21313aa3"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"0ee4fa302cdfb71b4936e8948fdc3735117eaa18","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.addCleanup(self.client.delete_image, image_id)"},{"line_number":54,"context_line":"        # upload an image file"},{"line_number":55,"context_line":"        url_image \u003d CONF.image.http_image"},{"line_number":56,"context_line":"        header, image_data \u003d httplib2.Http().request(url_image)"},{"line_number":57,"context_line":"        self.assertEqual(\"200\", header[\u0027status\u0027])"},{"line_number":58,"context_line":"        self.client.store_image_file(image_id, image_data)"},{"line_number":59,"context_line":"        # deactivate image"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_a65bf653","line":56,"in_reply_to":"fa69d971_e19b7315","updated":"2016-01-12 09:30:13.000000000","message":"As explained in earlier comments, we _must_ use real images otherwise you are relying on specific libvirt behaviour.  Other hypervisors have different behaviours, and the libvirt behaviour can change, so you shouldn\u0027t rely on it.","commit_id":"100b86f8bee794663201f32ad67eaf4a21313aa3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93b396cbed5eb402b939924140accd0ea0ff6c63","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # try to boot an instance - verify bad request returned."},{"line_number":64,"context_line":"        server_name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":66,"context_line":"                          self.servers_client.create_server,"},{"line_number":67,"context_line":"                          name\u003dserver_name, imageRef\u003dimage_id,"},{"line_number":68,"context_line":"                          flavorRef\u003dCONF.compute.flavor_ref)"},{"line_number":69,"context_line":"        # reactivate image"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_81a4f74a","line":66,"updated":"2016-01-11 17:54:11.000000000","message":"Use the wrapper self.create_test_server instead of the client directly.","commit_id":"100b86f8bee794663201f32ad67eaf4a21313aa3"}],"tempest/config.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"35b0e3106a193735ef1965426206f8cf8d31b469","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":482,"context_line":"               help\u003d\"The endpoint type to use for the image service.\"),"},{"line_number":483,"context_line":"    cfg.StrOpt(\u0027http_image\u0027,"},{"line_number":484,"context_line":"               default\u003d\u0027http://download.cirros-cloud.net/0.3.4/\u0027"},{"line_number":485,"context_line":"               \u0027cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":486,"context_line":"               help\u003d\u0027http accessible image\u0027),"},{"line_number":487,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_1daac071","line":484,"updated":"2016-01-11 13:10:43.000000000","message":"Unrelated change.","commit_id":"fe68a823e3d18186570a2a01cdf8185ac8bb07e1"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5fef274929036ec9dc78a208c7985588ca249e7a","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":482,"context_line":"               help\u003d\"The endpoint type to use for the image service.\"),"},{"line_number":483,"context_line":"    cfg.StrOpt(\u0027http_image\u0027,"},{"line_number":484,"context_line":"               default\u003d\u0027http://download.cirros-cloud.net/0.3.4/\u0027"},{"line_number":485,"context_line":"               \u0027cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":486,"context_line":"               help\u003d\u0027http accessible image\u0027),"},{"line_number":487,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_5ddcb8e3","line":484,"in_reply_to":"fa69d971_1daac071","updated":"2016-01-11 13:14:37.000000000","message":"Hi Jordan , \nIt is related because we copy the image to glance .\nThe proble is that we need a real image to boot instance and not run dummy image.\n\nwe copy url_image \u003d CONF.image.http_image  this image ...","commit_id":"fe68a823e3d18186570a2a01cdf8185ac8bb07e1"}]}