)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7df8222dd3fbf57c6808d65a76c785e329ebf393","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            raise"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":565,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        floating_ip \u003d (self.compute_floating_ips_client."},{"line_number":568,"context_line":"                       create_floating_ip(pool_name)[\u0027floating_ip\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f95880fc","line":565,"updated":"2015-11-17 14:06:50.000000000","message":"Nice catch. But there is a typo here. You removed \u0027s\u0027 from \"creates\", but you forgot to remove \u0027s\u0027 from \"associates\" :)\n\n    Create a floating IP and associate to a server on Nova","commit_id":"a112a59290bb2191785e111b523e6167f2062f08"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6cde007b038b1874900f8f936af153a95c3cbedc","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            raise"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def create_floating_ip(self, thing, pool_name\u003dNone):"},{"line_number":565,"context_line":"        \"\"\"Create a floating IP and associates to a server on Nova\"\"\""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        floating_ip \u003d (self.compute_floating_ips_client."},{"line_number":568,"context_line":"                       create_floating_ip(pool_name)[\u0027floating_ip\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ba83bccb","line":565,"in_reply_to":"ba8a016a_f95880fc","updated":"2015-11-17 17:41:40.000000000","message":"I agree with you Yaroslav. For sure some will send a patch just to fix this typo. \n\nBut the work being done here (fix H404/H405) is not so sexy and can easily conflict with other patches so let\u0027s try to merge this quickly.","commit_id":"a112a59290bb2191785e111b523e6167f2062f08"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7df8222dd3fbf57c6808d65a76c785e329ebf393","unresolved":false,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def create_floating_ip(self, thing, external_network_id\u003dNone,"},{"line_number":775,"context_line":"                           port_id\u003dNone, client\u003dNone):"},{"line_number":776,"context_line":"        \"\"\"Create a floating IP and associates to a resource/port on Neutron\"\"\""},{"line_number":777,"context_line":"        if not external_network_id:"},{"line_number":778,"context_line":"            external_network_id \u003d CONF.network.public_network_id"},{"line_number":779,"context_line":"        if not client:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d91c9c15","line":776,"updated":"2015-11-17 14:06:50.000000000","message":"ditto.","commit_id":"a112a59290bb2191785e111b523e6167f2062f08"}]}
