)]}'
{"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c787cdd1334cafa716c91db74391778cbb39abc8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f10a14d","side":"PARENT","line":139,"updated":"2015-11-18 02:59:22.000000000","message":"But this get remote client after reboot which is needed right? Otherwise check_partitions will be checking only on old remote client.","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"fd8df8f7bd82ab30ada1e33a61044d30faf37ed8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_8a2e7c41","side":"PARENT","line":139,"in_reply_to":"ba8a016a_1f10a14d","updated":"2015-11-18 12:59:55.000000000","message":"it works without new connection.","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4f5e5bf8b358fbca1383d220bf31b9ccee452ac6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4ed7164b","side":"PARENT","line":139,"in_reply_to":"ba8a016a_381a187e","updated":"2015-11-19 09:37:03.000000000","message":"Then how come the test passed and jenkins is green ? This patch LGTM because to reboot the server, we use the nova API and we don\u0027t ssh into the server. But I\u0027d rather we remove the call to get_remote_client L134 and leave the one L138.\n\nBut there might be something wrong here, L81 we do a soft reboot, but I thought the soft reboot doesn\"t work in the gate. Could it be that the server is not actually rebooted ?","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7adbc295eb50b0ce1131f60728b06b632bd80e42","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_69fa1445","side":"PARENT","line":139,"in_reply_to":"ba8a016a_4ed7164b","updated":"2015-11-19 10:02:10.000000000","message":"I was wrong. It seems L134 and L138 are both part of the scenario. They are here to check that we can SSH to the server before and after the reboot.","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"b085b4af398ae1ace0dce0e9cdd5b0f51d6ecb50","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_84b4fd34","side":"PARENT","line":139,"in_reply_to":"ba8a016a_4ed7164b","updated":"2015-11-19 10:08:48.000000000","message":"Jordan, I think we shouldn\u0027t remove L134, because I guess this line is a step of the following scenario:\n\n    1. Boot a server\n    2. Create a volume \n    3. Attach the volume to the server\n    4. Create a floating IP and associate it to the server\n    5. Check SSH connection to the server.\n    6. Reboot the server \n    7. Check SSH connection to the server and partitions","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"9385c820e737c2439f7fdcacd2819aa73d11f3e7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a43ca1c8","side":"PARENT","line":139,"in_reply_to":"ba8a016a_69fa1445","updated":"2015-11-19 10:06:55.000000000","message":"ok, I got it. thanks","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a769af9ef2a283f96ebdd8c6e8464c96de52f0f5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f62963e","side":"PARENT","line":139,"in_reply_to":"ba8a016a_8415dde5","updated":"2015-11-19 10:29:46.000000000","message":"And it works as FIP is being used for ssh and works even after reboot.","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a907d3f28b00d558aa4e1ece0c6450a8f8d39bda","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_8415dde5","side":"PARENT","line":139,"in_reply_to":"ba8a016a_84b4fd34","updated":"2015-11-19 10:10:36.000000000","message":"Oh, sorry, I am late :)","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"07ea3b2c93055f6fc65402601771027525c9f6cb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.nova_reboot(server)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        self.linux_client \u003d self.get_remote_client("},{"line_number":139,"context_line":"            floating_ip[\u0027ip\u0027], private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":140,"context_line":"        self.check_partitions()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_381a187e","side":"PARENT","line":139,"in_reply_to":"ba8a016a_8a2e7c41","updated":"2015-11-19 09:11:10.000000000","message":"Alexander, Ghanshyam is right. We shouldn\u0027t remove this line, because here we create new remote client AFTER rebooting server to check connection and partitions.","commit_id":"5e02d4a6a54f24ccf999f71ec21843fa7a7f6829"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"0dca6ba3753dfc4451e883e3cf5c43a404d714a8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    * across the multiple components"},{"line_number":37,"context_line":"    * as a regular user"},{"line_number":38,"context_line":"    * with and without optional parameters"},{"line_number":39,"context_line":"    * check command outputs"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_0571cb0e","line":39,"updated":"2015-11-19 18:02:24.000000000","message":"Can you extend the description about what this test does ?","commit_id":"4f6fd1b282eaa32dc98533ffa66c429c7f9f509b"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"60e21b106a4f51059ae15ff31accb097f9a30419","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    * across the multiple components"},{"line_number":37,"context_line":"    * as a regular user"},{"line_number":38,"context_line":"    * with and without optional parameters"},{"line_number":39,"context_line":"    * check command outputs"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_57b3e597","line":39,"in_reply_to":"ba8a016a_0571cb0e","updated":"2015-11-20 09:46:05.000000000","message":"sure, I will add","commit_id":"4f6fd1b282eaa32dc98533ffa66c429c7f9f509b"}]}