)]}'
{"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"105c0e0637bd8ff26f0e3c8eb111e27b7d9e415d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        server \u003d self.client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":72,"context_line":"        self.assertEqual(key_name, server[\u0027key_name\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _update_server_name(self, server_id, status, new_name\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        # The server name should be changed to the the provided value"},{"line_number":76,"context_line":"        if not new_name:"},{"line_number":77,"context_line":"            new_name \u003d data_utils.rand_name(\u0027server\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6e7c0a21","line":74,"updated":"2015-11-24 14:15:00.000000000","message":"I think it will be better if we always generate random name.\n\n    def _update_server_name(self, server_id, status, prefix_name\u003d\u0027server\u0027):\n        # The server name should be changed to the the provided value\n        new_name \u003d data_utils.rand_name(prefix_name)\n\n        # Update the server with a new name\n        self.client.update_server(server_id,\n                                  name\u003dnew_name)\n        waiters.wait_for_server_status(self.client, server_id, status)\n\n        # Verify the name of the server has changed\n        server \u003d self.client.show_server(server_id)[\u0027server\u0027]\n        self.assertEqual(new_name, server[\u0027name\u0027])\n        return server","commit_id":"26e9fefde484f7e39fe38298382f53920edb970a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"105c0e0637bd8ff26f0e3c8eb111e27b7d9e415d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._update_server_name(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Update instance name with non-ASCII characters"},{"line_number":97,"context_line":"        new_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":98,"context_line":"        self._update_server_name(server[\u0027id\u0027], \u0027ACTIVE\u0027, new_name\u003dnew_name)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @test.idempotent_id(\u00276ac19cb1-27a3-40ec-b350-810bdc04c08e\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_8c6856bc","line":97,"updated":"2015-11-24 14:15:00.000000000","message":"And here it would be like this:    \n\n    # Update instance name with non-ASCII characters\n    prefix_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027\n    self._update_server_name(server[\u0027id\u0027], \u0027ACTIVE\u0027, prefix_name)","commit_id":"26e9fefde484f7e39fe38298382f53920edb970a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"105c0e0637bd8ff26f0e3c8eb111e27b7d9e415d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertNotIn(\u0027progress\u0027, updated_server)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # Update instance name with non-ASCII characters"},{"line_number":110,"context_line":"        new_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":111,"context_line":"        self._update_server_name(server[\u0027id\u0027], \u0027SHUTOFF\u0027, new_name\u003dnew_name)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @test.idempotent_id(\u002789b90870-bc13-4b73-96af-f9d4f2b70077\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6c8df27a","line":110,"updated":"2015-11-24 14:15:00.000000000","message":"ditto.","commit_id":"26e9fefde484f7e39fe38298382f53920edb970a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a291b7e300005419a95a5d3a4c0dcede1a739bd3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":92,"context_line":"        # Update instance name with non-ASCII characters"},{"line_number":93,"context_line":"        prefix_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027"},{"line_number":94,"context_line":"        self._update_server_name(server[\u0027id\u0027], \u0027ACTIVE\u0027, prefix_name)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @test.idempotent_id(\u00276ac19cb1-27a3-40ec-b350-810bdc04c08e\u0027)"},{"line_number":97,"context_line":"    def test_update_server_name_in_stop_state(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ec82f051","line":94,"updated":"2015-11-25 17:46:55.000000000","message":"In this case the server name will be something like this:\n\n    tempest-Íñstáñcé-1037503084\n\nSo, the name has both ASCII and non-ASCII symbols. I think it is a good check.","commit_id":"145258fa076703282feb23d96410035b9f5d38ee"}]}
