)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"53c6503f4c88aea40e2efb86f0ddd77edf71f021","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3df15296","line":760,"updated":"2015-11-30 16:42:06.000000000","message":"What about the should_check_floating_ip_status parameter of the \u0027check_public_network_connectivity\u0027 method ?\n\nIf one network implementation requires  \"should_connect\u003dFalse\" and another \"should_connect\u003dTrue\" then I guess this line (760) is useless.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"aa0618bd99d4b314b5d88f68cd6e8b6b90293d59","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_bf532ae1","line":760,"in_reply_to":"7a740942_bfbc8a06","updated":"2015-12-14 13:05:13.000000000","message":"I meant Yair... sorry about that.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0eb895b68a4a5c8e79e4e6e7dd8536b5ef209651","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_5f5e7777","line":760,"in_reply_to":"9a8ffd7b_3df15296","updated":"2015-12-01 02:02:21.000000000","message":"Jordan,\n\nin the commit message, i meant that should_connect\u003dFalse\nis not appropriate for any implementations.\n\nfor some implementations it always fail and\nfor the others it sometimes fail.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1fd622e7fbeb5c302fb9774c03a28d35e5b3c87c","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a1aa9717","line":760,"in_reply_to":"9a8ffd7b_5f5e7777","updated":"2015-12-02 09:37:05.000000000","message":"Ok. What about removing this line then ?\n\nIf the test is green in the Gate with should_connect\u003dTrue and should_connect\u003dFalse. This line looks useless to me.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f3f4633d79b1d80f51a6c2799330bab65c601e7e","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_cddd8a71","line":760,"in_reply_to":"9a8ffd7b_a1aa9717","updated":"2015-12-02 10:30:31.000000000","message":"Jordan,\n\ni don\u0027t follow your logic.\n\nnothing wrong with having tests with non-zero\nfalse positive rate in a certain setup.\n\nbesides that, the method is more than an assertion.\nit waits for the state transition.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3704347468cab51f79f7468f7202fd92e3fae861","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Create server"},{"line_number":759,"context_line":"        self._setup_network_and_servers()"},{"line_number":760,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":761,"context_line":"        self._create_new_network()"},{"line_number":762,"context_line":"        self._hotplug_server()"},{"line_number":763,"context_line":"        fip, server \u003d self.floating_ip_tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_bfbc8a06","line":760,"in_reply_to":"9a8ffd7b_cddd8a71","updated":"2015-12-14 13:04:27.000000000","message":"After a chat with Yfair, I remove my -1. But imo this line doesn\"t serve the purpose of this test and I\u0027d rather see it removed.","commit_id":"c368dde1dc33c6d6469b8c731051442726756a20"}]}