)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"1c3fc50bf167232ce79a3d1d59af42922784e54f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Here are the test steps:"},{"line_number":10,"context_line":"- Create an encrypted volume per volume-type(backend)"},{"line_number":11,"context_line":"- Verify that volume type is corrent and encrypted"},{"line_number":12,"context_line":"- Delete all created volumes"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We will have to add more tests for encrypted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_f7325d5d","line":11,"updated":"2015-12-08 10:35:39.000000000","message":"s/corrent/correct/\n\n?","commit_id":"5e19a0e52fa027b5a0488f8d77554aabbf24bc6f"}],"tempest/api/volume/admin/test_encrypted_multi_backend.py":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"1c3fc50bf167232ce79a3d1d59af42922784e54f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"         for backend_name in cls.backend_names]"},{"line_number":53,"context_line":"        # Encrypted types set for each volume type"},{"line_number":54,"context_line":"        [cls._create_encrypted_type(volume_type_id)"},{"line_number":55,"context_line":"         for volume_type_id in cls.volume_type_id_list]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def _create_volume_type(self, backend_name_key, with_prefix\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_10a84fda","line":55,"updated":"2015-12-08 10:35:39.000000000","message":"List comprehensions are creating a useless object here (the list). I recommend using an explicit for loop instead of using the comprehension.\n\n    for backend_name in cls.backend_names:\n        cls._create_volume_type(...)\n    for volume_type_id in cls.volume_type_id_list:\n        cls._create_encrypted_type(...)\n\nObject creation is often costly in Python and should be avoided unless necessary.","commit_id":"5e19a0e52fa027b5a0488f8d77554aabbf24bc6f"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"1c3fc50bf167232ce79a3d1d59af42922784e54f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        for volume_type_name in self.volume_type_names:"},{"line_number":78,"context_line":"            params \u003d {\u0027volume_type\u0027: volume_type_name, }"},{"line_number":79,"context_line":"            volume \u003d self.create_volume(**params)"},{"line_number":80,"context_line":"            self.assertEqual(True, volume[\"encrypted\"],"},{"line_number":81,"context_line":"                             \"The volume is not encrypted\")"},{"line_number":82,"context_line":"            self.assertEqual(volume_type_name, volume[\u0027volume_type\u0027],"},{"line_number":83,"context_line":"                             \"The volume type name is different\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f0da634a","line":80,"updated":"2015-12-08 10:35:39.000000000","message":"why not use:\n\n    self.assertTrue(volume[\u0027encrypted\u0027])","commit_id":"5e19a0e52fa027b5a0488f8d77554aabbf24bc6f"}],"tempest/api/volume/admin/test_multi_backend.py":[{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"1c3fc50bf167232ce79a3d1d59af42922784e54f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            cls.backend_names \u003d set(CONF.volume.backend_names)"},{"line_number":45,"context_line":"        cls.volume_id_list_with_prefix \u003d []"},{"line_number":46,"context_line":"        cls.volume_id_list_without_prefix \u003d []"},{"line_number":47,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Volume/Type creation (uses volume_backend_name)"},{"line_number":50,"context_line":"        # It is not allowed to create the same backend name twice"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_b097fb46","line":47,"updated":"2015-12-08 10:35:39.000000000","message":"Any particular reason for moving this statement two lines down?","commit_id":"5e19a0e52fa027b5a0488f8d77554aabbf24bc6f"}],"tempest/api/volume/base.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2d82fb6f8f8eaa6b77e2788faee6eff9869beac2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        super(BaseVolumeAdminTest, cls).resource_setup()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        cls.qos_specs \u003d []"},{"line_number":209,"context_line":"        cls.volume_type_id_with_prefix_list \u003d []"},{"line_number":210,"context_line":"        cls.volume_type_id_without_prefix_list \u003d []"},{"line_number":211,"context_line":"        cls.volume_encrypted_type_id_list \u003d []"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_28099f84","line":209,"updated":"2015-12-02 12:31:57.000000000","message":"What\u0027s the difference between volume_type created with prefix and those created without prefix ? You seem to delete all of them the same way.","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8ee34d237e088d173fdaa5c7049cbdfb6199a8d4","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        super(BaseVolumeAdminTest, cls).resource_setup()"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        cls.qos_specs \u003d []"},{"line_number":209,"context_line":"        cls.volume_type_id_with_prefix_list \u003d []"},{"line_number":210,"context_line":"        cls.volume_type_id_without_prefix_list \u003d []"},{"line_number":211,"context_line":"        cls.volume_encrypted_type_id_list \u003d []"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ebe14c2b","line":209,"in_reply_to":"9a8ffd7b_28099f84","updated":"2015-12-02 13:51:00.000000000","message":"yep you are right .. fixing","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2d82fb6f8f8eaa6b77e2788faee6eff9869beac2","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            extra_specs \u003d {spec_key_without_prefix: backend_name_key}"},{"line_number":240,"context_line":"        volume_type \u003d cls.volume_types_client.create_volume_type("},{"line_number":241,"context_line":"            type_name, extra_specs\u003dextra_specs)[\u0027volume_type\u0027]"},{"line_number":242,"context_line":"        if with_prefix:"},{"line_number":243,"context_line":"            cls.volume_type_id_with_prefix_list.append(volume_type[\u0027id\u0027])"},{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            cls.volume_type_id_without_prefix_list.append(volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_48a18345","line":242,"updated":"2015-12-02 12:31:57.000000000","message":"Could you just do an addCleanup(cls.volume_types_client.delete_volume_type, volume_type[\u0027id\u0027]) This way you don\"t need to add a clear_volume_types method here","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8ee34d237e088d173fdaa5c7049cbdfb6199a8d4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            extra_specs \u003d {spec_key_without_prefix: backend_name_key}"},{"line_number":240,"context_line":"        volume_type \u003d cls.volume_types_client.create_volume_type("},{"line_number":241,"context_line":"            type_name, extra_specs\u003dextra_specs)[\u0027volume_type\u0027]"},{"line_number":242,"context_line":"        if with_prefix:"},{"line_number":243,"context_line":"            cls.volume_type_id_with_prefix_list.append(volume_type[\u0027id\u0027])"},{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            cls.volume_type_id_without_prefix_list.append(volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_cb31e8ee","line":242,"in_reply_to":"9a8ffd7b_48a18345","updated":"2015-12-02 13:51:00.000000000","message":"yes sure , i wil fix it","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2d82fb6f8f8eaa6b77e2788faee6eff9869beac2","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                cls.volume_types_client.delete_volume_type("},{"line_number":288,"context_line":"                    volume_type_id_with_prefix)"},{"line_number":289,"context_line":"            except lib_exc.NotFound:"},{"line_number":290,"context_line":"                # The qos_specs may have already been deleted which is OK."},{"line_number":291,"context_line":"                pass"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_c8d573e5","line":290,"updated":"2015-12-02 12:31:57.000000000","message":"What is exaclty qos_specs doing here ?","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9af2c04ac200f6532ad2b8d0a71e49ae24d12533","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                cls.volume_types_client.delete_volume_type("},{"line_number":288,"context_line":"                    volume_type_id_with_prefix)"},{"line_number":289,"context_line":"            except lib_exc.NotFound:"},{"line_number":290,"context_line":"                # The qos_specs may have already been deleted which is OK."},{"line_number":291,"context_line":"                pass"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_cb46c8bf","line":290,"in_reply_to":"9a8ffd7b_4b3e588c","updated":"2015-12-02 13:55:51.000000000","message":"Yeah but the code comment says \u0027qos_specs\u0027 but you are iterating over volume_type.\n\nAny way, if you go with the addCleanup approach (which I recommend) these clear_volume_types and clear_encrypted_type methods should be removed.","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8ee34d237e088d173fdaa5c7049cbdfb6199a8d4","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                cls.volume_types_client.delete_volume_type("},{"line_number":288,"context_line":"                    volume_type_id_with_prefix)"},{"line_number":289,"context_line":"            except lib_exc.NotFound:"},{"line_number":290,"context_line":"                # The qos_specs may have already been deleted which is OK."},{"line_number":291,"context_line":"                pass"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4b3e588c","line":290,"in_reply_to":"9a8ffd7b_c8d573e5","updated":"2015-12-02 13:51:00.000000000","message":"In case its already deleted  ...  we may hit on timing issue ?","commit_id":"82f0a23c089803250893f6131f2f52f26240667e"}]}