)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3a568b50c6deaa2a820b1286d5f660dad5a4a446","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xing Yang \u003cxing.yang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-19 09:55:20 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest tests for CG"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds tempest tests for consistency group API in Cinder."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_a0dfd00b","line":7,"updated":"2015-12-07 17:19:22.000000000","message":"Please, use \"consistency group\" instead of CG. Somebody may not understand what it is.","commit_id":"12746675a12c4af201081c4e47c7cc8976ff2aa4"}],"tempest/api/volume/admin/test_consistencygroups.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ca44655b53e932665423304aeb64db96a7f8fb53","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def skip_checks(cls):"},{"line_number":32,"context_line":"        super(ConsistencyGroupsV2Test, cls).skip_checks()"},{"line_number":33,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":34,"context_line":"            raise cls.skipException(\"Cinder backup feature disabled\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _delete_consistencygroup(self, cg_id):"},{"line_number":37,"context_line":"        self.consistencygroups_adm_client.delete_consistencygroup(cg_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_de50dbd6","line":34,"updated":"2015-12-02 06:49:17.000000000","message":"Need to change this to a CG option.","commit_id":"8483bcf89813bc984d2be309fd03854965550fe1"}],"tempest/services/volume/base/base_consistencygroups_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7c660616555541949c2cd8ff731c40d4ef9ff0a3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":43,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_consistencygroup_from_src(self, cgsnapshot_id\u003dNone,"},{"line_number":46,"context_line":"                                         source_cgid\u003dNone, name\u003dNone,"},{"line_number":47,"context_line":"                                         description\u003dNone):"},{"line_number":48,"context_line":"        \"\"\"Creates a consistency group from source.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_55ab9e1d","line":45,"updated":"2015-12-04 16:35:19.000000000","message":"Please look at the other tempest clients. The signature of this method should be\n\ndef create_consistencygroup_from_src(self, **kwargs)","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5d18b24de6f3e06978c687804c6ea16275915b70","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":43,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_consistencygroup_from_src(self, cgsnapshot_id\u003dNone,"},{"line_number":46,"context_line":"                                         source_cgid\u003dNone, name\u003dNone,"},{"line_number":47,"context_line":"                                         description\u003dNone):"},{"line_number":48,"context_line":"        \"\"\"Creates a consistency group from source.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f0b65589","line":45,"in_reply_to":"7a740942_55ab9e1d","updated":"2015-12-04 18:32:48.000000000","message":"I\u0027m looking at another tempest client under this folder here.  See this example:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/services/volume/base/base_backups_client.py#L28\n\ndef create_backup(self, volume_id, container\u003dNone, name\u003dNone, description\u003dNone):\n\nSo is this a new requirement to change the signature of all functions to be xxxxxx(self, **kwargs)?  I\u0027m okay to change it if required.  I want to get a confirmation before changing because someone else could tell me to change it back and ask me to look at other tempest clients examples which are not using this signature.","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f19a9a03d8a3981de30b4cf8927699ffc98bffac","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class BaseConsistencyGroupsClient(service_client.ServiceClient):"},{"line_number":27,"context_line":"    \"\"\"Client class to send CRUD Volume ConsistencyGroup API requests\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def create_consistencygroup(self, volume_types, name\u003dNone,"},{"line_number":30,"context_line":"                                description\u003dNone, availability_zone\u003dNone):"},{"line_number":31,"context_line":"        \"\"\"Creates a consistency group.\"\"\""},{"line_number":32,"context_line":"        post_body \u003d {\u0027volume_types\u0027: volume_types}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c5aee397","line":29,"updated":"2015-12-05 15:58:37.000000000","message":"Yes, see this blueprint https://blueprints.launchpad.net/tempest/+spec/consistent-service-method-names and the patches related to it.\n\nIt should really be with **kwargs.","commit_id":"12746675a12c4af201081c4e47c7cc8976ff2aa4"}],"tempest/services/volume/base/base_snapshots_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7c660616555541949c2cd8ff731c40d4ef9ff0a3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            old_value \u003d value"},{"line_number":112,"context_line":"            value \u003d self._get_snapshot_status(snapshot_id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def wait_for_snapshot_deletion(self, snapshot_id):"},{"line_number":115,"context_line":"        \"\"\"Waits for snapshot deletion\"\"\""},{"line_number":116,"context_line":"        start_time \u003d int(time.time())"},{"line_number":117,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_b58522ae","line":114,"updated":"2015-12-04 16:35:19.000000000","message":"This is a helper/wrapper. This should be somewhere in tempest/common","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5d18b24de6f3e06978c687804c6ea16275915b70","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            old_value \u003d value"},{"line_number":112,"context_line":"            value \u003d self._get_snapshot_status(snapshot_id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def wait_for_snapshot_deletion(self, snapshot_id):"},{"line_number":115,"context_line":"        \"\"\"Waits for snapshot deletion\"\"\""},{"line_number":116,"context_line":"        start_time \u003d int(time.time())"},{"line_number":117,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_03eb99b1","line":114,"in_reply_to":"7a740942_b58522ae","updated":"2015-12-04 18:32:48.000000000","message":"Done","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"}],"tempest/services/volume/base/base_volumes_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7c660616555541949c2cd8ff731c40d4ef9ff0a3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Waits for a Volume to reach a given status.\"\"\""},{"line_number":176,"context_line":"        waiters.wait_for_volume_status(self, volume_id, status)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def wait_for_volume_deletion(self, volume_id):"},{"line_number":179,"context_line":"        \"\"\"Waits for volume deletion\"\"\""},{"line_number":180,"context_line":"        start_time \u003d int(time.time())"},{"line_number":181,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_75f81a4a","line":178,"updated":"2015-12-04 16:35:19.000000000","message":"This is a helper/wrapper. This should be somewhere in tempest/common","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5d18b24de6f3e06978c687804c6ea16275915b70","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        \"\"\"Waits for a Volume to reach a given status.\"\"\""},{"line_number":176,"context_line":"        waiters.wait_for_volume_status(self, volume_id, status)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def wait_for_volume_deletion(self, volume_id):"},{"line_number":179,"context_line":"        \"\"\"Waits for volume deletion\"\"\""},{"line_number":180,"context_line":"        start_time \u003d int(time.time())"},{"line_number":181,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_83c0e92b","line":178,"in_reply_to":"7a740942_75f81a4a","updated":"2015-12-04 18:32:48.000000000","message":"Done","commit_id":"1833009a078d5ca976b0f7eed23fcb2692fc1a8b"}]}