)]}'
{"tempest/services/identity/v2/json/identity_client.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"885c34eb36268c573b59a8ec8a746f3145596099","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":277,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def update_user_password(self, **kwargs):"},{"line_number":280,"context_line":"        \"\"\"Update User Password.\"\"\""},{"line_number":281,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":282,"context_line":"        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % kwargs[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_ed12fe61","line":279,"updated":"2015-12-04 17:30:39.000000000","message":"Most of \"update\" methods in Tempest look like\n\n    def update_something(self, \u003cresource id\u003e, **kwargs):\n        ...\n\n    def update_user_password(self, user_id, **kwargs):\n        put_body \u003d json.dumps({\u0027user\u0027: kwargs})\n        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % user_id, put_body)\n        ...\n\nAlso it would be nice to have the link to API docs here.","commit_id":"f10e1f4f622726f2ba52236b99f02cfb72d95fc4"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5a237cf0a03d47524ce26ca51750c91cb14dc5df","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":277,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def update_user_password(self, **kwargs):"},{"line_number":280,"context_line":"        \"\"\"Update User Password.\"\"\""},{"line_number":281,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":282,"context_line":"        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % kwargs[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7a4c14c8","line":279,"in_reply_to":"7a740942_4f8c547f","updated":"2015-12-08 09:38:53.000000000","message":"I have tested the following code and it worked for me.\n\n    def update_user_password(self, user_id, **kwargs):\n        put_body \u003d json.dumps({\u0027user\u0027: kwargs})\n        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % user_id, put_body)\n        self.expected_success(200, resp.status)\n        body \u003d json.loads(body)\n        return service_client.ResponseBody(resp, body)\n\nIt looks like we don\u0027t need user_id in the request body at all. Could you please check it?","commit_id":"f10e1f4f622726f2ba52236b99f02cfb72d95fc4"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"871895516f69b3631d3211a01510d3f453259337","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":277,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def update_user_password(self, **kwargs):"},{"line_number":280,"context_line":"        \"\"\"Update User Password.\"\"\""},{"line_number":281,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":282,"context_line":"        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % kwargs[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f096e33c","line":279,"in_reply_to":"7a740942_7a4c14c8","updated":"2015-12-08 10:07:49.000000000","message":"Sure Yaroslav!! I will check the same and if it work will update the patch including changes.\nThanks a lot for valuable suggestion :-)","commit_id":"f10e1f4f622726f2ba52236b99f02cfb72d95fc4"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"1f572f9fe9ce23e01f4c750ff2acc53fd9898a6e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":277,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def update_user_password(self, **kwargs):"},{"line_number":280,"context_line":"        \"\"\"Update User Password.\"\"\""},{"line_number":281,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":282,"context_line":"        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % kwargs[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_4f8c547f","line":279,"in_reply_to":"7a740942_ed12fe61","updated":"2015-12-08 06:21:39.000000000","message":"Thanks for the Review Yaroslav. please find some of my reply to your comments:\nMost of \"update\" methods in Tempest look like\n\n    def update_something(self, \u003cresource id\u003e, **kwargs):\n        ...\n\n    def update_user_password(self, user_id, **kwargs):\n        put_body \u003d json.dumps({\u0027user\u0027: kwargs})\n        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % user_id, put_body)\n        ...\n\u003cPiyush\u003e: yes your comment is valid but i haven\u0027t done that because in this case put_body also have user_id as one of the parameter. so if we will pass user_id separately then either we have to pass \"\u0027id\u0027: user_id\" in kwargs also or we have to update the kwargs in identity_client.py to prepare the body of request. So as to avoid and work accordingly to blue print i have opted to pass all parameter through dictionary and fetch the user_id using kwargs[\u0027id\u0027]. please see if this fits or if there some suggestion from your end :-)\n\nAlso it would be nice to have the link to API docs here.\n\n\u003cPiyush\u003e: I didn’t find the doc link for \"users/\u003cuser_id\u003e/OS-KSADM/password\" in http://developer.openstack.org/api-ref.html. so i submitted this. can you please help me if i am going in wrong search :-).","commit_id":"f10e1f4f622726f2ba52236b99f02cfb72d95fc4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1e9423bec09625c63427abb841843d8bf8da8e6c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        \"\"\"Update User Password.\"\"\""},{"line_number":281,"context_line":"        # TODO(piyush): Current api-site doesn\u0027t contain this API description."},{"line_number":282,"context_line":"        # After fixing the api-site, we need to fix here also for putting the"},{"line_number":283,"context_line":"        # link to api-site."},{"line_number":284,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":285,"context_line":"        resp, body \u003d self.put(\u0027users/%s/OS-KSADM/password\u0027 % user_id, put_body)"},{"line_number":286,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3af41a59","line":283,"updated":"2015-12-09 01:56:16.000000000","message":"Nice point.\n\nI registered this problem to launchpad.\nSo please add the following comment:\n\n # LP: https://bugs.launchpad.net/openstack-api-site/+bug/1524147","commit_id":"deeb168541075068ff01abbe2ff7162b3fbe9678"}]}