)]}'
{"tempest/common/api_version_request.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8b282af4d539057156397d7580088c04f8c18671","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.ver_major \u003d 0"},{"line_number":58,"context_line":"        self.ver_minor \u003d 0"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if version_string not in (None, \u0027None\u0027):"},{"line_number":61,"context_line":"            match \u003d re.match(r\"^([1-9]\\d*)\\.([1-9]\\d*|0)$\","},{"line_number":62,"context_line":"                             version_string)"},{"line_number":63,"context_line":"            if match:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_714019a6","line":60,"updated":"2015-12-05 06:40:12.000000000","message":"Is it still necessary to put None here?\n\nAnd it is nice to put NOTE here for the string like this commit message.","commit_id":"c86ea45c37956fd6938240e9fa71183f16d0308e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"62e62ed82169fc5b3bbb6066123fe30384943e1a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.ver_major \u003d 0"},{"line_number":58,"context_line":"        self.ver_minor \u003d 0"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if version_string not in (None, \u0027None\u0027):"},{"line_number":61,"context_line":"            match \u003d re.match(r\"^([1-9]\\d*)\\.([1-9]\\d*|0)$\","},{"line_number":62,"context_line":"                             version_string)"},{"line_number":63,"context_line":"            if match:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0a3cecc6","line":60,"in_reply_to":"7a740942_714019a6","updated":"2015-12-06 22:59:28.000000000","message":"Yes, None is necessary, because that\u0027s the value it has by default, when the config option is not specified in the config file.","commit_id":"c86ea45c37956fd6938240e9fa71183f16d0308e"}],"tempest/config.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"451391fadbab84626ea92c969c2f6b7595e37f1d","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                                      title\u003d\"Enabled Compute Service Features\")"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"ComputeFeaturesGroup \u003d ["},{"line_number":344,"context_line":"    # NOTE(gmann): This supports string \u0027None\u0027 also. If \u0027min_microversion\u0027 is"},{"line_number":345,"context_line":"    # set as None explicitly then, value return by oslo.config is string \u0027None\u0027"},{"line_number":346,"context_line":"    # and tempest will handle that too."},{"line_number":347,"context_line":"    # IMO, None should be return as None from oslo for any config types."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_77d98d21","line":344,"updated":"2015-12-08 09:15:35.000000000","message":"This note could actually go in api_version_request.py","commit_id":"e4dfa27cb12600cadf9518e9761b2455632d76cf"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"451391fadbab84626ea92c969c2f6b7595e37f1d","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    cfg.StrOpt(\u0027min_microversion\u0027,"},{"line_number":349,"context_line":"               default\u003dNone,"},{"line_number":350,"context_line":"               help\u003d\"Lower version of the test target microversion range. \""},{"line_number":351,"context_line":"                    \"The format is \u0027X.Y\u0027, where \u0027X\u0027 and \u0027Y\u0027 are int values. \""},{"line_number":352,"context_line":"                    \"Tempest selects tests based on the range between \""},{"line_number":353,"context_line":"                    \"min_microversion and max_microversion. \""},{"line_number":354,"context_line":"                    \"If both values are None, Tempest avoids tests which \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_37df850e","line":351,"range":{"start_line":351,"start_character":21,"end_line":351,"end_character":75},"updated":"2015-12-08 09:15:35.000000000","message":"I would have here \"The format is \u0027X.Y\u0027, where \u0027X\u0027 and \u0027Y\u0027 are int values, the string \u0027latest\u0027 or the string \u0027None\u0027\" - or something like that","commit_id":"e4dfa27cb12600cadf9518e9761b2455632d76cf"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"451391fadbab84626ea92c969c2f6b7595e37f1d","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                    \"min_microversion and max_microversion. \""},{"line_number":354,"context_line":"                    \"If both values are None, Tempest avoids tests which \""},{"line_number":355,"context_line":"                    \"require a microversion.\"),"},{"line_number":356,"context_line":"    # NOTE(gmann): This supports string \u0027None\u0027 also. If \u0027max_microversion\u0027 is"},{"line_number":357,"context_line":"    # set as None explicitly then, value return by oslo.config is string \u0027None\u0027"},{"line_number":358,"context_line":"    # and tempest will handle that too."},{"line_number":359,"context_line":"    # IMO, None should be return as None from oslo for any config types."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3706a586","line":356,"updated":"2015-12-08 09:15:35.000000000","message":"Ditto","commit_id":"e4dfa27cb12600cadf9518e9761b2455632d76cf"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"451391fadbab84626ea92c969c2f6b7595e37f1d","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    cfg.StrOpt(\u0027max_microversion\u0027,"},{"line_number":361,"context_line":"               default\u003dNone,"},{"line_number":362,"context_line":"               help\u003d\"Upper version of the test target microversion range. \""},{"line_number":363,"context_line":"                    \"The format is \u0027X.Y\u0027, where \u0027X\u0027 and \u0027Y\u0027 are int values. \""},{"line_number":364,"context_line":"                    \"Tempest selects tests based on the range between \""},{"line_number":365,"context_line":"                    \"min_microversion and max_microversion. \""},{"line_number":366,"context_line":"                    \"If both values are None, Tempest avoids tests which \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_17ea89ac","line":363,"updated":"2015-12-08 09:15:35.000000000","message":"ditto","commit_id":"e4dfa27cb12600cadf9518e9761b2455632d76cf"}],"tempest/exceptions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48ed3113811bf0a142f9eb276d9d6390d2bff467","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TempestException, self).__init__()"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            self._error_string \u003d self.message % kwargs"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        except Exception:"},{"line_number":34,"context_line":"            # at least get the core message out if something happened"},{"line_number":35,"context_line":"            self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_83b3220a","line":32,"updated":"2015-12-10 05:36:24.000000000","message":"nit: I guess this change seems unnecessary..","commit_id":"e02cccbdf8e86b1a32e9b11309c2672cb92919b6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"64ffb965931b29c3e84a1aab9587f85e5db350b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TempestException, self).__init__()"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            self._error_string \u003d self.message % kwargs"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        except Exception:"},{"line_number":34,"context_line":"            # at least get the core message out if something happened"},{"line_number":35,"context_line":"            self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a9babf6c","line":32,"in_reply_to":"7a740942_83b3220a","updated":"2015-12-10 06:51:26.000000000","message":"ops, Done","commit_id":"e02cccbdf8e86b1a32e9b11309c2672cb92919b6"}]}
