)]}'
{"tempest/cmd/javelin.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"718d53bb241d7a829f053f650d9f13870f0b6c3a","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                        # reach the server."},{"line_number":490,"context_line":"                        # This is useful in multi-node environment."},{"line_number":491,"context_line":"                        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":492,"context_line":"                            self._ping_ip(ip, 60)"},{"line_number":493,"context_line":"                            _floating_is_alive \u003d True"},{"line_number":494,"context_line":"                        elif CONF.validation.connect_method \u003d\u003d \u0027fixed\u0027:"},{"line_number":495,"context_line":"                            namespace \u003d _get_router_namespace(client,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_42983778","line":492,"range":{"start_line":492,"start_character":24,"end_line":492,"end_character":33},"updated":"2015-12-14 09:01:30.000000000","message":"How do you know here that the \u0027ip\u0027 you got is a floating IP ? It could be a fixed IP right ?","commit_id":"3a6565075dea22411077c7dcac242d1c422801c2"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"a0e67683c5d2b302958e26e4708db93358c348ca","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                        # reach the server."},{"line_number":490,"context_line":"                        # This is useful in multi-node environment."},{"line_number":491,"context_line":"                        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":492,"context_line":"                            self._ping_ip(ip, 60)"},{"line_number":493,"context_line":"                            _floating_is_alive \u003d True"},{"line_number":494,"context_line":"                        elif CONF.validation.connect_method \u003d\u003d \u0027fixed\u0027:"},{"line_number":495,"context_line":"                            namespace \u003d _get_router_namespace(client,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_826b7ff0","line":492,"range":{"start_line":492,"start_character":24,"end_line":492,"end_character":33},"in_reply_to":"7a740942_42983778","updated":"2015-12-14 09:14:12.000000000","message":"Because you\u0027re in the floating condition Jordan. If it\u0027s a fixed IP, it\u0027s the condition below.","commit_id":"3a6565075dea22411077c7dcac242d1c422801c2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d1e06ab79faa9fe4cafa0284685f44ef70bf976d","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                        # reach the server."},{"line_number":490,"context_line":"                        # This is useful in multi-node environment."},{"line_number":491,"context_line":"                        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:"},{"line_number":492,"context_line":"                            self._ping_ip(ip, 60)"},{"line_number":493,"context_line":"                            _floating_is_alive \u003d True"},{"line_number":494,"context_line":"                        elif CONF.validation.connect_method \u003d\u003d \u0027fixed\u0027:"},{"line_number":495,"context_line":"                            namespace \u003d _get_router_namespace(client,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_27973a3b","line":492,"range":{"start_line":492,"start_character":24,"end_line":492,"end_character":33},"in_reply_to":"7a740942_826b7ff0","updated":"2015-12-14 09:47:47.000000000","message":"The fact that we plan on using floating IPs to connect to the server, does not mean that the server will only have a floating IP - we still need to distinguish between floating and fixed IPs in the server body","commit_id":"3a6565075dea22411077c7dcac242d1c422801c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa086007f62917de4b189dd1a43a25706fe622b6","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        # create security group(s) after server spawning"},{"line_number":899,"context_line":"        for secgroup in server[\u0027secgroups\u0027]:"},{"line_number":900,"context_line":"            client.servers.add_security_group(server_id, secgroup)"},{"line_number":901,"context_line":"        if CONF.validation.connect_method:"},{"line_number":902,"context_line":"            floating_ip_pool \u003d server.get(\u0027floating_ip_pool\u0027)"},{"line_number":903,"context_line":"            floating_ip \u003d client.floating_ips.create_floating_ip("},{"line_number":904,"context_line":"                pool_name\u003dfloating_ip_pool)[\u0027floating_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_4e6814f6","line":901,"updated":"2015-12-15 07:33:06.000000000","message":"CONF.validation.connect_method -\u003e CONF.validation.connect_method \u003d\u003d \u0027floating\u0027","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"d359a68d8e6ded46512f94084bcfc63360492c4c","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        # create security group(s) after server spawning"},{"line_number":899,"context_line":"        for secgroup in server[\u0027secgroups\u0027]:"},{"line_number":900,"context_line":"            client.servers.add_security_group(server_id, secgroup)"},{"line_number":901,"context_line":"        if CONF.validation.connect_method:"},{"line_number":902,"context_line":"            floating_ip_pool \u003d server.get(\u0027floating_ip_pool\u0027)"},{"line_number":903,"context_line":"            floating_ip \u003d client.floating_ips.create_floating_ip("},{"line_number":904,"context_line":"                pool_name\u003dfloating_ip_pool)[\u0027floating_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_f06af519","line":901,"in_reply_to":"5a710552_4e6814f6","updated":"2015-12-15 10:43:00.000000000","message":"Good catch - thanks!","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"}],"tempest/config.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fdd229af58926e19576dc1ff14d8ba9d4be9933a","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                default\u003dFalse,"},{"line_number":656,"context_line":"                help\u003d\u0027Enable ssh on created servers and creation of additional\u0027"},{"line_number":657,"context_line":"                     \u0027 validation resources to enable remote access\u0027,"},{"line_number":658,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027run_ssh\u0027,"},{"line_number":659,"context_line":"                                                   group\u003d\u0027compute\u0027)]),"},{"line_number":660,"context_line":"    cfg.BoolOpt(\u0027security_group\u0027,"},{"line_number":661,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_aaa598b5","side":"PARENT","line":658,"updated":"2015-12-06 23:38:50.000000000","message":"This was added May 12th 2015, which is 6months+ ago, so I guess it\u0027s ok to drop now?","commit_id":"150662b5f62cc654f3f5e62f184659c5a13d7660"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"8a82eab5fc808278bf08d3d4f80a73a53453ecb0","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                default\u003dFalse,"},{"line_number":656,"context_line":"                help\u003d\u0027Enable ssh on created servers and creation of additional\u0027"},{"line_number":657,"context_line":"                     \u0027 validation resources to enable remote access\u0027,"},{"line_number":658,"context_line":"                deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027run_ssh\u0027,"},{"line_number":659,"context_line":"                                                   group\u003d\u0027compute\u0027)]),"},{"line_number":660,"context_line":"    cfg.BoolOpt(\u0027security_group\u0027,"},{"line_number":661,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4d5c43ed","side":"PARENT","line":658,"in_reply_to":"7a740942_aaa598b5","updated":"2015-12-07 09:05:31.000000000","message":"Yes.","commit_id":"150662b5f62cc654f3f5e62f184659c5a13d7660"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"261483a483482e079d6444338e2519c29d1e9084","unresolved":false,"context_lines":[{"line_number":662,"context_line":"                    \"when sshing to a guest.\","},{"line_number":663,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027ssh_shell_prologue\u0027,"},{"line_number":664,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":665,"context_line":"    cfg.StrOpt(\u0027ssh_user\u0027,"},{"line_number":666,"context_line":"               default\u003d\u0027root\u0027,"},{"line_number":667,"context_line":"               help\u003d\"User name used to authenticate to an instance.\","},{"line_number":668,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027ssh_user\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_2a8984c9","line":665,"updated":"2015-12-07 16:03:53.000000000","message":"I think this option could be deprecated by image_ssh_user as well.","commit_id":"c989e7c6f19feba484993c6219325ac509d53439"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa086007f62917de4b189dd1a43a25706fe622b6","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    cfg.BoolOpt(\u0027run_validation\u0027,"},{"line_number":605,"context_line":"                default\u003dFalse,"},{"line_number":606,"context_line":"                help\u003d\u0027Enable ssh on created servers and creation of additional\u0027"},{"line_number":607,"context_line":"                     \u0027 validation resources to enable remote access\u0027),"},{"line_number":608,"context_line":"    cfg.BoolOpt(\u0027security_group\u0027,"},{"line_number":609,"context_line":"                default\u003dTrue,"},{"line_number":610,"context_line":"                help\u003d\u0027Enable/disable security groups.\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_2ebca86b","line":607,"updated":"2015-12-15 07:33:06.000000000","message":"Just want to make sure that by removing this and other deprecation options, we used the deprecation period of 1 cycle. In any case that is not enough?\n\nI mean should we make it 2 cycle at least?","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"d359a68d8e6ded46512f94084bcfc63360492c4c","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    cfg.BoolOpt(\u0027run_validation\u0027,"},{"line_number":605,"context_line":"                default\u003dFalse,"},{"line_number":606,"context_line":"                help\u003d\u0027Enable ssh on created servers and creation of additional\u0027"},{"line_number":607,"context_line":"                     \u0027 validation resources to enable remote access\u0027),"},{"line_number":608,"context_line":"    cfg.BoolOpt(\u0027security_group\u0027,"},{"line_number":609,"context_line":"                default\u003dTrue,"},{"line_number":610,"context_line":"                help\u003d\u0027Enable/disable security groups.\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_b090eded","line":607,"in_reply_to":"5a710552_2ebca86b","updated":"2015-12-15 10:43:00.000000000","message":"Yes, we did. Those options I\u0027m removing have been deprecated since the beginning of the year, over 1 cycle. And we\u0027ll keep the new deprecated ones for at least 1 cycle, 2 if you think it\u0027s needed.","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59bff4727b13e121220d929dd1c9692ab8d32a29","unresolved":false,"context_lines":[{"line_number":620,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027ssh_connect_method\u0027,"},{"line_number":621,"context_line":"                                                  group\u003d\u0027compute\u0027),"},{"line_number":622,"context_line":"                                cfg.DeprecatedOpt(\u0027use_floatingip_for_ssh\u0027,"},{"line_number":623,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":624,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"},{"line_number":625,"context_line":"               default\u003d\u0027keypair\u0027,"},{"line_number":626,"context_line":"               choices\u003d[\u0027keypair\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_f720b44b","line":623,"updated":"2015-12-15 08:04:51.000000000","message":"\u0027use_floatingip_for_ssh\u0027 was bool but it is fine as it was used in Javelin only and its good to get rid of it which was always duplicate options.","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"d359a68d8e6ded46512f94084bcfc63360492c4c","unresolved":false,"context_lines":[{"line_number":620,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027ssh_connect_method\u0027,"},{"line_number":621,"context_line":"                                                  group\u003d\u0027compute\u0027),"},{"line_number":622,"context_line":"                                cfg.DeprecatedOpt(\u0027use_floatingip_for_ssh\u0027,"},{"line_number":623,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":624,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"},{"line_number":625,"context_line":"               default\u003d\u0027keypair\u0027,"},{"line_number":626,"context_line":"               choices\u003d[\u0027keypair\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_d0b0198e","line":623,"in_reply_to":"5a710552_f720b44b","updated":"2015-12-15 10:43:00.000000000","message":"Ok!","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aa086007f62917de4b189dd1a43a25706fe622b6","unresolved":false,"context_lines":[{"line_number":641,"context_line":"               default\u003d60,"},{"line_number":642,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":643,"context_line":"                    \u0027successful.\u0027,"},{"line_number":644,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027connect_timeout\u0027,"},{"line_number":645,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":646,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"},{"line_number":647,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_6edb901c","line":644,"updated":"2015-12-15 07:33:06.000000000","message":"I did not find \u0027connect_timeout\u0027 in comoute section do you mean \u0027ssh_channel_timeout\u0027 or just remove the deprecation?","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"d359a68d8e6ded46512f94084bcfc63360492c4c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"               default\u003d60,"},{"line_number":642,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":643,"context_line":"                    \u0027successful.\u0027,"},{"line_number":644,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027connect_timeout\u0027,"},{"line_number":645,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":646,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"},{"line_number":647,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_f0ad1532","line":644,"in_reply_to":"5a710552_6edb901c","updated":"2015-12-15 10:43:00.000000000","message":"Good catch - my bad. ssh_channel_timeout has been deprecated for over a cycle.","commit_id":"40305ce071d2ac77f4c2d1c6a83751115d245e67"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3ef892de4d409e421181f621718df36ac2696037","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    \"servers if tempest does not create a network or a \""},{"line_number":251,"context_line":"                    \"network is not specified elsewhere. It may be used for \""},{"line_number":252,"context_line":"                    \"ssh validation only if floating IPs are disabled.\"),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027network_for_ssh\u0027,"},{"line_number":254,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":255,"context_line":"               help\u003d\"Network used for SSH connections. Ignored if \""},{"line_number":256,"context_line":"                    \"use_floatingip_for_ssh\u003dtrue or run_validation\u003dfalse.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a710552_42b0d643","line":253,"updated":"2015-12-15 12:29:44.000000000","message":"I think this option should be migrated to \u0027validation\u0027 group, too.","commit_id":"61fc20dda687f97680932e0d303c6e79f22ebb76"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"80c239914eaa47aabac7ea3617946ec92d6e3fa8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    \"servers if tempest does not create a network or a \""},{"line_number":251,"context_line":"                    \"network is not specified elsewhere. It may be used for \""},{"line_number":252,"context_line":"                    \"ssh validation only if floating IPs are disabled.\"),"},{"line_number":253,"context_line":"    cfg.StrOpt(\u0027network_for_ssh\u0027,"},{"line_number":254,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":255,"context_line":"               help\u003d\"Network used for SSH connections. Ignored if \""},{"line_number":256,"context_line":"                    \"use_floatingip_for_ssh\u003dtrue or run_validation\u003dfalse.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a710552_e5d8ec55","line":253,"in_reply_to":"5a710552_42b0d643","updated":"2015-12-15 12:57:13.000000000","message":"Good catch - thanks!","commit_id":"61fc20dda687f97680932e0d303c6e79f22ebb76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"78db5225271198de4cd647a8e43b3d23a3244fb8","unresolved":false,"context_lines":[{"line_number":654,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":655,"context_line":"                    \u0027successful.\u0027,"},{"line_number":656,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027connect_timeout\u0027,"},{"line_number":657,"context_line":"                                                  group\u003d\u0027compute\u0027)]),"},{"line_number":658,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"},{"line_number":659,"context_line":"               default\u003d300,"},{"line_number":660,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the ssh banner.\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7e1126_c12ab02c","line":657,"range":{"start_line":657,"start_character":64,"end_line":657,"end_character":69},"updated":"2015-12-16 23:57:31.000000000","message":"deprecated_opts should be removed as there is no \u0027connect_timeout\u0027 in compute","commit_id":"7eca9314dce8078c4dd242948512f13eb9cfb686"}]}