)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"36eefd75407c2a2fd87e45d1b31d29877c29397c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Felix Li \u003cliljb@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-11 09:58:34 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove wrong comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"delete \"(in alphabetical order)\" in the comment"},{"line_number":10,"context_line":"since client is not defined in alphabetical order"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_f63826d5","line":7,"updated":"2015-12-12 13:23:57.000000000","message":"You should also change the commit message in accordance with new changes :)","commit_id":"d2f836faf47282a3bc173f5b4e536946636869bc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7a69b22cfe1306f44778682213af1728962476a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Felix Li \u003cliljb@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-13 16:01:06 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove wrong comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Split multi clients into clients groups, sucha as"},{"line_number":10,"context_line":"Cinder clients, Nova clients."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a710552_62b09c8c","line":7,"updated":"2015-12-14 19:41:53.000000000","message":"It looks like this title doesn\u0027t describe the purpose of this patch. What about\n\n    Splitting clients into client groups in manager.py","commit_id":"96e0099b40bf039bc92433056ab38f12e67db08b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7a69b22cfe1306f44778682213af1728962476a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove wrong comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Split multi clients into clients groups, sucha as"},{"line_number":10,"context_line":"Cinder clients, Nova clients."},{"line_number":11,"context_line":"If need to add more clients, just need to add them to"},{"line_number":12,"context_line":"corresponding clients, this structure will be more clear."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a710552_6225fcc0","line":9,"updated":"2015-12-14 19:41:53.000000000","message":"sucha -\u003e such","commit_id":"96e0099b40bf039bc92433056ab38f12e67db08b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7a69b22cfe1306f44778682213af1728962476a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove wrong comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Split multi clients into clients groups, sucha as"},{"line_number":10,"context_line":"Cinder clients, Nova clients."},{"line_number":11,"context_line":"If need to add more clients, just need to add them to"},{"line_number":12,"context_line":"corresponding clients, this structure will be more clear."},{"line_number":13,"context_line":"Client groups and clients in each group will follow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a710552_822268b8","line":10,"updated":"2015-12-14 19:41:53.000000000","message":"Cinder clients, Nova clients, etc.","commit_id":"96e0099b40bf039bc92433056ab38f12e67db08b"}],"tempest/scenario/manager.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5040b90252a3f17b99f40e04dfc5611e75198495","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def setup_clients(cls):"},{"line_number":47,"context_line":"        super(ScenarioTest, cls).setup_clients()"},{"line_number":48,"context_line":"        # Clients"},{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.manager.flavors_client"},{"line_number":50,"context_line":"        cls.compute_floating_ips_client \u003d ("},{"line_number":51,"context_line":"            cls.manager.compute_floating_ips_client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_9286aed9","line":48,"updated":"2015-12-07 16:50:14.000000000","message":"Actually, this comment doesn\u0027t tell me anything. Here we have a mess: some clients have the corresponding comments, some not. What about splitting this clients into client groups? Something like this:\n\n    # Cinder clients\n    \u003cclients\u003e\n\n    # Glance clients\n    \u003cclients\u003e\n\n    # Heat clients\n    \u003cclients\u003e\n\n    # Neutron clients\n    \u003cclients\u003e\n\n    # Nova clients\n    \u003cclients\u003e","commit_id":"a331847cb779880bd33997fc3c96df4c86d2597a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d1068a9ad173c3767f12d54b896c9099099e9b74","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(ScenarioTest, cls).setup_clients()"},{"line_number":48,"context_line":"        # Nova flavors client"},{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.manager.flavors_client"},{"line_number":50,"context_line":"        # Nova floating ips client"},{"line_number":51,"context_line":"        cls.compute_floating_ips_client \u003d ("},{"line_number":52,"context_line":"            cls.manager.compute_floating_ips_client)"},{"line_number":53,"context_line":"        # Glance image client v1"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6433e7f6","line":50,"updated":"2015-12-09 00:31:30.000000000","message":"NIT: I think it makes sense to have a comment only where it\u0027s ambiguous otherwise. compute_floating_ip_client seems clear enough","commit_id":"73d03c4bd816546499c3475608d2bfe3be56e3f7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d1068a9ad173c3767f12d54b896c9099099e9b74","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        cls.keypairs_client \u003d cls.manager.keypairs_client"},{"line_number":58,"context_line":"        # Nova security groups client"},{"line_number":59,"context_line":"        cls.security_groups_client \u003d cls.manager.security_groups_client"},{"line_number":60,"context_line":"        cls.security_group_rules_client \u003d ("},{"line_number":61,"context_line":"            cls.manager.security_group_rules_client)"},{"line_number":62,"context_line":"        cls.servers_client \u003d cls.manager.servers_client"},{"line_number":63,"context_line":"        cls.interface_client \u003d cls.manager.interfaces_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_249e3fb9","line":60,"updated":"2015-12-09 00:31:30.000000000","message":"As you\u0027re at it, I think it would be cool to have a comment before L60, to mention that L60 is Neutron networks client","commit_id":"73d03c4bd816546499c3475608d2bfe3be56e3f7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d1068a9ad173c3767f12d54b896c9099099e9b74","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        cls.interface_client \u003d cls.manager.interfaces_client"},{"line_number":64,"context_line":"        # Neutron network client"},{"line_number":65,"context_line":"        cls.network_client \u003d cls.manager.network_client"},{"line_number":66,"context_line":"        cls.networks_client \u003d cls.manager.networks_client"},{"line_number":67,"context_line":"        cls.ports_client \u003d cls.manager.ports_client"},{"line_number":68,"context_line":"        cls.subnets_client \u003d cls.manager.subnets_client"},{"line_number":69,"context_line":"        cls.floating_ips_client \u003d cls.manager.floating_ips_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_0470e3a2","line":66,"updated":"2015-12-09 00:31:30.000000000","message":"As you\u0027re at it, I think it would be cool to have a comment before L66, to mention that L66 is Nova networks client","commit_id":"73d03c4bd816546499c3475608d2bfe3be56e3f7"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d803047495be0186ab890f8dfd8d13b2d0455941","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def setup_clients(cls):"},{"line_number":47,"context_line":"        super(ScenarioTest, cls).setup_clients()"},{"line_number":48,"context_line":"        # Nova flavors client"},{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.manager.flavors_client"},{"line_number":50,"context_line":"        # Nova floating ips client"},{"line_number":51,"context_line":"        cls.compute_floating_ips_client \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6a6edbca","line":48,"updated":"2015-12-10 19:25:56.000000000","message":"I really don\u0027t understand why we keep a comment on each client variable. The names of client variables are clear enough, and current comments are not helpful at all. What about structure I was talking about in patch set 1. \n\n    # Cinder clients\n    if CONF.volume_feature_enabled.api_v1:\n        cls.snapshots_client \u003d cls.manager.snapshots_client\n        cls.volumes_client \u003d cls.manager.volumes_client\n    else:\n        cls.snapshots_client \u003d cls.manager.snapshots_v2_client\n        cls.volumes_client \u003d cls.manager.volumes_v2_client\n\n    # Glance clients\n    cls.image_client \u003d cls.manager.image_client\n    \n    # Heat clients\n    cls.orchestration_client \u003d cls.manager.orchestration_client\n\n    # Neutron clients\n    cls.floating_ips_client \u003d cls.manager.floating_ips_client\n    cls.network_client \u003d cls.manager.network_client\n    cls.networks_client \u003d cls.manager.networks_client\n    cls.ports_client \u003d cls.manager.ports_client\n    cls.subnets_client \u003d cls.manager.subnets_client\n\n    # Nova clients\n    cls.compute_floating_ips_client \u003d cls.manager.compute_floating_ips_client\n    cls.flavors_client \u003d cls.manager.flavors_client\n    cls.images_client \u003d cls.manager.images_client\n    cls.interface_client \u003d cls.manager.interfaces_client\n    cls.keypairs_client \u003d cls.manager.keypairs_client\n    cls.security_groups_client \u003d cls.manager.security_groups_client\n    cls.security_group_rules_client \u003d cls.manager.security_group_rules_client\n    cls.servers_client \u003d cls.manager.servers_client\n\nI think this structure will be helpful because we separate clients for migrating them to tempest-lib, and in this case we will just add a client to the corresponding clients group.","commit_id":"3c3037519dd461896be995e841792a7a1bbbc3e6"},{"author":{"_account_id":16425,"name":"Bin Bin Cong","email":"binbin.cong@easystack.cn","username":"stephen_cong"},"change_message_id":"6c3fd469bc4cc0652533f34b874ba1ed8b11c0dc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def setup_clients(cls):"},{"line_number":47,"context_line":"        super(ScenarioTest, cls).setup_clients()"},{"line_number":48,"context_line":"        # Nova flavors client"},{"line_number":49,"context_line":"        cls.flavors_client \u003d cls.manager.flavors_client"},{"line_number":50,"context_line":"        # Nova floating ips client"},{"line_number":51,"context_line":"        cls.compute_floating_ips_client \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_7863071b","line":48,"in_reply_to":"7a740942_6a6edbca","updated":"2015-12-11 02:52:27.000000000","message":"I will echo this structure, it looks more clear","commit_id":"3c3037519dd461896be995e841792a7a1bbbc3e6"},{"author":{"_account_id":16425,"name":"Bin Bin Cong","email":"binbin.cong@easystack.cn","username":"stephen_cong"},"change_message_id":"606a32fb12cdff3a06bbe74f2a5337c9da32ece6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        cls.security_group_rules_client \u003d ("},{"line_number":62,"context_line":"            cls.manager.security_group_rules_client)"},{"line_number":63,"context_line":"        cls.servers_client \u003d cls.manager.servers_client"},{"line_number":64,"context_line":"        # Nova interfaces client"},{"line_number":65,"context_line":"        cls.interface_client \u003d cls.manager.interfaces_client"},{"line_number":66,"context_line":"        # Neutron network client"},{"line_number":67,"context_line":"        cls.network_client \u003d cls.manager.network_client"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_83dc8247","line":64,"updated":"2015-12-10 05:35:55.000000000","message":"Should be Nova interface client, not interfaces?","commit_id":"3c3037519dd461896be995e841792a7a1bbbc3e6"},{"author":{"_account_id":16425,"name":"Bin Bin Cong","email":"binbin.cong@easystack.cn","username":"stephen_cong"},"change_message_id":"606a32fb12cdff3a06bbe74f2a5337c9da32ece6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        cls.networks_client \u003d cls.manager.networks_client"},{"line_number":70,"context_line":"        cls.ports_client \u003d cls.manager.ports_client"},{"line_number":71,"context_line":"        cls.subnets_client \u003d cls.manager.subnets_client"},{"line_number":72,"context_line":"        cls.floating_ips_client \u003d cls.manager.floating_ips_client"},{"line_number":73,"context_line":"        # Heat client"},{"line_number":74,"context_line":"        cls.orchestration_client \u003d cls.manager.orchestration_client"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_4320da49","line":72,"updated":"2015-12-10 05:35:55.000000000","message":"Since you made the nova floating ips client clear, it will be good to make this neutron floating ips client clear.","commit_id":"3c3037519dd461896be995e841792a7a1bbbc3e6"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d1e07b08cdd2888f2ffa194bc54923a29d264730","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(ScenarioTest, cls).setup_clients()"},{"line_number":48,"context_line":"        # Cinder clients"},{"line_number":49,"context_line":"        if CONF.volume_feature_enabled.api_v1:"},{"line_number":50,"context_line":"            cls.volumes_client \u003d cls.manager.volumes_client"},{"line_number":51,"context_line":"            cls.snapshots_client \u003d cls.manager.snapshots_client"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cls.volumes_client \u003d cls.manager.volumes_v2_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_16eebd22","line":50,"updated":"2015-12-14 19:45:02.000000000","message":"To reach full consistency it should be\n\n    cls.snapshots_client \u003d cls.manager.snapshots_client\n    cls.volumes_client \u003d cls.manager.volumes_client","commit_id":"96e0099b40bf039bc92433056ab38f12e67db08b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d1e07b08cdd2888f2ffa194bc54923a29d264730","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            cls.volumes_client \u003d cls.manager.volumes_client"},{"line_number":51,"context_line":"            cls.snapshots_client \u003d cls.manager.snapshots_client"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cls.volumes_client \u003d cls.manager.volumes_v2_client"},{"line_number":54,"context_line":"            cls.snapshots_client \u003d cls.manager.snapshots_v2_client"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Glance clients"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_76ddc16f","line":53,"updated":"2015-12-14 19:45:02.000000000","message":"ditto","commit_id":"96e0099b40bf039bc92433056ab38f12e67db08b"}]}